From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06AB037B03B for ; Mon, 23 Mar 2026 08:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774255659; cv=none; b=iIrfPZ/+afS0EjoYOcM4jJ/QO8wPjCBcJCoTWocja5XH9+DB1aHzLh061gtd78O5bNM2t++tDMyVyMIFNJ5MzzyJjxkbileOCwLrZYqfy7bqKtlH0/+rUCzYuHUKZEucByG1EZAdH0JPextFsDuwAfgrPEeY5sDXToJ0dtGJGxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774255659; c=relaxed/simple; bh=R61Nw2j4SvjypvcYUmq/X59kiP28Pp9UFLl5iFfoRCA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jA1iLdK7KLr9z6ED379z8+t8RdPbPmMLS1pVmJIBU+DnZv++u2vt8x7tk1Jp5HuhqVMaPp4yvxfrhh/5TS0euphbYE0dBROfYL1RzP7Y2X+FvK+utS6p/xEvNu3Brck2pyiVK9i85R5KMZLqQO5hk96C8fAbKMrmHdg8Wjp2RY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ys6izEaP; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ys6izEaP" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so2878695f8f.3 for ; Mon, 23 Mar 2026 01:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774255655; x=1774860455; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n3wYxzLxYzsIq8UX8gx/UrnQDt6+9p5J6k+891+usy8=; b=ys6izEaPjvPaBKyR587DYe/Et45aFr74+os+YEB8rMTtqpTcGbL0YTIAIx+PQAyrt+ 9lh62JDSa1pS7evfPLCNT8YCCTxxAe56/M2ZT7vVOW1HkyME4ShLk0qQKJOUGkEX/Qo2 TBUDuP4mTiuSPDKMNP77wgo63Ml6+yAqNsVNnzEWq+/UI0ddkMgeLRemWLDThRq6HWyt +I0/GHAe66wOZMBw3j/hVsv5494R4F9dbL1JWLAwCKtNTHgaYhPGOm0XsrGJGe9ZR7s8 +0X0npzD6WhkGsRnLbgRy8dKMagh97zUYYls733H6VkjYKkDAZAsqea7UiOgqa1yU+Ew TBfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774255655; x=1774860455; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n3wYxzLxYzsIq8UX8gx/UrnQDt6+9p5J6k+891+usy8=; b=BkSVEONjtZjigbLBX6v0Huz1R0vtg4sttS+QZ3sDpdx+egGUacZe/RYI94D4ovrV0w wPdHqob1QamoLCxZoVz+kornNmAy9RCTpVjEX3zkDMz8yuSFyv2V098SQRHRso4r06EF 8yO73+z6MEoVXHk9iFORBSu1zVMsMZ32nnPc+yhjDgfoYJBhFK+GPzYqycQY0PIQuoxn 5UkhreJuy78SFYJfhHrsu3CjECbMaLtnI56CYY30k4+YNZsLrErKY1tUHPN6YIBtefw2 sz5cU2jNy8PUftmjQv3iapP43eHammwiLvQsZfjbRyCHzneX1Y6imrOvhFN3M0jdJImU 931A== X-Forwarded-Encrypted: i=1; AJvYcCXib9qAHhsY8Ima4Fs6VHq2lvP+QATf0ENTqmNUMWRBBuanMGjRBhZxlcApaUHX0P6rvOqj5RJB+jIjvbk=@vger.kernel.org X-Gm-Message-State: AOJu0YwoFfkuvsEameQPjcOx+juorCSdEZyppMYjjp47U/DMj20DGMed xLj/F+hEw6ZSvsvQUGj1Wt5M/hK5ESS7s329AOAGewnE4jOOEgDhoDi/Dav4qRX8X58= X-Gm-Gg: ATEYQzxhGqTvnMFO9uQnBRdmXzol3isXCb/oLUpipWfoIpRQgh+ishP+/DWAENZbxCz 1ovq73uCCWItS4SBycUNMfmPtVigRYWkcFIxUHOfgoCLVZ3H4IpEFRpyBbCrz8SI0gIL2GMWMYf 49uOmhjuApuBAZ28cCLgvDJxq6RnYVtIOLaUKwjzDPIzzMoigBWDp/mrbinz0wKtFmoORMq5mBp PkPS5egM1XH9rFreC7GAOnC5gU5U0ulYTCK0fDM0PFC5TWHlI9fC6lt0rIOqsd3yy6cGn/QmnT4 5A9203TDIarXs4E6ABwos3q4/hSyjQLGaaTQE9p+LIb5An5rHIsaY85OCi9uAQeZQgpM1uhYujn CoCVmEEVgZiwlAaojLs9Ndtg5xiG3itjOiivbX0Ko+gRY5K9CHXxR5N+EOI2CxPI3lTYYDTTye4 OBEztp3NrdZgssCO7OG1vKBfnUFcjO X-Received: by 2002:a05:6000:2007:b0:43b:4e13:2213 with SMTP id ffacd0b85a97d-43b6428baa5mr18529961f8f.51.1774255654977; Mon, 23 Mar 2026 01:47:34 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae37dsm27744127f8f.2.2026.03.23.01.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 01:47:34 -0700 (PDT) Date: Mon, 23 Mar 2026 11:47:31 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: Aadarsh Mandal , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, luka.gejak@linux.dev, straube.linux@gmail.com Subject: Re: [PATCH v6] staging: rtl8723bs: remove commented-out code Message-ID: References: <20260318021005.6346-1-aadarshmandal9354@gmail.com> <20260322114853.11747-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Mar 22, 2026 at 05:01:30PM -0500, Ethan Tidmore wrote: > On Sun Mar 22, 2026 at 6:48 AM CDT, Aadarsh Mandal wrote: > > - Remove code that is not used anywhere in driver. > > Probably remove unused code would be better. This doens't matter. The other stuff is true, particularly the missing S-o-by line. regards, dan carpenter