From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011026.outbound.protection.outlook.com [52.101.65.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7F87199FBA for ; Mon, 23 Mar 2026 12:36:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.26 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269393; cv=fail; b=DJtqEmc/PWUkUlnOjLOQdFqz8n2OoysraihRJaJQGEFJRYwbv3/QTjY2v+sUh0y61NZsbX/Nmu0q5LKdaErERz+gQHx3zwJZSKQfW+PzgrO+A3ZAJroP5LMxKJqYBbGFWFjVC3bTATh3XxNb0Hlu1UuNmIFyJsecIH7+AJ73jes= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269393; c=relaxed/simple; bh=3rhKSGoR1mJYg1ExwjXHj9cE6kh6dp07UT8TQdR+MgU=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=eOt3C8br83++txJwyF9/4KuDBauxs4MxvfDfn7YV3Vn5bZNTgwEQUkt9jU2sRGTQpAlwhnyTc+9JJv/+viC4nPH7wzM5h/fnevoSuPLlT/yvQu1ksvqNa/RwItQWxU03V0V7fXtO7itz5rXbtWFlxYVYEdmRNQygaDWz0FXv+yU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Q9DrMy3T; arc=fail smtp.client-ip=52.101.65.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Q9DrMy3T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YLdls770IbFI7yta/aOs9ylEB2qUvtpapdJiC1M9QlioCcpKL7qhw6L5S8Fpsay8CrtqF1DS67Ja7ASghhGAv7s4xi8TRYzGNc2rMZ80Y03oYLuRJVy5xe9ifiRnyBm9cD7frFne1t7CqfJ/PQVQ8i3V0BXTvAfvhcg7Dz5fndgrxrG2plI0SqlQ5zoCdxsG3td1jj/TP69QKnoIkz+2ydjWV5/F43cr83jU4632S57lxLQIUIhwTWTXNmncVp2c/Vruy+2Yrt1W7ikYdfFZqWqFFFNFy/2i00Fubj2WwCcQ3+9eF8/8lKdo6cGHMCiisn/YB1ZOICcMGXrwUs/MCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ibeCsBk9NQ6sXU6Wx/SzdcORDr3j+MH49UgtXEYxe7s=; b=Q+faTVdhv5GcwpcO10mifb3xoftHpe+0rM81K686tctox9uPY+IXw4yIVMbgzlyAFLHbi6DWScSOZn5W6ku5aPHeYX0CLEWXA52YJQz7jtnrm6oEfEvftrCQ6qPaNTUjiqzSXlIqIrdqYkCKckgABdczUY6AyONhQ/kXwMITd24iSNEfevVvnV5sswThGS6RrVgOA+a6Asv7eNiTyGiOItXG/Rk55HPcDvGtYFDQKX+I2OiyVCfm9AlG/QYiLZdGmuqeGw1oARG7OWllqQj4bby88wG7pafQRfdp4HMiInoQ70FtOALpEljIcsf08IjDeXUKezu2W5Mg/YLDZ/SCoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ibeCsBk9NQ6sXU6Wx/SzdcORDr3j+MH49UgtXEYxe7s=; b=Q9DrMy3Tv26iEIVzGqggnjSP7+RCtshIsrh7fnT2E5NIoUTylAzZprQxxCcsQZCx5pqHpQRrlKUHbdXkH4gNFoWpXRa93FEqxJfoKAt4GIfUVYllMpXGxbc8wrQptl6c/5WYVhO9ZBQ/FGClgn6PKJ4U8bMmuLBobbkQTuuML0Bk8scSF8ShnzYZgOirjBXTenVeYsN2QxLjjY3uKKSEfQHz+ejSuDxSRZgiKvoIq0ZZA+ApsXApcUKH4B2Z1VbsWS5Sabjxp55HrstUFUzl514bZZXfoStyTco3q6yQBo4YmqT5bKTTa+WvsvoKS3+AEKN6HzbpyaYXJB6N2top6A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) by PA1PR04MB10468.eurprd04.prod.outlook.com (2603:10a6:102:448::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 12:36:11 +0000 Received: from DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::21f6:947a:1f40:18af]) by DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::21f6:947a:1f40:18af%4]) with mapi id 15.20.9723.030; Mon, 23 Mar 2026 12:36:15 +0000 Date: Mon, 23 Mar 2026 20:38:24 +0800 From: Peng Fan To: Laurent Pinchart Cc: Mark Brown , Liam Girdwood , Frieder Schrempf , Joy Zou , linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type Message-ID: References: <20260310-pca9450-irq-v1-0-36adf52c2c55@nxp.com> <20260310-pca9450-irq-v1-1-36adf52c2c55@nxp.com> <28dad7ac-3f09-4f0a-a9f9-cfe329f8670a@sirena.org.uk> <20260323105858.GA2185714@killaraus.ideasonboard.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260323105858.GA2185714@killaraus.ideasonboard.com> X-ClientProxiedBy: SG2PR01CA0116.apcprd01.prod.exchangelabs.com (2603:1096:4:40::20) To DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB8461:EE_|PA1PR04MB10468:EE_ X-MS-Office365-Filtering-Correlation-Id: 7205b525-cd59-456e-fd31-08de88d8bf8b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|1800799024|19092799006|38350700014|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: jXcOgQsbpBYkyZgXdMGQX0liI3waRHizEp9MQmcNrCbMSrMdW7pWJZFgb5j6BdFnH1Cg4ndzICj2yP8yGkWcGtd+0VYP2xq3XXv8Hty6DJV/jR8SEdW+JKYzputUFIAaXwgQQmLT0BGHS+vL4IduAYMW1LNpaFQznU5UaptHlfGRDh6nh0gdajv53wIyLOlbPmkdwPzXYHs80WFev9JtKvKX+LvJtfZWeAhAOXy0RvICyJS8rLcsJXTIfTOquU26+8Rkpi5Rnwj+Wi2U2W2PqUmAjNxf6Duh4UDGyklNIgs3zmUqgCZQVJUEmoRby6k4hcjXUdnfTF5I3AvBy+ygXZrrHabDLF+Rx772UxREAAptqJKdLu9+ODi59pQ8X0Xx/3hiddoCfxHD8vk0JMruAm1nafwbIdhkg3aYTs6VRirNaL6dIqWcDrMSH/iypc/sRqHIQ1z0rdzU2DohOaWjr2dD8mBtHhAWMBsIxu9k+4CPFofBfB0TR07PsgR5an4enfELGWd3xERD/HlU6DlkeMPTJtrs06+Q5CGeWPCoAt7UYUEH9v4HYZ8v5FRIKZki7g8LKXUacbIX3tOcJJTlaSJ9kRgTA+O12ufC1FEj5XGD4/7jg6fBLUjRRkfC5nHDOXxY1k+GwrR4DIK98yoV+F0MMmTis3Qu2KLAGvV/AIPwwmj8Z+IStNt3DsHe9mckNWevrXF/XzolzGNPF3UCH3fldwVxIzMZ9xuPn1qdZnZdKWXmAudremLl9of3+B6VGReiWhl07xzy7ucDdTh9lOgTH2vHBVBqJG8EL8BHhSI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8461.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Mv/vPd4vX2Q4iTpo8Y0NKCgs7DFhV9E3ks26CSlrPevNppd1isgC0jZoRXKA?= =?us-ascii?Q?6R96DyQaCcADL75AuM4G5h4oKmtZmPZHJtaLiybFLevKG4/Rn/9onP0dhG3M?= =?us-ascii?Q?HwHJX0SevFS5rJD1XdancgKSA8MY0n8UIbxRBuI6DQzmVNH/l/leZVT6vseC?= =?us-ascii?Q?0GDBnVlMoRgXtYysuFT9xX63ci/gOLPFYd3kd8J8kDMyjxjn62n0FQMZEpOQ?= =?us-ascii?Q?Ty+w3lj/05QFV4ntDR04YTZ7OJlzHZWxAaVhIewDn5rOCMZ0vlDLtkG6jIRX?= =?us-ascii?Q?T36+wOCZDAAXNIH1b5GiPdsSpzmrtsnu1rNmMCrfdUyeG3cpMSoAppJsLJCQ?= =?us-ascii?Q?XppWM3xPlTzp3rdF1HFFpoqmaxwvCNUbCaJasGU/Vht3FCLrBn2EQT8NYDAp?= =?us-ascii?Q?zQsEqREjw+GD2Jd4p1JSTCX6AYKRxWlnt8gws/XsH0w5Hc61jdbJMPASLU3Q?= =?us-ascii?Q?hzhHeSdY4ZzCEI5KkX97CCorA0RkrKwRXDdwwimZXNiskNvUJZk5kJwrUdDp?= =?us-ascii?Q?hPEmi5B8eOP/PwDYPgcIrklrplrAZiohNL/DfeUjL/DTG9fTvyvkbo7Si8Iq?= =?us-ascii?Q?IoVZ7nijQeesJTH4J21mu3vQQZu7JT0fdEQ4v7P2BXZC0YCCGZAECeslML1v?= =?us-ascii?Q?9Gsk2rGD2JvYrrhiLjobeDFaSeOCIgqHZm0fi0jg971SC2QFaJbV6l1dQKfX?= =?us-ascii?Q?/ZdbPPohYFA5SNlcEdrmv3WIPWpNKKMQk9Vyr2lDCyqLyT8n8zotc/TRAXCf?= =?us-ascii?Q?oA9kZ9wtyR+ZDb3YCn395vpmhXBbF42H07MJVg6VqD1NL3WKuS53hTreKdLq?= =?us-ascii?Q?I+Kw6f9tkdwGnrI3bBaf7Ep7y6uglBmnor+j+HZ2X/tnoqCbRZ0OMZJJUODU?= =?us-ascii?Q?EuCEldQsIBv1tg2vVGh6MgyvmbIeA+XdfbtEUy7saCCx+YvAwdHqUftUVAlb?= =?us-ascii?Q?+RrB6OBO74MFAoqsuJYP+BlFTu5cEKa6zykdSB+gHSRhKYjxME+Ugp+s3goc?= =?us-ascii?Q?UjrMARK6VAvg9DgVGo4tNGwDOJzSmIzr61cjnp2utjKlKrCOFruUzUQ20EEw?= =?us-ascii?Q?xeXcVCd7v4ejJvpOQ6CfolKQSwUED8TZ04pjgLaVqxOagAyjiII0BznVikr2?= =?us-ascii?Q?VFhPfb1Iqyfa6TU/ajUgugpBBZ2zF0NHcGhdAUoVC8gZecyuQUUUF3M+TRaN?= =?us-ascii?Q?4SxooWQhUA8FEbpqL2Q5+HG/qBK1iFZ47TZz9N6VM5SozwZa4IvoGdOaZKDh?= =?us-ascii?Q?JRRu9DxQYskqAfDzkmEXtqN2wyygZ3dEblODcYurcQMAr2JmhK66D8ttWJ7P?= =?us-ascii?Q?ZOKtA2nuNwDKiUI6mKr8/lWOIdryqNqzudEyC9G509GtXCDgrZfigAlt9JEW?= =?us-ascii?Q?4MNxcnEeJ9cVYY0en9jENy+7HMlBe+PIbxPDVYVoUqqdo2o8Y4a5Z2AnjbV7?= =?us-ascii?Q?TL0uC+cnSaIut46nm9VZL8PnauvLQbj6Br9hdTUrg2NF7sBBw2AyIgZOC8Xu?= =?us-ascii?Q?4GP1g1RTW+fyVM6tgLUN9r6NcBaUe+uiuhms1QHKMcee7M5oU4IMXgpb+REl?= =?us-ascii?Q?29sV2PvdP29evfVE58xyjLAEm/gn4LCBIc1le9otZ2peKv+Ye4m9zOS0tnMg?= =?us-ascii?Q?1qqOZkVCojCd1f8hEb/rKtkUR/oa+cVQBhMApF5XaFCzyCckKAzMKTj+4do4?= =?us-ascii?Q?CGNDKrlUM2tmw/RiAwOGCZAxEEyAIzxR7GOg/Mw4V/SrMvINWqw+pik+MQlJ?= =?us-ascii?Q?VC3VU8jJvg=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7205b525-cd59-456e-fd31-08de88d8bf8b X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 12:36:15.7324 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +3x6mjtylYNrjluPBFGG5Rvh+scDXJM9H6XYpYe1AfqlG6pJqEMwhXgH9epLCw34BQXIZaUQHiuJcmIZ1f2/tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10468 Hi Laurent, On Mon, Mar 23, 2026 at 12:58:58PM +0200, Laurent Pinchart wrote: >On Tue, Mar 10, 2026 at 01:15:34PM +0000, Mark Brown wrote: >> On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote: >> > From: Peng Fan >> > >> > Kernel warning on i.MX8MP-EVK when doing module test: >> > irq: type mismatch, failed to map hwirq-3 for gpio@30200000! >> > >> > Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked >> > interrupt bit status is changed and it is released high once application >> > processor read INT1 register. >> > >> > So the interrupt should be configured as IRQF_TRIGGER_LOW, not >> > IRQF_TRIGGER_FALLING. >> >> There appear to be a bunch of DTS files which specify edge triggered >> interrupts for these devices (eg, imx8mm-emtop-som.dtsi and >> imx8mp-debix-model-a.dts) though more getting it right. Not an issue >> for this patch but probably wants cleaning up. > >This patch creates an interrupt storm on the i.MX8MP-based Debix Model A >board. I'm getting about 700 interrupts per second from the PMIC (and >about 3000 interrupts per second from the I2C controller). > >arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts specifies the >PMIC interrupt as IRQ_TYPE_EDGE_RISING, setting it to IRQ_TYPE_LEVEL_LOW >does not help. > >Peng, I can run test to debug the issue if you tell me what to test. I'd >like to fix the problem and avoid an annoying regression in v7.0, either >with a follow-up patch, or with a revert if we're too short on time. Please help try whether below changes could help. I checked the schematic and iomux settings, I suspect the pad settings might not be correct, it does not have PE set, even it has PUE. Without PE, PUE will not work per my understanding. If below patch works for you, I will post this patch to list. otherwise, we have to revert my patch or remove IRQ_TRIGGER_LOW when calling devm_request_irq(). diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts index 9422beee30b29..df7489587e48e 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts @@ -440,7 +440,7 @@ MX8MP_IOMUXC_SAI5_RXC__I2C6_SDA 0x400001c3 pinctrl_pmic: pmicirqgrp { fsl,pins = < - MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x41 + MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x000001c0 >; }; Thanks, Peng > >-- >Regards, > >Laurent Pinchart >