From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6394C382297 for ; Mon, 23 Mar 2026 12:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774270056; cv=none; b=sRvfq5sJem4lmZF9I0FMHprY8Ao0IcFSM6ZOkTXDJwq/W49waSvucIb6/KNTi0zrrQVhcunqPbUQK+SeoPrukpdb2rO2TNdgmoNV/zA/8mkddUjI78Be25E+b6PDAKGxL4CsOzZjzwhCiehzHJp+H8EdU5iTsrie+pzhW9uZxgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774270056; c=relaxed/simple; bh=MM2fN5GdnEJYHW9MITbLdhoSmIAOoGWsDFQGNHwaPQw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tiaC/E+qRm2gMi/F8ZsGIyXkIh8sQ6eihVpRst30T5SHCKS/x1Ymiqkwk5PMEu4qYIrfpsZeNF4ioOuzyQFNsDw8i1jTjsqOXD/tsunMSIEUngj+2X1u05Y1BgqQr3dkrGfLUlOOpgQkVvkDjbAmVNgav1C4zaYokNwnbaBBQWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ng6tOn5Q; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ECtEj5Zr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ng6tOn5Q"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ECtEj5Zr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774270051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0u4DoGQ4lmcA23oqYqC/015Lk/NUWNVl1j8NoB4BI6w=; b=Ng6tOn5QDaNL7IRU++4rLTuxXfgCOfZb6V8KMPhT30JHkrIsx3BINhZmsC76DPUkR7Db3S IvEpT+K5PWBPdtsiEvlBvXWy8Sky8fTsUcYhks4/fqA6kiz3q4f3Dx//YKV+gy/gXp/ijA uB1ac0gX4B9w3rs/bCHU3p6SUNfvoGk= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-wFXQZU7sMZOr6kabaTiIRQ-1; Mon, 23 Mar 2026 08:47:26 -0400 X-MC-Unique: wFXQZU7sMZOr6kabaTiIRQ-1 X-Mimecast-MFC-AGG-ID: wFXQZU7sMZOr6kabaTiIRQ_1774270043 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-358e425c261so4928689a91.3 for ; Mon, 23 Mar 2026 05:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774270043; x=1774874843; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0u4DoGQ4lmcA23oqYqC/015Lk/NUWNVl1j8NoB4BI6w=; b=ECtEj5ZrLYPHGLb6FNYy9GQIJRSsJu5atQ1K12zR7GX7bOnCb+g4jMlBiXd7zydgRN nNzoY3ryQ8bhyU1CB6eEeFGSPCUiHSyMo795XhY0xWZ/E0Svf3PiE79piQRxC3ofmD4y N3fS3N2yWs3lzonczkFCt+xkJWbF7TVtBTsglAwYjIy6MSl49SfFXosXCgV7I3Cd8fUE ah+DJCn1V8rw8tuhbzV0pPW4ArWpOf6+CcdVk/EyLajoc3ZTKzwnqKp83PcMe4VapQDM 1xUEUvvID7LGdm5BGflR7LODM1VWJzuUPZmXahDypSrNKuyKYb7GauMw1XEm8Y1l4SLc 5LBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774270043; x=1774874843; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0u4DoGQ4lmcA23oqYqC/015Lk/NUWNVl1j8NoB4BI6w=; b=bwvJlFZMlH+wD6177wEJvtUpO8qJ1s25Xh8g0/YA3iOFnTl88PMLeRFp8XcGv0CcWM GAHwhR0OOkifroW3vvZThMhtdOD5bIBeiw45porohrWli8p2d5MscoW8t9Uc4FIJtVgX 5fFTrzvb1F+WkJRnrN7l8Zsqp7+gerBaiiSrBqLl9frt949nbjcmR4waCqVW8sq9BSPb anhgIVWKluwklwmbZKuzoRR4WAoIOs1eCVWksWQ+lZCKf27LomKEQS/6yBN6QdE6/F11 klPFihCg0oPZPpvqbypg9QermI34iiVrPE7Zpy9LnIb36Rr3QUlTX0kXClZWAFnc9xM1 ozFw== X-Forwarded-Encrypted: i=1; AJvYcCVm4sxPkLp0BzsEW/fQCdObnlH1hjsQhGDzC0/TYwW0yDeCYesJLqz1W1xqvarFLTrAznZuTWrzQJXqt0A=@vger.kernel.org X-Gm-Message-State: AOJu0YzwH7aQQuvy0jFR83RuPBgYw9IE17keHWShirz0/+o7is95CUOl CbNsCBMqeOJODlj+1hIByv6/40xhAHIm+bS1mWj22UjWXKmqlIYFIepeFz/d2UsUnqG6X6z5zXU 9Huqw3LVVd6GnMf8gthq9QcIvBa86RZdcJcrTmnY5NFHJnJ+gBFh+jbgdJy9LMjreaw== X-Gm-Gg: ATEYQzwmFQJ2sDylAXGhp5foO05DpUpBe0Nhu7PbNqfw1dxYZSfh1v4BEwoRa/DKZCz 3k4MkWAATsssXoNSdnA2YkenSuGK632yUSrIQuNx77GR7Cqdy/O3rS0xIcA1SiOjRtu3tmT1Abx 32jEO7pjwCOJ02HdBBJYrCOtLiCXpTi4p5hr3lRFDoEHzSP+FiTkbt707A+N8THKJDgPpY9MbXv S5qr3LfoS3XNU2wQPZKY9RbmE0tXYIbCosVk71cV1fL9FBHFk4ga2uxIll7wOhp+43jMy3//LEP 5vOFXR6LrRDZAc6IsBiK1YEgHOjOzNZ2puSveaHhPGvMJc8Z5kqTasfuwmKzqv9v8Jbf2eYOPmY vsfbcrO3xIMYd4sZDFA== X-Received: by 2002:a17:90a:1c0f:b0:35b:e4d8:bb10 with SMTP id 98e67ed59e1d1-35be4d8bc7fmr3116813a91.14.1774270043236; Mon, 23 Mar 2026 05:47:23 -0700 (PDT) X-Received: by 2002:a17:90a:1c0f:b0:35b:e4d8:bb10 with SMTP id 98e67ed59e1d1-35be4d8bc7fmr3116793a91.14.1774270042836; Mon, 23 Mar 2026 05:47:22 -0700 (PDT) Received: from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08366b9aesm141494025ad.58.2026.03.23.05.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 05:47:22 -0700 (PDT) Date: Mon, 23 Mar 2026 20:47:20 +0800 From: Li Wang To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Michal =?utf-8?Q?Koutn=C3=BD?= , Shuah Khan , Mike Rapoport , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Sean Christopherson , James Houghton , Sebastian Chlad , Guopeng Zhang , Li Wang Subject: Re: [PATCH v2 2/7] memcg: Scale down MEMCG_CHARGE_BATCH with increase in PAGE_SIZE Message-ID: References: <20260320204241.1613861-1-longman@redhat.com> <20260320204241.1613861-3-longman@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260320204241.1613861-3-longman@redhat.com> On Fri, Mar 20, 2026 at 04:42:36PM -0400, Waiman Long wrote: > For a system with 4k page size, each percpu memcg_stock can hide up > to 256 kbytes of memory with the current MEMCG_CHARGE_BATCH value of > 64. For another system with 64k page size, that becomes 4 Mbytes. This > hidden charges will affect the accurary of the memory.current value. > > This MEMCG_CHARGE_BATCH value also controls how often should the > memcg vmstat values need flushing. As a result, the values reported > in memory.stat cgroup control files are less indicative of the actual > memory consumption of a particular memory cgroup when the page size > increases from 4k. > > This problem can be illustrated by running the test_memcontrol > selftest. Running a 4k page size kernel on a 128-core arm64 system, > the test_memcg_current_peak test which allocates a 50M anonymous memory > passed. With a 64k page size kernel on the same system, however, the > same test failed because the "anon" attribute of memory.stat file might > report a size of 0 depending on the number of CPUs the system has. > > To solve this inaccurate memory stats problem, we need to scale down > the amount of memory that can be hidden by reducing MEMCG_CHARGE_BATCH > when the page size increases. The same user application will likely > consume more memory on systems with larger page size and it is also > less efficient if we scale down MEMCG_CHARGE_BATCH by too much. So I > believe a good compromise is to scale down MEMCG_CHARGE_BATCH by 2 for > 16k page size and by 4 with 64k page size. > > With that change, the test_memcg_current_peak test passed again with > the modified 64k page size kernel. > > Signed-off-by: Waiman Long > --- > include/linux/memcontrol.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 70b685a85bf4..748cfd75d998 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -328,8 +328,14 @@ struct mem_cgroup { > * size of first charge trial. > * TODO: maybe necessary to use big numbers in big irons or dynamic based of the > * workload. > + * > + * There are 3 common base page sizes - 4k, 16k & 64k. In order to limit the > + * amount of memory that can be hidden in each percpu memcg_stock for a given > + * memcg, we scale down MEMCG_CHARGE_BATCH by 2 for 16k and 4 for 64k. > */ > -#define MEMCG_CHARGE_BATCH 64U > +#define MEMCG_CHARGE_BATCH_BASE 64U > +#define MEMCG_CHARGE_BATCH_SHIFT ((PAGE_SHIFT <= 16) ? (PAGE_SHIFT - 12)/2 : 2) > +#define MEMCG_CHARGE_BATCH (MEMCG_CHARGE_BATCH_BASE >> MEMCG_CHARGE_BATCH_SHIFT) > > extern struct mem_cgroup *root_mem_cgroup; Reviewed-by: Li Wang -- Regards, Li Wang