From: Niklas Cassel <cassel@kernel.org>
To: Christian Bruel <christian.bruel@foss.st.com>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Shuah Khan" <shuah@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Koichiro Den" <den@valinux.co.jp>,
fabrice.gasnier@foss.st.com, linux-pci@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] selftests: pci_endpoint: Skip BAR subrange test on -ENOSPC
Date: Mon, 23 Mar 2026 11:22:53 +0100 [thread overview]
Message-ID: <acEUfaPC1BfirjYc@ryzen> (raw)
In-Reply-To: <20260323-skip-bar_subrange-tests-if-enospc-v2-3-2080f878134d@foss.st.com>
On Mon, Mar 23, 2026 at 09:15:25AM +0100, Christian Bruel wrote:
> Handle -ENOSPC error. Skip the test if the number of available inbound
> windows is insufficient to map the subrange.
>
> Signed-off-by: Christian Bruel <christian.bruel@foss.st.com>
> ---
> tools/testing/selftests/pci_endpoint/pci_endpoint_test.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c b/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c
> index c417fb3a198b2d92c3060938c23807cc8bea5573..97212a0b41c930f981687086b588b056cf44ee62 100644
> --- a/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c
> +++ b/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c
> @@ -88,6 +88,8 @@ TEST_F(pci_ep_bar, BAR_SUBRANGE_TEST)
> SKIP(return, "Subrange map is not supported");
> if (ret == -ENOBUFS)
> SKIP(return, "BAR is reserved");
> + if (ret == -ENOSPC)
> + SKIP(return, "Not enough BAR inbound windows");
Nit: I would probably just print:
"Not enough PCI inbound windows"
or
"Not enough inbound windows"
E.g. DWC inbound iATU supports both BAR match mode and address match mode,
so from a pure hardware perspective, I guess the inbound translation just
matches based on the PCI TLP address (with some extra logic for this to
automatically use the correct PCI address when using BAR match mode).
Thus, I slightly prefer to not include 'BAR' in the print.
Regardless:
Reviewed-by: Niklas Cassel <cassel@kernel.org>
prev parent reply other threads:[~2026-03-23 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 8:15 [PATCH v2 0/3] Skip subrange map tests on DWC iATU allocation failure Christian Bruel
2026-03-23 8:15 ` [PATCH v2 1/3] PCI: endpoint: pci-epf-test: Handle -ENOSPC in subrange_setup Christian Bruel
2026-03-23 10:21 ` Niklas Cassel
2026-03-23 8:15 ` [PATCH v2 2/3] misc: pci_endpoint_test: Handle -ENOSPC in subrange mapping test case Christian Bruel
2026-03-23 10:22 ` Niklas Cassel
2026-03-23 8:15 ` [PATCH v2 3/3] selftests: pci_endpoint: Skip BAR subrange test on -ENOSPC Christian Bruel
2026-03-23 10:22 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acEUfaPC1BfirjYc@ryzen \
--to=cassel@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=christian.bruel@foss.st.com \
--cc=den@valinux.co.jp \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox