From: Brian Masney <bmasney@redhat.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Brian Masney <masneyb@onstation.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] soc: qcom: ocmem: register reasons for probe deferrals
Date: Mon, 23 Mar 2026 07:07:40 -0400 [thread overview]
Message-ID: <acEe_CQxxkl9nvOU@redhat.com> (raw)
In-Reply-To: <20260323-ocmem-v1-2-ad9bcae44763@oss.qualcomm.com>
On Mon, Mar 23, 2026 at 03:20:58AM +0200, Dmitry Baryshkov wrote:
> Instead of printing messages to the dmesg, let the message be recorded
> as a reason for the OCMEM client deferral.
>
> Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> drivers/soc/qcom/ocmem.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c
> index dd46bb14b7be..d57baa9cfa03 100644
> --- a/drivers/soc/qcom/ocmem.c
> +++ b/drivers/soc/qcom/ocmem.c
> @@ -196,10 +196,10 @@ struct ocmem *of_get_ocmem(struct device *dev)
> }
>
> pdev = of_find_device_by_node(devnode->parent);
> - if (!pdev) {
> - dev_err(dev, "Cannot find device node %s\n", devnode->name);
> - return ERR_PTR(-EPROBE_DEFER);
> - }
> + if (!pdev)
> + return ERR_PTR(dev_err_probe(dev, -EPROBE_DEFER,
> + "Cannot find device node %s\n",
> + devnode->name));
Reviewed-by: Brian Masney <bmasney@redhat.com>
dev_err_probe() was introduced in 2020 (a787e5400a1c) and this driver
was added to the tree prior to that.
next prev parent reply other threads:[~2026-03-23 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 1:20 [PATCH 0/3] soc: qcom: ocmem: let the driver work again Dmitry Baryshkov
2026-03-23 1:20 ` [PATCH 1/3] soc: qcom: ocmem: make the core clock optional Dmitry Baryshkov
2026-03-23 10:15 ` Konrad Dybcio
2026-03-23 1:20 ` [PATCH 2/3] soc: qcom: ocmem: register reasons for probe deferrals Dmitry Baryshkov
2026-03-23 10:16 ` Konrad Dybcio
2026-03-23 23:02 ` Dmitry Baryshkov
2026-03-23 11:07 ` Brian Masney [this message]
2026-03-23 23:03 ` Dmitry Baryshkov
2026-03-23 1:20 ` [PATCH 3/3] soc: qcom: ocmem: return -EPROBE_DEFER is ocmem is not available Dmitry Baryshkov
2026-03-23 10:17 ` Konrad Dybcio
2026-03-24 3:05 ` [PATCH 0/3] soc: qcom: ocmem: let the driver work again Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acEe_CQxxkl9nvOU@redhat.com \
--to=bmasney@redhat.com \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox