From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 767AF395D86 for ; Mon, 23 Mar 2026 11:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774264751; cv=none; b=UE3XXhmoXGqII/xUDVeWLJvvEAgG6ht93h96Mi/8HfBSxqlKOGhrdD77r/3vlx4fMrmviGzLxYnjsJSu6/WtudK/TXvzULHiVldrsmc+nojEg/ohqcn4YlbYjNpvfv/eXNKGsAvhuFM/MPEMIk3hq9BlwQD6VQdeqqJ4IU2BzEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774264751; c=relaxed/simple; bh=d13SEadj+gsnxXRSJYl3IJsQe1QvKoALzL71zYoPGDg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iwy9M0qgvJ4qGnUCJimrf+H0lGDK033uMvCVjy9GsAWGYQw4SjYJ1LrK2rbiIWg3y+hY4tLxK8wIV7xPyXM7+omkKGhLC8kJ/RoM1xWENfX8EgpXuPwaZq8dwjwXEIYe/7JfhER4mDV3WKuOa+5iTWQc4oZTLdO7l/dBAuY2qu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC47E1684 for ; Mon, 23 Mar 2026 04:19:02 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 92B7C3F885 for ; Mon, 23 Mar 2026 04:19:08 -0700 (PDT) Date: Mon, 23 Mar 2026 11:18:58 +0000 From: Liviu Dudau To: Christian Hewitt Cc: Boris Brezillon , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panthor: correct firmware related messages Message-ID: References: <20260323081132.3217646-1-christianshewitt@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260323081132.3217646-1-christianshewitt@gmail.com> On Mon, Mar 23, 2026 at 08:11:32AM +0000, Christian Hewitt wrote: > Some English language corrections to firmware messages. No > functional changes. > > Signed-off-by: Christian Hewitt Reviewed-by: Liviu Dudau > --- > drivers/gpu/drm/panthor/panthor_fw.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index a64ec8756bed..349bb6b0e7bf 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -580,7 +580,7 @@ static int panthor_fw_load_section_entry(struct panthor_device *ptdev, > > if (hdr.flags & CSF_FW_BINARY_IFACE_ENTRY_PROT) { > drm_warn(&ptdev->base, > - "Firmware protected mode entry not be supported, ignoring"); > + "Firmware protected mode entry is not supported, ignoring"); > return 0; > } > > @@ -749,7 +749,7 @@ static int panthor_fw_load_entry(struct panthor_device *ptdev, > > if ((iter->offset % sizeof(u32)) || > (CSF_FW_BINARY_ENTRY_SIZE(ehdr) % sizeof(u32))) { > - drm_err(&ptdev->base, "Firmware entry isn't 32 bit aligned, offset=0x%x size=0x%x\n", > + drm_err(&ptdev->base, "Firmware entry is not 32-bit aligned, offset=0x%x size=0x%x\n", > (u32)(iter->offset - sizeof(u32)), CSF_FW_BINARY_ENTRY_SIZE(ehdr)); > return -EINVAL; > } > -- > 2.43.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯