From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B9B23B38A0 for ; Mon, 23 Mar 2026 15:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774280829; cv=none; b=boFcvY6BsixpjVp2WQR7H8bvogLXbrmALalra+JBzV3OLu2Nn2dEnXlEQNiaIEYfxZLSiutUr4M9v6s1dqM4MgnGNQ89h9287kftkJbt0ss+szfjaC3VIzDO3MqcjwWlzbaKn9meJewUvplB2XspQwoXOq56iHEkhqcTBlO9qf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774280829; c=relaxed/simple; bh=G8j5VdLcKlfqBzhD5E96qCqDUHkNy5m8xRujbXzWVLE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cwm2RIJqYH5/6ZQOD/2SUoIGkR256GkT9N1BGq0fqfNQTEMzldtVLxxJd9jEaTqQnjOjoIJOAMpADqgzBcFS+pR9FLJg9+iXLAs8HG8t9pqUNQbZWDfHevNbtoHG6OITeI7YPRObxbmk8xOHPdzyHNzPt1pNRUq38G7dh6HVI2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TRXa/kDl; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TRXa/kDl" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so28070035e9.2 for ; Mon, 23 Mar 2026 08:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774280827; x=1774885627; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p1P8EN8xuW2XM/nvn4JwAjz9BQQ7OXUbARn0dbOo/2E=; b=TRXa/kDl0Ozhj8EUMcBmj5LnaAxrmbsXTNG5KYmrhe2+k3T8/q3l532xMPFB9lzMjG +s5stxV+EPn+4AVcaT16txUAVvZofDCfWiYNYbWSpHFW+OBJxdllkFlNF97neVfP6IU0 HyfwSUF+Xwc7VDJ7MZJxOLpf8gh9SQmgbxoLAnO/FlcHWBuwHZ2/m3cxlqX1Pdkbw6Ry VwA89R46zWc65Po0911Y96KwtoKglHUSKTO5M1NxLGB+Yjk+6QNMoVTMOqLdS3X0BGqP ec/N1xgHKMxjDvJdW4mpLmHDBH0PyivzGjQUM8iC8MI5tzNw7XuwaUuWnH7hygZGvqTd HPOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774280827; x=1774885627; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p1P8EN8xuW2XM/nvn4JwAjz9BQQ7OXUbARn0dbOo/2E=; b=Hz9GQ25VIDTwcrYpt7pKcSvf518PmMBfX8B8IApI2YKUKtS7vuIUT/ydgYmVbT+kdZ 3+YefGrtV1JmJCN/od08Jr8vDwcQ9B5eeDEeeGuj5gYWqU9r5iEpjEyLIYLPLYVPb6XR hRgHRHQcqNRXjolulNAe1Ey2oE1Jl/TtfMmhd5L2j6pkC+OlZWt+dA5dNBS8eLPtBmu2 KY2jjgXqo0l3BRAE3J57Xht7xVwJr2bpD+6vsp1M6CUGPZ76J8L6s9r1QuF1xQcC8cX/ tOG38TebEti/JjLw+W60XbSnvMGE4w0e28o5lQMpyKcm3+VbVc63NuU76dDFHC7QtXQh 7F1Q== X-Forwarded-Encrypted: i=1; AJvYcCXMMPL+cg2/IIC6jKFlqykMn4WmBP5Ym5hPUQIi6ms+EPeJ/k4ZiepoOLv6IaDDsIAoSN8epjawHN3YgWU=@vger.kernel.org X-Gm-Message-State: AOJu0YwAhxaHlp6fHTJcckbHf8B1wtFHEXbVIHIdR8F0AKpUP0orFnzP amTJkiDdFvZ+dJMcrZ3aMVAJQ3L+NhoN51Zvz+wbX0RA33Onh/NGXYT27rfF50jNjxQ= X-Gm-Gg: ATEYQzy2iu6dD4d2V2QxCrJ4PiND08TCEXh/uCubM2CflSSsz+3o2O1KKLchrpbG51j NA0UyPm21sXNXqBXFKb7P4p9bpNqR4nMPRUShP31fqrQPOZKS/DYJm/9IL/hWvmfj89E3drwhDX tHpLm0JtcwrWupCKg8smwZTf72eBdBneTvgwCnYv9xMTGtz1M8myRGqsBXOOuh2XjhtmFvkx5mD InOYCG3GG+cAZE5hJSxboLCQSR9WDKO+sCf5Pb1+0ZwrzUYVTxSHEU7PZMebT8cX228T1pPadal t5X+HJQJKV2EXjJo/Ge4RhTDni63qOVjTBDd9rcWTQZc3NrNVfkogV/C1UNXwirpCmAKplu4xrJ /0T9UWbcXCBQI1eiERMzy0DVaxGRUnBYonUwsciNawGhX9gFBsHF6mEIKLcZZ6wpteizzzoXV/h CSV7a+jK5HwucouQZay/kYviCebQ== X-Received: by 2002:a05:600c:c09c:b0:486:fcdf:c065 with SMTP id 5b1f17b1804b1-486ff01caa3mr140759835e9.27.1774280826645; Mon, 23 Mar 2026 08:47:06 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe68ec05sm425261635e9.0.2026.03.23.08.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 08:47:06 -0700 (PDT) Date: Mon, 23 Mar 2026 16:47:04 +0100 From: Petr Mladek To: mrungta@google.com Cc: Jinchao Wang , Yunhui Cui , Stephane Eranian , Ian Rogers , Li Huafei , Feng Tang , Max Kellermann , Jonathan Corbet , Douglas Anderson , Andrew Morton , Florian Delizy , Shuah Khan , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 1/5] watchdog: Return early in watchdog_hardlockup_check() Message-ID: References: <20260312-hardlockup-watchdog-fixes-v2-0-45bd8a0cc7ed@google.com> <20260312-hardlockup-watchdog-fixes-v2-1-45bd8a0cc7ed@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312-hardlockup-watchdog-fixes-v2-1-45bd8a0cc7ed@google.com> On Thu 2026-03-12 16:22:02, Mayank Rungta via B4 Relay wrote: > From: Mayank Rungta > > Invert the `is_hardlockup(cpu)` check in `watchdog_hardlockup_check()` > to return early when a hardlockup is not detected. This flattens the > main logic block, reducing the indentation level and making the code > easier to read and maintain. > > This refactoring serves as a preparation patch for future hardlockup > changes. > > Signed-off-by: Mayank Rungta LGTM: Reviewed-by: Petr Mladek Best Regards, Petr