From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C78F339656C for ; Mon, 23 Mar 2026 16:00:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774281648; cv=none; b=b8EmMk/9hb6nLGsayojaTy0tAsM7VKVtVhxkk/DOCSFfaZ3XrTAmABrcBMjeq17E/hMoIsAoybOx/VOGzqB8fTOW/KgTf7o1F2DWOYM3Wo77snOBCIqpR/lVJPgKrCiDzXmgML3AAqPsiX231WFkOiKkOftxZfwkpR2oWMbi2G4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774281648; c=relaxed/simple; bh=syf9i0nsMSVW1oVkI3FRk7iRMJi7TFeeiD+FOn1oFZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TtBJLTB340u16AO7EgPiyihcTgmNnTc5QKyp2HH5N9/giw38vXhoOslzXUzWqrDQAXdhm4dJ1c9OsgEB/aXcuAwJ4CJTwVVTR376QL1JH6C2lPJTnsmtuHUMAAWhGGob/4hif2W3I4x50e30tNCIU01eCy0B+RRXvXnwhoIQWAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y4F2wrcM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y4F2wrcM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56DD8C4CEF7; Mon, 23 Mar 2026 16:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774281648; bh=syf9i0nsMSVW1oVkI3FRk7iRMJi7TFeeiD+FOn1oFZ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y4F2wrcMkPpxaonMU0A9zpPRb8hVlGytufejG5j7xXXfk4PmxP+OcS4qdZBdWbyhY 0XoI1ALEHwyx4UO/9eKyUhfn68pVAdplzIsyZgbxTodL5qJY/MBC5/umi8bXv8MVv2 FhBGiInle2HjQT01TuVdEGn+g+qwsj08aEkSZewaEk9LwjSVMDd/zfeiYvOMmC2rz9 4qqiKmYJbr0eAM/G8F1vlXgs2o8CEpzz0KCwiLFkbSyOspvZbaKcufcve/HZp4+mTh Njqz1X08Rl7m2xSFYl1K3rNxFE08u+armJnEf1LMMxUh0QLy2ZOdTLMFgrEdw3CH1P pHQsZbnGDHRxQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1w4hhu-00000003dWs-0A12; Mon, 23 Mar 2026 17:00:46 +0100 Date: Mon, 23 Mar 2026 17:00:46 +0100 From: Johan Hovold To: Bartosz Golaszewski Cc: Srinivas Kandagatla , Bartosz Golaszewski , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] nvmem: remove unused field from struct nvmem_device Message-ID: References: <20260223-nvmem-unbind-v2-0-0df33a933dca@oss.qualcomm.com> <20260223-nvmem-unbind-v2-1-0df33a933dca@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223-nvmem-unbind-v2-1-0df33a933dca@oss.qualcomm.com> On Mon, Feb 23, 2026 at 11:57:02AM +0100, Bartosz Golaszewski wrote: > The node list_head in struct nvmem_device is unused. Drop it. I'd expect a comment here saying something about why it's no longer used (and since when). Looking at git blame it seems this was mistakenly added by commit ec9c08a1cb8d ("nvmem: Create a header for internal sharing") which was just supposed to move the struct to a new header. Johan