From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94BB43C660E for ; Mon, 23 Mar 2026 18:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774290318; cv=none; b=oDxN+Mj9oY9fuePIIrPdQFKe1gXJf3RfcY29f4JLaKrAwWfABEeFCWPn3eszG4t0camEntCD0LV4yT1FESSrdf3+YvgxJgKYpr3ux7m3iR5deIeMDG5fNKSNv/XbAAEInGq4lxo8xdTKkIlTWY3RQadVspP4yrxhh6C13ZjRRxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774290318; c=relaxed/simple; bh=n2Px9KvrBSca+8wbbFZSgIYdPNKBUj7GDb8kCwrntFc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EXeJ4ke/id0zNNnZl+UddLpsGLhOgTrEwiA9TnZJziEwUAw7NPwQ9HIVTRaKqleN8FNZAhPxDb2uUGoAPJ7SjXbm/SLlByxulL1jd7YIE7wNnPdY//PfAFl0Hov37eu1QNR90d/smsj4iVnEjO95Emox025fpjj5511zM+uTcw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C6BhqKuv; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C6BhqKuv" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-12776bebe9fso705953c88.1 for ; Mon, 23 Mar 2026 11:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774290311; x=1774895111; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0+l2i6CJ0UesVmQ48tC67wDfEsqc0p6X8zxC51ds3A4=; b=C6BhqKuvTpMhqlgVXLg6kGG0gezlJsDbJftPaxV/tEZBZA6D9EC2wRDTvqtCMVxwz4 /8ZOvMrwAa3W5fYzMgFaX3I6Ptx0VKBRK4Lgpt8ILJokWwtxMfTBzc3/PzPXg70Oj4np jpl5Jmo0t7/5kzqB3fsutAMjgJ1YqE19eixjvR7p/ri4XkpXb+LFuk8M8KLyDG6+2rqI tb8Hveoxujn0S2XUx8RQ18UNQBRNT7oS0go8XLXN5G5pAoMBFsg952vDwr6+W4olLNAq zg9N/rTnW/muM4oDXZA9ksnKerCiBQ8d0Y181a4ort6rAdjU48nIksLnZXq4bqI32XqA 3OJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774290311; x=1774895111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0+l2i6CJ0UesVmQ48tC67wDfEsqc0p6X8zxC51ds3A4=; b=DpW2uu+2a+wqAEPJN2twtyLHqVUXiP7TtX7DIEv+y0/6CXbv/mQwlr1qBDhGppjwev USwOdowCsP8uWHWponOs2MoCHyps1r2fTgqRy9dHR02lpzX8ZKCEwlmdrxq8QSyz9BCr A+XNZOO20yslOTcOJUPtTA8gk2YWfVmVZgc0hNPq09w0owmdOmkLHuMBKcQvs4H3e0dP zGW9C8WEpa3vocg8y8xSICVIDQgOnsZ+zDJTxPhb0PW8BzpQPSCnEBJ4jtXfginhcUzW RV9AnELCLmIa1OYz6LWjoswqbcGOIqoRpd1ueLFuNlEbwLzVULecu0nKc3jditvqh8+0 iG4w== X-Forwarded-Encrypted: i=1; AJvYcCVHn8xH3ikJIWA7tboJFpnIAbm1IvwCOHMt/W568PwsWfcnWD4nqsNlaSC7ylAGEQZYrzueXVv6zE0GXHk=@vger.kernel.org X-Gm-Message-State: AOJu0YyIV0Z+jx3q6JUeebURAhDChMfgz5K8fEHlg7Nb2Bo5STPDhWfS felmDDvmJUPtWloYx+RnAHsBacM0FcEQcr8V++Q75pV+ilmegwC3DvHf X-Gm-Gg: ATEYQzyMsakuk2P23mBD6vjUR/1fEl+kvrgsMPUmLEnIei/nBWszEDu3r+u2DKT3mWD fpyeHJgOsVp/U7ijZV2FfVk7iUJYZv/pzcOL/K+Gu16SMYzToDd2NpBC1yqFRYnF8sdW7uAOJft HHBDRFinpBB8qvG9LaWcv0mw7sB3XZEpfhx/t6vARQ76gZytoYbNCpiod/8HOItyF2kEF93OAWG IZIMLbb5h0kGNtPQVANAX9FhcFVb8/qfSO9tubmMwhG6UX194QUo131sNWIQkRHSCbFhI8YgjNb mL9xNW7vHkZ9VW6dI27qynlzMByAtBpgh4CcoSBlpCu6c/NGqy9f0cAnE5sIbjx1hBGK8lYKIBn hLQtnM6vLbSN7w6C6vXSgpbbpDlzsubUvPOtVOcmFDSYuCZtRbXwMWRMqhnfJfK8mOoDYnZ9NiC ey60k9DeYEGf3AM2IQqI3oIdTPagwgQsciWZJeJWZGUI/2Yf1KUuG4PiswZ4AtdnVkxTsktgync JU= X-Received: by 2002:a05:7023:b14:b0:128:e2a9:d97b with SMTP id a92af1059eb24-12a726dd9b5mr6179340c88.42.1774290310889; Mon, 23 Mar 2026 11:25:10 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a296:1211:5ab0:bc95]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b31bef1sm16253302eec.26.2026.03.23.11.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 11:25:10 -0700 (PDT) Date: Mon, 23 Mar 2026 11:25:06 -0700 From: Dmitry Torokhov To: Mark Brown Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Neil Armstrong , Liam Girdwood , Lee Jones , Pavel Machek , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , Moritz Fischer , Xu Yilun , Tom Rix , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-spi@vger.kernel.org, linux-leds@vger.kernel.org, linux-fpga@vger.kernel.org, driver-core@lists.linux.dev Subject: Re: [PATCH 03/10] spi: switch to using class_find_device_by_fwnode() Message-ID: References: <20260322-remove-device-find-by-of-node-v1-0-b72eb22a1215@gmail.com> <20260322-remove-device-find-by-of-node-v1-3-b72eb22a1215@gmail.com> <098e1856-feee-4f4b-8059-85a53967f6b3@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <098e1856-feee-4f4b-8059-85a53967f6b3@sirena.org.uk> On Mon, Mar 23, 2026 at 05:16:04PM +0000, Mark Brown wrote: > On Sun, Mar 22, 2026 at 06:54:21PM -0700, Dmitry Torokhov wrote: > > In preparation to class_find_device_by_of_node() going away switch to > > using class_find_device_by_fwnode(). > > > struct spi_controller *of_find_spi_controller_by_node(struct device_node *node) > > { > > + struct fwnode_handle *fwnode = of_fwnode_handle(node); > > struct device *dev; > > > > - dev = class_find_device_by_of_node(&spi_controller_class, node); > > + dev = class_find_device_by_fwnode(&spi_controller_class, fwnode); > > if (!dev && IS_ENABLED(CONFIG_SPI_SLAVE)) > > - dev = class_find_device_by_of_node(&spi_target_class, node); > > + dev = class_find_device_by_fwnode(&spi_target_class, fwnode); > > if (!dev) > > return NULL; > > Actually, no - this just looks weird. We're in the middle of an OF > specific function but we're having to jump up to fwnode for no apparent > reason. If we actually decide to get rid of the OF specific function > then I guess but I'm really not convinced this is an improvement in > isolation. Yes, I want to remove OF-specific APIs from the driver core. I also have drafts for bus_find_device_by_fwnode and others. I can make a followup series introducing spi_find_controller_by_fwnode() and removing this OF-specific variant. Thanks. -- Dmitry