From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 019F33C6A5A for ; Mon, 23 Mar 2026 18:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774290516; cv=none; b=ETZBSnozkl4GKWLn0CI/IYpGO3Nm24NrA+crCIIURSjDz/Hx6v5czBSKhMUMJGOoIZZPWWmDM7jaKdOgk3KLa0G6hnPCRYNJjWJ0FUEVutm3TjLItk/IAwjSZMxEuaqeJ/idQk/Ew4/f9bzLMsWUtjxQCpTstKLACFGHNZLPtto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774290516; c=relaxed/simple; bh=t8uGoOmn69GTvslBxUEc5eTMB7ZiO+nrKn47M9Cp8FA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ocyk9mKs/6UquMxr4hj8KKwiFeFIHjxqrasOPwQ9i6HDZ7jCRrH+jGQt1cyL+fc8pi2f5aJwEav0Ip3v3V3UB1OaW0uPsVsYeHhXRWZg/Um9TKozXKr6ee5t1FcL/d4Fv76Bz0icd6bUDjEC3odZKkmTlkZth8jmURPf2/3T5jA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nU4LxGOf; arc=none smtp.client-ip=74.125.82.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nU4LxGOf" Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-128ebee22caso3516207c88.0 for ; Mon, 23 Mar 2026 11:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774290512; x=1774895312; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zDXVXDlTyWriMoHabs2g4jaDjhygWMksayJaNvHtSE8=; b=nU4LxGOfPs3QZ3q1BOHY3xW1BsasEVECfsn054gvduGccyJOdGSSriZyQel7ZZuODl ND8rPtQjMEovixdtNdNPwz4OydDcycp5pWW/3m1fgC5jMQKNUFPH7NGtKsQK1IfKfrh9 Rqidd+o/bKJ8/7fAi7cuedl4la/kRsdBnWlhvXPhFzz0J2hgto+9uB1E+I8bK+rQylJi lSKxKrIbr7b/Jb/WJJy2Mj5pzoj2OD079F/dp9rrMqkSgsYnMnG4IjOOa44gvtMGJhqv B9oDuQ493ayNmc/UX1pJrrIqdmYW1NQWAO9Q0QIVybo3KKDYoESuZZMQdAQSGs8k+uO7 teDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774290512; x=1774895312; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zDXVXDlTyWriMoHabs2g4jaDjhygWMksayJaNvHtSE8=; b=qlpjSIvXDhpxfuxJwE32H/xn5FLKYSr5s2T6/d4veOEgl7dCAvrOkp6O+ShMBzBSJM gCWMjhih4XkOWPuhfwA9Ba/5k0UZm8PW8UhbLnnuSZV4+XuMKy3Ctf/zcY0FMTkap9IO JXJqU87VCYRWtHxpRdM0SwOrgRrpjUD7UJeliMQRRnuY6dNpR0QWc7fvyD0wmTFlgRT8 XFpLbxE63l1JMgpn+IpYjPompqLE55gKc3n73/MsMRg6WAexb/0F+IZUuWdfQe4xJCNl wECNOijX12OXQLez9XmWbba6ZzKxHDpBcIxlU5H6ueSCMCUqjRBRN4maetX5o2PpCvNP 8VHQ== X-Forwarded-Encrypted: i=1; AJvYcCXxox+E5hX553Fo8K85k69Va9TbtDS0ixZZtfLGM91JAY6rvRBiY+Fbjs+afb0KQV/1uKFbXvT1UdmNoyY=@vger.kernel.org X-Gm-Message-State: AOJu0YyAq+7bQdbuh/dirz9FbRt6jC3lTvRXDWe+4C/AoGDL5R37eIdr 7VKTKvHBCNUbycR21NXZzmYaNO3R+WQljvOMfnBZAgPGzrPn9v7i/1kb X-Gm-Gg: ATEYQzwHRGlr2zW4RzLKBC81KczbJs2BkU0MlKtceCM/RWc1k7lUi3VEiW7S1XV2uuJ sDVGWgwc1vAzI6oAdQceepxas/039mDjLL4O9abFzYcWLs0g9BEGmTfSukp7lrbS2yePCsTl8b+ 0r56aUMnLIFh5xLC1Zumbcbuca9284xCENe0DypTGNdilOlFIqeeCcC22rBT+pnYNBdYTPIHBg3 kFxGCeNldhtVpdiI1+7xUsoGpK270NsqeIvz1VNVYW4o1RQ9WxSKH9y227oCjJKYzrISy/JGiml DvC+qYFsp6VxsYAxzmHlNopWZStS02m/908X60qSZH1GpGeD+sSvqISUnE0F+51dwB1SZpakTT3 iluIme8chJvHnUJ/Fg8O8Q1T7YAIkNb/NHXKczP05a7QgiFweN1tuk7AHdTO3NcIuN6dprWUD4m CVyndzT2g7Av3Eh4RxfqdXxH3obaInDU/qVxyE13ElQT2CEpifVnatf0tFu7C79ymS X-Received: by 2002:a05:693c:2b06:b0:2c0:ad52:e657 with SMTP id 5a478bee46e88-2c109712cedmr6434030eec.21.1774290511733; Mon, 23 Mar 2026 11:28:31 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a296:1211:5ab0:bc95]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b17b8f2sm17872306eec.9.2026.03.23.11.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 11:28:31 -0700 (PDT) Date: Mon, 23 Mar 2026 11:28:27 -0700 From: Dmitry Torokhov To: Mark Brown Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Neil Armstrong , Liam Girdwood , Lee Jones , Pavel Machek , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , Moritz Fischer , Xu Yilun , Tom Rix , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-spi@vger.kernel.org, linux-leds@vger.kernel.org, linux-fpga@vger.kernel.org, driver-core@lists.linux.dev Subject: Re: [PATCH 04/10] regulator: of: switch to using class_find_device_by_fwnode() Message-ID: References: <20260322-remove-device-find-by-of-node-v1-0-b72eb22a1215@gmail.com> <20260322-remove-device-find-by-of-node-v1-4-b72eb22a1215@gmail.com> <360a8b4a-6507-417a-9fc1-c53b14868657@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <360a8b4a-6507-417a-9fc1-c53b14868657@sirena.org.uk> On Mon, Mar 23, 2026 at 02:00:43PM +0000, Mark Brown wrote: > On Sun, Mar 22, 2026 at 06:54:22PM -0700, Dmitry Torokhov wrote: > > In preparation to class_find_device_by_of_node() going away switch to > > using class_find_device_by_fwnode(). > > > struct device *dev; > > > > - dev = class_find_device_by_of_node(®ulator_class, np); > > + dev = class_find_device_by_fwnode(®ulator_class, of_fwnode_handle(np)); > > The regulator API is very deliberately specifically using the OF APIs, > not the ACPI APIs, since ACPI really doesn't want to model regulators. For now? We also have software nodes and maybe we come up with something else in the future... I think we should use firmware-agnostic APIs as much as possible, and only use OF- or ACPI-specific ones when there is no generic equivalent. This makes the code most flexible. Anyway, I am not proposing to change all of the regulator code, just clean up driver core APIs. Thanks. -- Dmitry