From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E75F3CC9EE for ; Mon, 23 Mar 2026 19:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774294925; cv=none; b=WDhRrVgyaccsc4/CPc/yl08o+Y2YvdB6HoF3vCU6jOqj1rvjne7wR4W44ZihTqbwWD95Oq01rlijtEzppKgQNpif5lsCIum4l82W0bfN1N7MVzmHHSvfhOPZc2mLc3zfxOlU1eBq0NyPGFJweA8ze7nkFFYJuQ+Y5wQ9iG0fkaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774294925; c=relaxed/simple; bh=2SF6pvs2emzV/AhRbggyg1HdfzHcesbv4DvPDEr78n0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SqVCZ3c156QBOSEonxgRQ/RgNK31aD5lIgQiMVlo6FNqxOUCfDRLqKrahjFZDM7tEo/+0I6AenR1XuLxC7DPNcQyQtzepDQSc4o7Wbof8v/udJYMJ1CnaF9lOkbwWHr2TGuttVFVx0mekSe3JdIWBUIYVz1RXrlPspZ7xdroG9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mpuq/cLd; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mpuq/cLd" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-1273349c56bso4329962c88.0 for ; Mon, 23 Mar 2026 12:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774294924; x=1774899724; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YdMs/q66h1+QBJjH+XkkqQHaHRaGP3OKtdQi49odTsU=; b=mpuq/cLda6pGx/tUb9lDgqEk1TmEAKbObTl2RQBeIQ7TfcopAZW6vT0jewqombymsa ffggOe2XuFf6d+ef7o4qVGt+fx4IpCgBt2qkMgJOQCi+uczeYEF6rIesjdsKrEL3M5VN CcYRglXwvZNqQZHopCW8GXfwLre3jBZ2qBrCP9NxR6MVZ0e4KhdAyK5d8fGJ+PYRrg10 D9RJFirOLY1Wh595juUGg0DnPynppjDk3nEcSuWQ+SN++zEEZoNuzRhxsDEAn9cMWXlJ k5oSqN6udr9CgxHTJycW3gT0+cJeHTNiRaTAEiYb/tLjm2z6ObcvoWtWz1zkHGgHDNEl zSxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774294924; x=1774899724; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YdMs/q66h1+QBJjH+XkkqQHaHRaGP3OKtdQi49odTsU=; b=XYMS57UX4tQzLeDdHnhySizOWrC1Nqs+hpKvWNSbn/byE/SbqzrW0cVedhH+ptyIdq rBTH7qf7nXtZVkZvDdV5GG1/OPvXhmFkixi6KKMsvWMQIiSIPueBE+/rCjDNLRBk1BbI EAXLkP0LGARK1qbAl3mGki6XVf5JpmHI7GIxNMZSzTPNH6zUiSax8p8jK9nS8nnb8zVL m5nKaGepVvaT3hG6zxHhl+reZT7H/Xmu4/bsEYk6zchfT/KsWQabUejeyceB+EeKJyXB cz968264daDJacXdIXFhgDKufW1nKbUT6Ftvf2LqkAodihdx940oWnZOnZeAwO/7rP6m gmKg== X-Forwarded-Encrypted: i=1; AJvYcCV09orFTfeaSnnoik4z3uQ/iV51Aj+nPWyEC51FN8W4VisjCO/5L766HbSebf+BHlfpd3s+oMjU9LSkFFU=@vger.kernel.org X-Gm-Message-State: AOJu0YyFPeBcmhxvTGcJo0ERw7RPzO2lUzidXMPJlO9QgGYoPqhTgFnI YgWbpZPiSycuE52raWzVWQWsPWTavU+civzdG6fNXV8TvzNwitckjfSJ X-Gm-Gg: ATEYQzzoWqZRzY1p9lmNtFVVyG/wOLm/0R7yK0/jWYHif+1d0RDoD/NoiVeBCcEqq1P Eal42wF9c6ABrvbf2Spw24+4EmqOnaH8c6vHrqo1baQpcrkPQ1CKubd/SaL0kJ+qz8Mr8NC1/xO GSCE9aWuMcsS4u8DAiPo1G0PkrN11ugiftUKGJ0ic8JPW8cUarwYoeuy+/uX/UHNwQix0WdBzZf nocJInU/uorvetKmP02z4HMhy9yFw2QIadD8IayM+HGMWjGW9bymEoNYQtG7B96wmZBd6hx51hq w0h44J9DiUTDkKjhNmOMCkHWaVFBEhBz6ghyX7TVcJn8nmCyKlf3t1srU+qxN+GJcB6r3+69hLc A/B4GgT8lV5cpE4/H6izKYFFAmI5KjWCdDrKNHURwZYwQYLABAXUb4fE8V06y6WOIHc7WjezMwF neCIO8HjiAIVvnxecbG0WAPangZ5g9r0kZ3b1rSwT7FFfryx9y4JQqLtiunXUsNJyA X-Received: by 2002:a05:7022:6713:b0:128:d1c9:3633 with SMTP id a92af1059eb24-12a7265f60dmr5533874c88.13.1774294923678; Mon, 23 Mar 2026 12:42:03 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a296:1211:5ab0:bc95]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b17b8f2sm18088976eec.9.2026.03.23.12.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:42:03 -0700 (PDT) Date: Mon, 23 Mar 2026 12:41:59 -0700 From: Dmitry Torokhov To: Mark Brown Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Neil Armstrong , Liam Girdwood , Lee Jones , Pavel Machek , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , Moritz Fischer , Xu Yilun , Tom Rix , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-spi@vger.kernel.org, linux-leds@vger.kernel.org, linux-fpga@vger.kernel.org, driver-core@lists.linux.dev Subject: Re: [PATCH 04/10] regulator: of: switch to using class_find_device_by_fwnode() Message-ID: References: <20260322-remove-device-find-by-of-node-v1-0-b72eb22a1215@gmail.com> <20260322-remove-device-find-by-of-node-v1-4-b72eb22a1215@gmail.com> <360a8b4a-6507-417a-9fc1-c53b14868657@sirena.org.uk> <7d46803e-b285-4e9c-8856-10100fa0ea85@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d46803e-b285-4e9c-8856-10100fa0ea85@sirena.org.uk> On Mon, Mar 23, 2026 at 07:05:13PM +0000, Mark Brown wrote: > On Mon, Mar 23, 2026 at 11:28:27AM -0700, Dmitry Torokhov wrote: > > On Mon, Mar 23, 2026 at 02:00:43PM +0000, Mark Brown wrote: > > > > The regulator API is very deliberately specifically using the OF APIs, > > > not the ACPI APIs, since ACPI really doesn't want to model regulators. > > > For now? We also have software nodes and maybe we come up with something > > else in the future... > > > I think we should use firmware-agnostic APIs as much as possible, and > > only use OF- or ACPI-specific ones when there is no generic equivalent. > > This makes the code most flexible. > > I think this is a worrying idea for core code like this, we have > specific firmware bindings for specific firmware interfaces with the > different interfaces having very different ideas of how things should be > modelled. The chances that firmware agnostic code is going to do the > right thing seem low, and encouraging the use of generic APIs that might > happen to run OK raises the risk that we'll get firmware vendors relying > on them and leaving us with a conceptual mishmash to sort through. > > Software nodes are already a bit of a concern here TBH. Firmware vendors can introduce incompatible DT bindings and have them in their devices too and we have to deal with that... I think if this pushes closer ACPI and OF schemas for at least some subsystems closer to each other it would not be a bad thing. Thanks. -- Dmitry