From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577823E0248 for ; Mon, 23 Mar 2026 20:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774298657; cv=none; b=uxrVStU/jwRmA1xGGG9UhadjGDvwkP7rUoSE+2X8V+VoBsWYk/pX6QQYteQ6Sp3cJAjPd/A3rVJT6yo5d+VVfe1t6rKXxdjm6pmwMrWIr+U70Kx0TPV0gk7nskqtkuZpgEA+SvK3fxduPnTXj2c3clEwAeodZ+VKnYE5Qxm4A5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774298657; c=relaxed/simple; bh=z0O2JeKzmzL5hHXagEh4QyuQ9OwWi3ZJLz/wLqZWrDo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qj/L4jpIblGjymxU66WZTApjPeF8ouQiKfKOI8X4/vm3yWSito43rA7oed5XsL4DacYUgO78UkXDOAhRyxlTy3vcVpYVOt2aVGwoyAykoO1BY/nsCpFA5vJA4ZX+zBV4drAIHMI49RgExnWp7Fq7K9+JOuua8M320A+odPNJ6W0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aV7Ke7T+; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aV7Ke7T+" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2aeab6ff148so7605ad.1 for ; Mon, 23 Mar 2026 13:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774298656; x=1774903456; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+4noW3+Hqv98gL/95V6fTB2a+kJKQFh5AF7H7JodbRI=; b=aV7Ke7T+59RffA0piwG7JYQuKoes/Jnvce0J8XveUthBMKlvaBC05MrzHSivEjVsFw PB8+qYiRLY8bNEebFfM0n9+yAvvDWHT/5ZvGijKiQNbtNA8wPYb80K+ozgQsFO+036oq 4qBRckVVY4FANitw/fy0zrcv7ny8qoZG2fQfE6TRXYQIU2M28dfblHW52Na7Q8S6+dMg CD66+KmiScvfLidA3YU9B8YUdDvCHzJVaBlBcpKVfvgG+G0z7v6MyOqfYdVn1U33RaGp SP5yiTPxJf+WeM2C4h+CAJOAyS9DpMA1bPpu/LAtwsfQ+inaQbaJz78qvd4Wt+pzNHk0 cGpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774298656; x=1774903456; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+4noW3+Hqv98gL/95V6fTB2a+kJKQFh5AF7H7JodbRI=; b=cJ7NFjbW89vtDOcL2b9j/LqYyuccvmz7/QYv/r8H6GfhPqD1FcTx1KyDF0nIiKBO3G EmGF6qUdPYobTNbn0dshAuAJ6Kq3VpFmSRApR7dj2c2nquNbOHGn3bNLPsaURfNSjqV5 hYgpoNZX7SJ/S27MKSeDDrPpCDXngyGd0NZdnlcAfHgLhjr64030dHjuokpVdBuJafse nI3pz21qQ0kRjCnxPmYyjos6s6b4uEd+uLN1y5qqLvDtC53EQ/92/LvFExgJ3ieaGkQC fIiKeV7DbCwTWtEZ08R5Pk08Pu8oNYEDRFyzLl+Ac9LT3AH8Zm6zzvOUKDAe/9TtUNCm hdHw== X-Forwarded-Encrypted: i=1; AJvYcCWq/b4QlX/Pxaf9VtedkOtV+57qkgpGtoxNIdU+sBfgzsaIDNY9qbuwYqUbQ+MO0dXQwgPLA/lhfk6SgkE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0z1iSH4OALlnyHPRl9yBnd0Dj4YIJEqFP4834Tgt6HCf+MutX EPvO1WNmlMBlUUcvSyYfnFKnmeeUHT6kcULZmJQlyKi274+xs08BWEIcNcMPwviA5A== X-Gm-Gg: ATEYQzxfWMQ8y0DeaFfp4rfkLm4ins/SuTMKrFg0Q/Ng7yt22uS19+s6GlCSMi/72w9 HmOVG25n+OWIVEj4ube1zbFDwzEpB8J0ir9cB6+Y9YlsyF2Wy5ZnUlAF2XP52uqd6qTHlbAj5/p 4AXnxFBeq6VZO1dkwSOnkqWlT0BfM80okgMyKaFS9e09YnkZvJKOEkCLJpVDlHlUBSgJolDCfaz Hhj6okj/lou8qmm9Uf5/GK9VDFMNqy+bAnBZPDJ75TKLxkTn3Z6vc3M5feM5BFao0H7jHg+twls +9qbv2VBTTJ+YDQsBD8IYgRv0N7U43HuFADIwl1aAa1USKCGGQ5yI6CsszA4bID4vyzixUJNIS7 CRNzd7k8S7UbtGhSgNGmVfBFIjHQWsKNe0IdmxfgzkdnGHRQqfH/NbRXnDc9pyO8dft2kSj4GKP 0Qe4I0M9khS7zSHeX9FLI1dVHwS4rr1Zjbz6zGra0b24z8hiTFmrwk+A44VT8J4Q== X-Received: by 2002:a17:903:2290:b0:2a9:5ef5:399b with SMTP id d9443c01a7336-2b0a67336damr205655ad.19.1774298655161; Mon, 23 Mar 2026 13:44:15 -0700 (PDT) Received: from google.com (168.136.83.34.bc.googleusercontent.com. [34.83.136.168]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b03aa79a8sm12398938b3a.2.2026.03.23.13.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 13:44:14 -0700 (PDT) Date: Mon, 23 Mar 2026 20:44:10 +0000 From: Samiullah Khawaja To: Pasha Tatashin Cc: linux-kselftest@vger.kernel.org, rppt@kernel.org, shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dmatlack@google.com, pratyush@kernel.org Subject: Re: [PATCH v2 2/2] selftests: liveupdate: add test for double preservation Message-ID: References: <20260323203145.148057-1-pasha.tatashin@soleen.com> <20260323203145.148057-3-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260323203145.148057-3-pasha.tatashin@soleen.com> On Mon, Mar 23, 2026 at 08:31:45PM +0000, Pasha Tatashin wrote: >Verify that a file can only be preserved once across all active >sessions. Attempting to preserve it a second time, whether in the same >or a different session, should fail with EBUSY. > >Signed-off-by: Pasha Tatashin >--- > .../testing/selftests/liveupdate/liveupdate.c | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > >diff --git a/tools/testing/selftests/liveupdate/liveupdate.c b/tools/testing/selftests/liveupdate/liveupdate.c >index c2878e3d5ef9..37c808fbe1e9 100644 >--- a/tools/testing/selftests/liveupdate/liveupdate.c >+++ b/tools/testing/selftests/liveupdate/liveupdate.c >@@ -345,4 +345,45 @@ TEST_F(liveupdate_device, preserve_unsupported_fd) > ASSERT_EQ(close(session_fd), 0); > } > >+/* >+ * Test Case: Prevent Double Preservation >+ * >+ * Verifies that a file (memfd) can only be preserved once across all active >+ * sessions. Attempting to preserve it a second time, whether in the same or >+ * a different session, should fail with EBUSY. >+ */ >+TEST_F(liveupdate_device, prevent_double_preservation) >+{ >+ int session_fd1, session_fd2, mem_fd; >+ int ret; >+ >+ self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); >+ if (self->fd1 < 0 && errno == ENOENT) >+ SKIP(return, "%s does not exist", LIVEUPDATE_DEV); >+ ASSERT_GE(self->fd1, 0); >+ >+ session_fd1 = create_session(self->fd1, "double-preserve-session-1"); >+ ASSERT_GE(session_fd1, 0); >+ session_fd2 = create_session(self->fd1, "double-preserve-session-2"); >+ ASSERT_GE(session_fd2, 0); >+ >+ mem_fd = memfd_create("test-memfd", 0); >+ ASSERT_GE(mem_fd, 0); >+ >+ /* First preservation should succeed */ >+ ASSERT_EQ(preserve_fd(session_fd1, mem_fd, 0x1111), 0); >+ >+ /* Second preservation in a different session should fail with EBUSY */ >+ ret = preserve_fd(session_fd2, mem_fd, 0x2222); >+ EXPECT_EQ(ret, -EBUSY); >+ >+ /* Second preservation in the same session (different token) should fail with EBUSY */ >+ ret = preserve_fd(session_fd1, mem_fd, 0x3333); >+ EXPECT_EQ(ret, -EBUSY); >+ >+ ASSERT_EQ(close(mem_fd), 0); >+ ASSERT_EQ(close(session_fd1), 0); >+ ASSERT_EQ(close(session_fd2), 0); >+} >+ > TEST_HARNESS_MAIN >-- >2.43.0 > Reviewed-by: Samiullah Khawaja