From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5D030C60D for ; Mon, 23 Mar 2026 21:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774301982; cv=none; b=CIlaVLgu14OEFyjRSnsA55pjus64oKd2G6tm9B4RchSAzrAf4245SMnNSw/4nL9Fc4UAbmXfufOXUsYjj6gBetmaixl/zF9QdVCE39NXzDuRaKafBUCL1/2PppPdOP4PrqV2vJsONC7HMKAVEaWWMgjVtXrl7fyORgI4tf6ylCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774301982; c=relaxed/simple; bh=4+vcXD+1P3FXjL2Owm4YaNBB0CpFOHixgkjfmiDa1M4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PE6qatlIJabd2QA8ubE/hCG+u0A3enctRNTAgQOqbSxae33Upyf7+yaFxzYYRrdq7cGW/+ZLU41Q120wEBUtmvw/LpZ37CoC6Q654Jbq0kbqiVJdSYiVhJhglXKUUXVXqzRPmjtx9eYWKGLJ33cjmdXzupYzfgl5Kjhviqvbf2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AeNeGaUF; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AeNeGaUF" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-12732165d1eso1020156c88.1 for ; Mon, 23 Mar 2026 14:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774301979; x=1774906779; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yGHdDoGsiDtOdNrXq7SHzA/I1zh7boK5LF3ZF/OlV0U=; b=AeNeGaUFszrAZvUITkXt+7jwmEyvbJP7L5B0IEN/cIaMLG/q2bDeugKMm94lpxWzJU 76V4lZmGn/sGj3IzxII/0CasDRfOtuEAhcRUrbWjtT3GoriS2yeejerlXaViFZmvDipR 5KLUp5XGEvBEpdiNjU7v59yq9EPgYnByC5/FnpkmSNU3vnuk3iC1g26p/W+U1gLrmsh7 hOlTuPsHhb4kW12/ibKRjgusWntF01dxbjmDE6RDAsB2z8K/rlHJdj4wvpM0K+BQtn5W VB9PMmm2b5K8dVBM78T/Lo9er9li/jc37aPPElbxi3KAGtX0dJTDyyM8cKjOoLC3SX9G I7Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774301979; x=1774906779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yGHdDoGsiDtOdNrXq7SHzA/I1zh7boK5LF3ZF/OlV0U=; b=pE4t3V8ulCqtCretc8ux9qipKwuriAYUP6COiL7pKEJ1r22oTPF1YtDBKvQZxkHOv9 ByjuPI38m9m56+SNVH8vEAZl3lrm6UPtRjQaMkQxCVS9Ml9w9JxEUv8FqFnTzTb+7IPn wmyzBDpSjbojqzYhOxrfoOqPwY7zDPLV6dSmtVb4Pg4W/7YyLB0DPtb4MoeID87c3ARo ADsgz1R6fA6WYUNTQvPRtXlVSnZsTF0+FsTHhurA+4LYv9MOguYsgG8mkr/IPd/MNxvi FbEnZfUR7/0/ryklfH9npAghZPcFfiUnYKPe6GHsWIoR3CnkolwH7ykFYUhHdeMWqabP uB4A== X-Forwarded-Encrypted: i=1; AJvYcCVo2lA1KG4nilP8VFZKtS/6Gju469bozFCXoW4CdWHqugLL/twbJaZQDOl+jjUeznJ4S9agIRNB/K0q3mE=@vger.kernel.org X-Gm-Message-State: AOJu0YxpHH0N/wldgSdrGTf64KYQ0C+9LBckgYHM1hIQav0C9wYYW9+S cmdFnpAMtYguaqcEKeeyWs/RoGGSi3sVIzjzsVwbnoKUr38AHzBDDrwX X-Gm-Gg: ATEYQzyWMogTaCJpxZ35M7BC/eN4lnAOBLLKA0JRjLon4g3Sus2UwIeuoUjgrD5fWIw oxXeraPM4+H3kzhGjum+Z+LpMPtmsh9S9c/dCvlbLWtksHGfw9EEnrFurAR3sP7oKhWyD5EVbda ZLHpTfLsnZ+Hdh/w8JKlTZpuzWWPfxqYELTIuClDakfvu9fa7QraEefnRGoV6Ef0XJcu4G78Pj2 uJNZDUiIPNXp0kouAR1wOlVyTBphd1fgRSQMsEaBnnblHDLluDf2ngRl7B9dAII8/vZ533IEom/ J/u3vCYEONNL9FypMdOvAnQE0fCjUJ1sLja6ZQLMUxX6mF+4t9xhYrs3nQmVRYldl8Y6Jze4EGC Qs3vqiF1zaXh1ysieWXVW11/XTdD/e62nEolnadsIrftQAea/9U7exAnRZ1vh17PoJHDLYB4g+u Tc1D6eI9zTb0NcVVoEEFtZXWJfcobS2LNvCL9TUB2H9Z0/CvCPY7jatt8+l8VJRlWr X-Received: by 2002:a05:7300:dc94:b0:2ba:6819:2e9b with SMTP id 5a478bee46e88-2c1095a5302mr6126697eec.3.1774301979400; Mon, 23 Mar 2026 14:39:39 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a296:1211:5ab0:bc95]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b2d01f7sm13145631eec.23.2026.03.23.14.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 14:39:38 -0700 (PDT) Date: Mon, 23 Mar 2026 14:39:35 -0700 From: Dmitry Torokhov To: Mark Brown Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Neil Armstrong , Liam Girdwood , Lee Jones , Pavel Machek , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , Moritz Fischer , Xu Yilun , Tom Rix , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-spi@vger.kernel.org, linux-leds@vger.kernel.org, linux-fpga@vger.kernel.org, driver-core@lists.linux.dev Subject: Re: [PATCH 04/10] regulator: of: switch to using class_find_device_by_fwnode() Message-ID: References: <20260322-remove-device-find-by-of-node-v1-0-b72eb22a1215@gmail.com> <20260322-remove-device-find-by-of-node-v1-4-b72eb22a1215@gmail.com> <360a8b4a-6507-417a-9fc1-c53b14868657@sirena.org.uk> <7d46803e-b285-4e9c-8856-10100fa0ea85@sirena.org.uk> <55abcc68-747a-468a-abdf-b6340d658c4f@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55abcc68-747a-468a-abdf-b6340d658c4f@sirena.org.uk> On Mon, Mar 23, 2026 at 07:58:14PM +0000, Mark Brown wrote: > On Mon, Mar 23, 2026 at 12:41:59PM -0700, Dmitry Torokhov wrote: > > On Mon, Mar 23, 2026 at 07:05:13PM +0000, Mark Brown wrote: > > > > I think this is a worrying idea for core code like this, we have > > > specific firmware bindings for specific firmware interfaces with the > > > different interfaces having very different ideas of how things should be > > > modelled. The chances that firmware agnostic code is going to do the > > > right thing seem low, and encouraging the use of generic APIs that might > > > happen to run OK raises the risk that we'll get firmware vendors relying > > > on them and leaving us with a conceptual mishmash to sort through. > > > Firmware vendors can introduce incompatible DT bindings and have them in > > their devices too and we have to deal with that... > > The case that's worrying me is mixing the ACPI and DT design models in > one system, and especially having that happen to actually work without > modification purely by luck rather than by design. > > > I think if this pushes closer ACPI and OF schemas for at least some > > subsystems closer to each other it would not be a bad thing. > > I think we shouldn't be encouraging people to just throw random stuff at > the wall and see if it happens to run OK with whatever OS they tried > booting. The differences between ACPI and DT in areas like the > regulator bindings are fundamental conceptual ones. There's some areas > where things are closer and it winds up being fine actually, especially > for leaf devices, but there's others where that's less likely. Maybe we should just have explicit checks with nice comments at the beginning of the schema parsing stating that this schema is intentionally restricted to OF (or ACPI) in cases where we ave distinct schemas? This way it is explicit that it is a thought out decision and not simply a legacy artefact. I think we want to hanel software nodes because they do not form their own schemas, they follow the existing ones (DT usually). -- Dmitry