From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19FFC1FC0FC for ; Tue, 24 Mar 2026 00:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774313011; cv=none; b=UpH5ysQdKnyPl19uw3McWSK2pB/uoldXguhYebyqeDxN5NVilQoGGwX06M78RZU5mAHRo4XgsQe7Xf/CyX4IXrkyGmrzGVZcpUO+iqUvuJcHf/DWp2jEQDaO+182YnGyCEVyG7Sx4uW7YLNs9fD9h2aY6OufvWELCpPQUdyoX6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774313011; c=relaxed/simple; bh=Ste15H68ky2srs+pxlgivQ7lOAwgK8ZcuTuVNMeNonM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HNhEc2y9CkdwnqsWlx03FcJLytHV2VnPXW5PsjbGMSht72QYor5O2o3oW8cXE78E90XXqmZAhhdppmabxIXgSXmK1+c5mBSApP8FHdf+59Q+N8kdzXlwGfDEVV4vpolBt2PMwy389QrQzDuVwA9BRZTF11bauNpvTnUluPvhsHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OX6spqsc; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OX6spqsc" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2b052562254so44405ad.0 for ; Mon, 23 Mar 2026 17:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774313009; x=1774917809; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tP4PkIA/dAss1SYdem97AuKhuaCH6Uwc8eZQpSWtLFc=; b=OX6spqsc8zEzdZTScN6XzmhqW18eIY4YaB5188BdmSFmnztPwCfDm2cQg6O4FIvb6i CRcsijlJdCNK8dHL1uZJOzViHUyJHUFuXe9DgQFtQCAGYZhzVYYfHzCTtMki18vCjgta vgF6kpLClXsrguNCn4OmqCqWg/z4m5zee8GuoXV0CRUtA+Og/pidUJV+Ydf4jBUS+YjJ kmR6hpQidpb2gzOs8NkyJsZUPXTCsGTDdRIG42JkAO3zERdde9riyqaYop5m4goo0rSH qe4+vrAvV4p3IU6x2kriLDeVJxrtHg0BzamVwBVCdiB+J0qFCeQTylIcTymQCLRi/cLa opYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774313009; x=1774917809; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tP4PkIA/dAss1SYdem97AuKhuaCH6Uwc8eZQpSWtLFc=; b=lySKwrdORkD6jMoJbw1fmmnTUJI7oI9+KqNpyMbustJQiG2VNj3o9KWkCo+rud+H5I MewLQwEM7bjSeXXXJQDgWX4jnOKgWOme5Piepyn6boBlEsnFa6NJi6/V0QMoh/eOQtGL e3End3aumN00VHg+JIAl3frSixm9pvkkDLVrkTu7RSO9zUk2nm68g4kaQEfXSNprVgMH jeK7tQgMC7kIuUvnOXhqbkkXswpirkzwUreMGNxQFnvy7K7pUy1h79rKrWY4YBvSknMn Xo2XXddIbzdZK4ZHwRnsph2i7djd4JXJPucMunv9Oqq4gKLT7cBHEa1oCHNIWkTsAswK a4mQ== X-Forwarded-Encrypted: i=1; AJvYcCVnV5ICL3C8XT3svq3jOtrGVH7WEkrvbx2CqT7I6SKnuGf2bIKU8+t7mJh6cV7T7VyBWGdbYBr4cg2lapE=@vger.kernel.org X-Gm-Message-State: AOJu0YzwI3Mye+FKaY4Emetz1VOcPOQeS90DerlGnVAdGmrvy1k1DjsF Tnnof5/by73eArU0GEF5j9ogNf95FdVj8T0HRcUa12QSG/2vzLNFlXRfx8b3C5K6iA== X-Gm-Gg: ATEYQzz1i4njGBfN04PD5QKjBd/XDHjjDZhACTp1L9ltoBT4f3B/uK6PE1r1DCxJg5y wCeJAmftz3SRFKKZkWg+xCWdK3jsCT5Dc9ZGgdAVRkhkZrztp9NVAHMDbXswbkbYfMYzTtmpQV6 c1T/cP01Drjsg7ypOSzGzlA1gDTHh8l7mif9DgbVhkk+1wKV+ssk3ZNNu0FqvYv/rqjTGL0uk8U aKu94fGD6vtl04hk1JY4X24FQa2l1m6hgb7BMoLTFM1sVOgYzzhfTeSmAIuJWzEfYTUsIB153EK dtC8NLTdoxmlArXVSGobYig7aSBJ1+DiTePDgfKLjvg9Y4hBoRrZY+c6cT7ye7Kq2p4Q3nS5eyi frquaGIvNOvKx3kYdNQ3/hCV7f5giVB9dUCQHfZ35lRuHKQ8RcjX9ILI+jdDJx3w0N7x6hdtrTI y+FKYLV0kbhK/l2W+7zubqkNPBnO0BprrRBDDkxkm355gdQw+B3Mfy9Ot2mec= X-Received: by 2002:a17:902:f54b:b0:2b0:5b4c:a439 with SMTP id d9443c01a7336-2b0a5405594mr1757525ad.2.1774313008753; Mon, 23 Mar 2026 17:43:28 -0700 (PDT) Received: from google.com (249.53.168.34.bc.googleusercontent.com. [34.168.53.249]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409c6besm12352073b3a.32.2026.03.23.17.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 17:43:28 -0700 (PDT) Date: Tue, 24 Mar 2026 00:43:24 +0000 From: Lisa Wang To: Baolin Wang Cc: Miaohe Lin , Naoya Horiguchi , Andrew Morton , Paolo Bonzini , Shuah Khan , Hugh Dickins , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, rientjes@google.com, seanjc@google.com, ackerleytng@google.com, vannapurve@google.com, michael.roth@amd.com, jiaqiyan@google.com, tabba@google.com, dave.hansen@linux.intel.com Subject: Re: [PATCH RFC v2 5/7] mm: selftests: Add shmem memory failure test Message-ID: References: <20260319-memory-failure-mf-delayed-fix-rfc-v2-v2-0-92c596402a7a@google.com> <20260319-memory-failure-mf-delayed-fix-rfc-v2-v2-5-92c596402a7a@google.com> <78a855da-8fc2-4e85-90a0-6bf9af030c02@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78a855da-8fc2-4e85-90a0-6bf9af030c02@linux.alibaba.com> On Sat, Mar 21, 2026 at 02:30:04PM +0800, Baolin Wang wrote: > > > On 3/20/26 7:30 AM, Lisa Wang wrote: > > Add a shmem memory failure selftest to test the shmem memory failure is > > correct after modifying shmem return value. > > > > Test that > > + madvise() call returns 0 at the first time > > + trigger a SIGBUS when the poisoned shmem page is fault-in again. > > > > Signed-off-by: Lisa Wang > > --- > > Why not move the shmem memory failure test into memory-failure.c? Do you mean let memory-failure.c kernel code check by itself? The reason I write the selftest instead of combining in memory-failure.c is because + do not need extra checking code in kernel code + make it easier to trace the entire execution flow, starting from the madvise() down through shmem_error_remove_folio() and into the truncate_error_folio() logic. Pleas let me know if I've missed something. Thanks!