From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0422C37A4AB for ; Tue, 24 Mar 2026 16:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774368728; cv=none; b=DHVKMWBag1GUktn1Iki//7WUv1m8f8Zxz7FuHteyqMl0mP+3g4DBgg4pDLF0hN9wcgJLUh1KRXhazuglkHSbgjx0NS4dVqeLupgADzh+iqJnten1EaP9+V16LJ/iKu5GzIFmkzRRthGSvpnSKfZIcUtQbryfYmyYdWK78iiAJLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774368728; c=relaxed/simple; bh=NGWihRTNsEWvA+3bIr1m6OPw9i12Umx2EgNgoDF+VGo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l99M3EOqKdPC4fXhHvlF09zBcNVi2gryaR4borNeeOD5BB1KD7sdy37JyvDF8LqzXrhNod/7hyKcKdNUF9/k+sTvQHJvCJtlliZi/h7OP72NX3LbxUuo7H298P0nkay36kqnzo8eU0BA+A7ogfzMKiblb4rkMg5FwNfsF7h/C8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RgyUnGyA; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RgyUnGyA" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2c107ef474fso3386672eec.0 for ; Tue, 24 Mar 2026 09:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774368726; x=1774973526; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xzZRZ8nzRuBK7fzKOuILCAb/KGtosM6PHlSFuG6kcjU=; b=RgyUnGyAs5fPNJZS/inCLBaSIKOfR8K6pfsN6K+QQGTTYVz3Nj2weX3X50b0a/vvA0 jJF34vWznSyUgkeKyHjFD51Qt1OWOzhkuyiCZWNizNR9qPVkos+eFlIv3FW+hVKwhm9W 5Po1PVYKMBBGebR1IFg+AzLnKOA7e3wn8wQYxwVEkE7OInyQrNlzsvY97sfiD9Jb3qxs FnPd2dZdnSlvmtWPRnhQoN7Xo31gSXMadmIvhH7xJiVZGfCJUMqtH1Gyl9g9r5cp/2OI j/chCZ4TmhrhU2/Lv5SR5LHd2X1DTCclffFckHqMwzHKfnG5lxB67EqRmzWN0Yb5qMbv Kavw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774368726; x=1774973526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xzZRZ8nzRuBK7fzKOuILCAb/KGtosM6PHlSFuG6kcjU=; b=R6ae5WOio3Yg9aOkGU4A3Cv2YTOB+QNqYZvnFXh84m69iK9MUV9qU4RQz/e+wxAxXE 9vExurHl0jC3Zftebgbsw+3vetIwOKRajR0SsLpFf6zoiuB9Bs2z9mpmnjl+d+MunA35 +8592NiJyCAJjNU5gB+BDCzQ3LOKL7nJxc4G8JyxR+0UZ7R0KEk8CFr4ibp5FlevcHP0 G8FAAiYFxfSLRoQsAc6+mgDtd2u7Vo41VTmW6/9gczytEIe8e0E/bis/eyW0Yw6INnlF Vp8n2Q0WPNjrfslhf+KUAfz15BtUyalsGOTzRRcTIx9z1iTyyPHc1hcWZjeCmauRWCyK 8zSg== X-Forwarded-Encrypted: i=1; AJvYcCW7TOFWu+fhZJ7fj7AGvlDFrCe8nF+MhGBTkNCPOLvHAvoyLuaigxaG46O4oQZjirvZC69IXv5+INWg7SI=@vger.kernel.org X-Gm-Message-State: AOJu0YyRh3R5+Mtp6tVjJWaSjPDKQGLkGuyTnXPpK0VWC/CUCVAPClZC rABwwWhfiQ0asKXbRXNx77y9VlaNVAYxcca5+pncWP8QWS2DkTuIrj5t X-Gm-Gg: ATEYQzynKLuxb+xhT0Pb+QUauM1vuFPPSRSozkpw/pEtTiLe96kOODbNOrxtsC8FQeO 9cxNTGvYLa3ADTJn4CHqY9VQ5mPaw51vOoxhgBpXbN6xgKBE16MDH0idBDU4Lkvo2UrhCDeN8xw EK+cFrhk9dRTK9DT2KaFwDOC+A0WDqAHoYiMtNbEguBUPi38VLDuy2CSOQ8m5Kph2MtqvU0ZtUo SNMzv2DuJ9rV5U8SEp3/XGX/aM2/+mnVKWFcldUwkGyqQPtuMnWWhFHxPMUoZoOGYXb8JZpEIty DrJWzjNbVJQaVMv8q1WoSW1EryCtUyVh0o6xmKrjYAW9sKcTKjeq0Ho7wVdP11SLDNZh2/43H0k FgR9k+QMH9pPAVGylDvj+mue3kiLai/sfds06RkcQGMcfF93PVyMuz9dWuooNuPqsQFouSqeOcU /4PGIthOfZiRY9d1I3U+bxi/zuEjiiYGybH3CDCbP1kWKJ2FhsIhqzZS/dGjw9w27dgI/rULwy4 0M= X-Received: by 2002:a05:7300:a994:b0:2c1:59ea:1103 with SMTP id 5a478bee46e88-2c159ea1872mr567954eec.21.1774368726006; Tue, 24 Mar 2026 09:12:06 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a686:fd7f:70d3:9156]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b3253d0sm15686055eec.29.2026.03.24.09.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 09:12:05 -0700 (PDT) Date: Tue, 24 Mar 2026 09:12:01 -0700 From: Dmitry Torokhov To: Andy Shevchenko Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Hans de Goede , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Daniel Scally , Heikki Krogerus , Sakari Ailus , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev Subject: Re: [PATCH 2/4] software node: allow passing reference args to PROPERTY_ENTRY_REF Message-ID: References: <20260323-property-gpio-fix-v1-0-9cb46e5fe7df@gmail.com> <20260323-property-gpio-fix-v1-2-9cb46e5fe7df@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 24, 2026 at 02:30:54PM +0200, Andy Shevchenko wrote: > On Mon, Mar 23, 2026 at 05:39:38PM -0700, Dmitry Torokhov wrote: > > When dynamically creating software nodes and properties for subsequent > > use with software_node_register() current implementation of > > PROPERTY_ENTRY_REF is not suitable because it creates a temporary > > instance of struct software_node_ref_args on stack which will later > > disappear, and software_node_register() only does shallow copy of > > properties. > > Isn't that the problem and we should take into account how to dup the reference > inside property core? Sorry, I actually need to drop the end of that sentence. software_node_register() expects the caller to maintain the lifetime and therefore does not do any kind of copying of properties. The majority of users define static const properties and we do not want to make an extra copy of them. Thanks. -- Dmitry