From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B5E63E023C for ; Tue, 24 Mar 2026 12:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774356210; cv=none; b=Ulo9Yk7LD7O1nh7Ph766MguWJo6avkN26/iW9ppEmIOrR02s6gWlGHDICQHKw9TLtvapD8H7NGRUpny3yj+QhIuMd4qGbkOIRUOKnTFkxClPkwCHWtc6e4TyN4MK4qV059Fz/tgKQvFmbp2M4f/UUhF77CItDUvt/ytgX/v7VR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774356210; c=relaxed/simple; bh=DfCasftR2+STAIXtK4P1K7UNMedi1wRjkjqs6vtyekk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rn5dksRjpfym+YNhZKRsHsPgoinMspvUMj6NZCPVqmS0JaZBd83sDRaeTwB1WbLjG1QTHhg+KqKcOmaLkyMGwL/4ZZCLmjx18oNaZU2HdDb4Ag3irG6AISJlGtMcp2POPgso5kB3USEgPUg3d+dz7hdJ/aCwgxYTfSjbJv7XDTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DKdK4gg/; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=M896PAlF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DKdK4gg/"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="M896PAlF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774356208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0oXBEexzzc00jtShUxwuQCa8xhkwv2sQ0t93WL1ksRk=; b=DKdK4gg/zbHhKODt6sApYCq954mkQb84IFbS83q9pVVJYsOxitsM2xJ294fxIRY7mD+Idj 6nFdblhrBQx0cqGDm3255T0GYmHbx6wXhoHJAnbKnhSJtQTCMBz5H31UssbqOxP1u7XWMe xU54XYIm485juAhDHOVWmN5H8a2FMFY= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-Zwt9GvqPPp-fJPZOBWD4Ow-1; Tue, 24 Mar 2026 08:43:27 -0400 X-MC-Unique: Zwt9GvqPPp-fJPZOBWD4Ow-1 X-Mimecast-MFC-AGG-ID: Zwt9GvqPPp-fJPZOBWD4Ow_1774356206 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3595485abbbso1673305a91.2 for ; Tue, 24 Mar 2026 05:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774356206; x=1774961006; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0oXBEexzzc00jtShUxwuQCa8xhkwv2sQ0t93WL1ksRk=; b=M896PAlFFytdqNDoBocZ9spNX34NOrhl3J2MaC8yQLd25zW1Fq4vrzml4oTtcS9Ekx mGE4Qf9Hi0ar/xlwtopCN0eyptu6CX+onSTsC7wqv/0tDuppmuVpYsgsNiNGpVw3aqZs EHwvQX4Ky0TxTmZFLwu7KeNh56Dgs53nv+5ty8V2heHGEjpDaYcb1gQCPi+avbcCQyiY nE9s3cOxeEBr3LVsb9J/HOmSE2rnhNZFmvjK7rf0fVdPaQDCc5wFMgz+MmnhrF3ARXQd P5t4q/EG4uNGTEkFIo+fge5UvgCsq2g6MjhSseKrjAuZ9Tg9SX+VIkeHM6EtP4rQBbPW iLbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774356206; x=1774961006; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0oXBEexzzc00jtShUxwuQCa8xhkwv2sQ0t93WL1ksRk=; b=FvdynVyn+Lydo2GTzX7g/+GKEOGeZ9sD+JaUJ/DS+iOZB5T8Nc+wTuwFvxGPLOeYuD MJXHTImLYPd3zG/F8bH7GOeaS+yXTBCKtTaospzumheKqwHWBwScKCwg9Gqu9KwTHJrx /CblVD4rHPAlowpEap4BUQzBLQGgKkrGMNYtnO+XaOqrr/lMKASRvS/0AQM4b2/0A/uK VhYZ3NTZ5b1n8qRpIPfgG/0yFODWtqzo5a7VVpC3m+2wK3qHnsbIWLbL6rZCqkXOPYGm L35Kd3qIEW0HOPBMVU9wilXo6o7PB8uVADOE+z5xAETkgf9UQQDEiu6t05FzQ6NNuror vChQ== X-Gm-Message-State: AOJu0YyMq/UONRzYNjhR8PC5HpWI54sD1aVWB+i+LoXz1ah+6yLhUwCO Pr1WYPNSPvve984ZfU5WVWQQIBhIaK6D1g9tDYVF7nSPbSVzOFcMUTYVbR5vRMzdBrVMW1ys5fB pkwjtOpkFtYCXzUqFJinDXLDSfU6UNJpj/mRZMjn51ojbo832zQyXr9/n7EYXWsinHQ== X-Gm-Gg: ATEYQzzECM2kRkhbOpU9MgtmbmYOQMZIDiYF59fmErKsTfsCNs3h5Mz6vJv5LyqA8Vo eBA6bKdssDeknayKANCA1eD3LHCjbslrPVHSjDR4QS7UNtwxMgnDNJBRstK7NUmshyZBzd8vMCG q9P0GXCmkM2urmnR0CdFF4YTgMTVHo6tfTFwACQcUJ/agiJ3+n7iBOFcRlVy703RIAdVmn7+dKN nTi7Hb/1FGQidrqyhV0+tMl+zWMbsWelBTYRpvq35AS6iFjP4h/wxdndRfCi1axNXp2UrB6oT8I E2iCGwM5JVg4oEq3MLPVjpc015yeC0i1oQSHZNG9CV4YGim88PE5v+kWwLRzKfpwMYpWGI/KY7s KZKlx11hZ/gQ= X-Received: by 2002:a17:90b:4c52:b0:35b:e529:2d60 with SMTP id 98e67ed59e1d1-35be5292d67mr8667084a91.8.1774356205767; Tue, 24 Mar 2026 05:43:25 -0700 (PDT) X-Received: by 2002:a17:90b:4c52:b0:35b:e529:2d60 with SMTP id 98e67ed59e1d1-35be5292d67mr8667060a91.8.1774356205309; Tue, 24 Mar 2026 05:43:25 -0700 (PDT) Received: from fedora ([49.36.108.16]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c03134bd2sm2423125a91.5.2026.03.24.05.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 05:43:25 -0700 (PDT) Date: Tue, 24 Mar 2026 18:13:20 +0530 From: Arun Menon To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Jason Gunthorpe , Peter Huewe Subject: Re: [RFC 2/4] tpm_crb: Add new wrapper function to invoke start method Message-ID: References: <20260324071803.324774-1-armenon@redhat.com> <20260324071803.324774-3-armenon@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 24, 2026 at 12:42:19PM +0200, Jarkko Sakkinen wrote: > On Tue, Mar 24, 2026 at 12:48:01PM +0530, Arun Menon wrote: > > - Extract start invocation code into a separate function called > > crb_trigger_tpm. This will be helpful in repeatedly calling the > > start method with different bits set to toggle between start, > > nextChunk or crbRspRetry behaviours. > > - Based on the bit set, we signal the TPM to consume > > contents of the command/response buffer. > > - No functional change intended. > > Please write a proper commit message, which is not a task list. Yes, I shall do that. Thank you for taking a look. > > > > > Signed-off-by: Arun Menon > > --- > > drivers/char/tpm/tpm_crb.c | 50 ++++++++++++++++++++------------------ > > 1 file changed, 27 insertions(+), 23 deletions(-) > > > > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c > > index 67c0061d4cab7..10128d078245c 100644 > > --- a/drivers/char/tpm/tpm_crb.c > > +++ b/drivers/char/tpm/tpm_crb.c > > @@ -445,6 +445,32 @@ static int tpm_crb_smc_start(struct device *dev, unsigned long func_id) > > } > > #endif > > > > +static int crb_trigger_tpm(struct tpm_chip *chip, u32 start_cmd) > > +{ > > + struct crb_priv *priv = dev_get_drvdata(&chip->dev); > > + int rc; > > + /* The reason for the extra quirk is that the PTT in 4th Gen Core CPUs > > + * report only ACPI start but in practice seems to require both > > + * CRB start, hence invoking CRB start method if hid == MSFT0101. > > + */ > > + if (priv->sm == ACPI_TPM2_COMMAND_BUFFER || > > + priv->sm == ACPI_TPM2_MEMORY_MAPPED || > > + !strcmp(priv->hid, "MSFT0101")) > > + iowrite32(start_cmd, &priv->regs_t->ctrl_start); > > + if (priv->sm == ACPI_TPM2_START_METHOD || > > + priv->sm == ACPI_TPM2_COMMAND_BUFFER_WITH_START_METHOD) > > + rc = crb_do_acpi_start(chip); > > + if (priv->sm == ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC) { > > + iowrite32(start_cmd, &priv->regs_t->ctrl_start); > > + rc = tpm_crb_smc_start(&chip->dev, priv->smc_func_id); > > + } > > + if (priv->sm == ACPI_TPM2_CRB_WITH_ARM_FFA) { > > + iowrite32(start_cmd, &priv->regs_t->ctrl_start); > > + rc = tpm_crb_ffa_start(CRB_FFA_START_TYPE_COMMAND, chip->locality); > > + } > > + return rc; > > +} > > + > > static int crb_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz, size_t len) > > { > > struct crb_priv *priv = dev_get_drvdata(&chip->dev); > > @@ -470,29 +496,7 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz, size_t len) > > /* Make sure that cmd is populated before issuing start. */ > > wmb(); > > > > - /* The reason for the extra quirk is that the PTT in 4th Gen Core CPUs > > - * report only ACPI start but in practice seems to require both > > - * CRB start, hence invoking CRB start method if hid == MSFT0101. > > - */ > > - if (priv->sm == ACPI_TPM2_COMMAND_BUFFER || > > - priv->sm == ACPI_TPM2_MEMORY_MAPPED || > > - !strcmp(priv->hid, "MSFT0101")) > > - iowrite32(CRB_START_INVOKE, &priv->regs_t->ctrl_start); > > - > > - if (priv->sm == ACPI_TPM2_START_METHOD || > > - priv->sm == ACPI_TPM2_COMMAND_BUFFER_WITH_START_METHOD) > > - rc = crb_do_acpi_start(chip); > > - > > - if (priv->sm == ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC) { > > - iowrite32(CRB_START_INVOKE, &priv->regs_t->ctrl_start); > > - rc = tpm_crb_smc_start(&chip->dev, priv->smc_func_id); > > - } > > - > > - if (priv->sm == ACPI_TPM2_CRB_WITH_ARM_FFA) { > > - iowrite32(CRB_START_INVOKE, &priv->regs_t->ctrl_start); > > - rc = tpm_crb_ffa_start(CRB_FFA_START_TYPE_COMMAND, chip->locality); > > - } > > - > > + rc = crb_trigger_tpm(chip, CRB_START_INVOKE); > > if (rc) > > return rc; > > > > -- > > 2.53.0 > > > > BR, Jarkko > Regards, Arun Menon