From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4C3C221F06 for ; Tue, 24 Mar 2026 14:40:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774363226; cv=none; b=XxKGiOzInWk5dnsneb2RsjNWc72Q+Ez4Jxz8BOEV+66mz9+UFBxhbtDLNQ6/XjSdLW/GzoymosXtNZqxG8eldrzfYNM2uCo9fMko4yTmRPy+JAscH2Tweu+6V4NkdsvRa3T+eFGUq9eNXhUMMGwXN2/B/cZ71yVuuvKvDOheECE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774363226; c=relaxed/simple; bh=iDX+GOiJ6TCs1UpxSiq/4pzSZTQS1uP2AgzGAapeeqE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NkzXgy7w2btvSMb8Hx/+Zp4V2gDJREMFIFT53bwXGKz/ZvlP91B338MkkOrj8ylIrqjvJKZxQHyotCjIz5kDeO8J3LwOBYF3fI6xNlRKhDOaY7523TwCsTAkQqeuFnu4vaDeYSeMsgn+RZxvJP3KrlHUu2OL/0sMrd24JE6cS54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cz5VrGAX; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cz5VrGAX" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2aeab6ff148so80365ad.1 for ; Tue, 24 Mar 2026 07:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774363224; x=1774968024; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OIVar2XSUD8cxHHwMjaGV6t1yc3VT/8+s3ndQMtgs74=; b=cz5VrGAXNLhP1q1oMTFl4Ge/pyJgR0zZQxYZwFYpcjLTtVH6Pt1m+g66XxNIkq7MYV nta2hd3T1hvjBRPPJX1i3rM5c9CZcQVh4QI0mqZuLSZblPIU7zno6zanQDjp7OZFZiNB bMvYWPHr8a4/q1AgJKlTkQu8PuVH2zIwgfycMDwUKev3OnWWEHj1DTS9rIUHsa9JvkMX ZjpDXuggUC77hL2ZCey0Htmo2QSDpCQ7/PyVVKwtbMsS0Xp1PFXCNTwgvKB6GQMb9KFo KbNFifQyGQnPhQUpzMeJSA6v14BAGS+XEOBrz4gxovNoyUvWMZkJtKxs5/HCurLYFj0e EuRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774363224; x=1774968024; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OIVar2XSUD8cxHHwMjaGV6t1yc3VT/8+s3ndQMtgs74=; b=NJvBGAyddvrPcNOvujJa+3/gnUAQK7Ylb74cM4K9FA1rH9PkQixumymALF0fd7JE/v bztgZvdgnuqkFvptmRUNXZ777AwTca1VvczXGOJREMQM0MhHblVYo5Jo+589zLiex6+G M/e9kCf+mv39Wbux2RaApqqPUCqFnrVGvqNPtcMA1dmghigc5Ls8rkHQybdUpyk8NjGZ QJX9n29MIi+0VyqNE++VzkgIJURtfvu96cxG9wSgCNSq+EzEsLe+fQ6yQpwZ6+HYAqKt zDBHM6B3qzcaFRoz2jTWUWGW+vNRQhkmw4NvCNs6Tq3HqWKgcC1TLTvbYTfn3Nku9f5b 95fA== X-Forwarded-Encrypted: i=1; AJvYcCWk5Odk9/5mu+W9CocfjdKlnomFPj6zJPcXtVSxbb6fCLVsDH9gyfjQbarvu6lHOR2fzsGYyvClcpk531U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy62wfuY5V8Uhpq9UZJ5fSr39guSIl5l9YWQihV197ybSRbjiTB jnP5BC6Q8q+cg+DIJ1BpmMY4tisxo5yFoJpymroI7RDzAxthvhb6Dpko5mBb8dR4xA== X-Gm-Gg: ATEYQzzuZ6inK8yyQmiHh1SYiZVwXToNYZJi4klIwyERMfGJWQdoV5m7iCfoMNvXfhU 1sWLgS2YcgplU7G2eZSu2Y1pz4UyKGSe+pqJV2E164MH7hla1eZpMsqmTkyKeIxilZyUOQtwDpQ XBvkNLPHNjpLqB6ntG5H8LkwiAc4RuYyN6txsO4dIurYlNI9N915tfY+PecjK+2syziuVOrPukg UBUYXscV9A2UV5PFo9+sN10VTUqkNEAeLjTYFzRK6PgcY8CB6ZP9F3ZMD97waUgd4Yl6TnVMhmD aklhvSC9bMmBsAKvym8chXxGnFHQZDpdNfFve6JH+qJVG0vfcTnhvEbIse3l3IFyEX4zNljYDJl FjjwBfAlHWRjazzEPWkDQjf9qgZB5jBm2zIFVp0SJsierPpoAoH5boT3uA+qbDx1SeH8bYyuQQy d2P74MP2TZTcg6LsBIR3pPf/6i1kDBE5rcpCiKUko8FOezPSJRIvoCKTjdaA== X-Received: by 2002:a17:902:f652:b0:2ae:575b:2345 with SMTP id d9443c01a7336-2b0a6707a09mr2261445ad.9.1774363223664; Tue, 24 Mar 2026 07:40:23 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0ac5b287sm719016a91.4.2026.03.24.07.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 07:40:23 -0700 (PDT) Date: Tue, 24 Mar 2026 14:40:18 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, jgg@nvidia.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] iommu/arm-smmu-v3: Do not continue in __arm_smmu_domain_inv_range() Message-ID: References: <20260321225041.11090-1-nicolinc@nvidia.com> <20260321225041.11090-2-nicolinc@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260321225041.11090-2-nicolinc@nvidia.com> On Sat, Mar 21, 2026 at 03:50:40PM -0700, Nicolin Chen wrote: > The loop in the __arm_smmu_domain_inv_range() is a while loop, not a for > loop. So, using "continue" is wrong that would fail to move the needle. > > Meanwhile, though the current command is skipped, the batch still has to > go through arm_smmu_invs_end_batch() to be issued accordingly. > > Thus, use "break" to fix the issue. > > Fixes: 587bb3e56a2c ("iommu/arm-smmu-v3: Add arm_smmu_invs based arm_smmu_domain_inv_range()") > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Pranjal Shrivastava Thanks, Praan