From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82FBD221F1F for ; Wed, 25 Mar 2026 01:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774402596; cv=none; b=Ywlpd4YV2e/2Mgke0KJeGPwK5ihZkfxxN5aXOXLdp/19WaNVdDS3Vsk8tnZC1KpI43l1f6cqHtTqj5BIbtbmMc7qyqS7iFRCz8NESakOWhM/t0s9/PCwx2boeegbgcDqspLduEKgwX+uw5Vj8oZ3JToOXM7QtDZsOjq/u8ftcjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774402596; c=relaxed/simple; bh=RYbTtBTIQC/2zekrz1ZNuc6XbPGA++D398QAiC+0UKA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MdVTlUG+Ggr+UoyYJ983g1FOB4/xm2ei2Nk4XEfFuhP1TNrfMhZF2do0UvC1dEfWoRwBWOMbN6SaBgScTmH/0SpNkXbUmKvSDCImakE/hjx9XkSO26ESkjjxuLIdbKPEgBuonoOSJXi9Xjd78j3p4t6fhmO1T3bCbR3DS6h2m0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XWviNaKJ; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XWviNaKJ" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-1271257ae53so2112022c88.1 for ; Tue, 24 Mar 2026 18:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774402595; x=1775007395; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V3AYzet/rbgbElXL1qLXjB5IItamG2qrNQe2ZTLEwoI=; b=XWviNaKJT8y8v7VLaJW7IeEyK3lkCaKi/wrFB2ygAK4gnwdeEIID7htOUJITU3nA6R cl2PfVY4JCOxIgu9+CKHiaZg8END9CUBzSy0TcLe2kKFInUZxObSggimkCzhqZypHMJh dMTojfdiUrcZxAP7Fm1f/5LVJEPkqZ29YN2SrSZvXswWpzjN0dLzbX8U+tp/On2Iclkd 37MYpRLeXlDEXy5V1+XAiDzL34lurGOu2DSqeczpH/XFn3iOiK+F9j5eVkroM69lbore HB+RhVXWXbjNab7yMwITZggta/FMyfFQny3dP0ftl+InGwbvPT+RzOMOvRdeRRYxvtwZ lyQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774402595; x=1775007395; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V3AYzet/rbgbElXL1qLXjB5IItamG2qrNQe2ZTLEwoI=; b=QZaD3rE9IbLPFdyqKzqceFaPwGrt85SJJHwqGELDsj6B1al5uDiA1N7PAdnVyShj3h dwBXA2LpQEActhv1JeWA2X7T3DHvQB2TAuK+MhnvbvF5BlrEiT3OdpsOiObLx1kNCmzh XTJRtpljHuBe9u3CcRKh1nVY0b6ViEe415YIjFtTY5Ur042cIFIG8UyYGY5hbSn6CBdX POtbk5inM5NyRFS87TjmAY6teYN8/1kNFPtes+6IwiMx/i9CIiQDimxDkL2XvzGqqYsb S5ai2gaQd5d/KhY2TTTRWRnXWaFLUDE0HzSDytNFa1yo1WX6I0PkbBLgdMUEiLTITJQU yCiA== X-Forwarded-Encrypted: i=1; AJvYcCVXnfTYZ92asCGN9G/VesrgHS3hcKnCrPT78UDRp+7flkNurB7QH2UtBznrSUHsuNwfaO6vXgOKNslrlck=@vger.kernel.org X-Gm-Message-State: AOJu0YwKKvVU5O9SXOhFBkFY751PLZDntq9gszMqavmp21i9CkkwvqO/ HK34EBq8qMKBoUC1ns0xK1tG43jZ+5NnHYEYIZZTMn/P+ScWUYwvUSXt X-Gm-Gg: ATEYQzwctt3JRgDDJBEy1ZmtOlYJWJ9pT+3UFN75GE8KhEhzsBaKEaajLAr7rQxFNNn 9GGwi+iIYpqoxRysMUVP/ZP6Q7LCzPGG+hoiVJmPFheGnejgd9w8OlxUX6jzVCiaTPB1CKkNYXQ eRrhAtUMzDOYCMsQkTQ5TbYszjZEi6PcLQHHoaviEaoZaDHB2QIbAp6eFjsi7ameDSb9aiW6LAR e6jyZ+xfT5AK2HBKdT4kjWUZGC5/jQo7K9uQ28xp1hzFto4x0XSUAYkvgqVwMZL/1zCx85nV+UW e8G+PwfbMkAX2p/et2PDTsYahWpc2tUpWrbUFMWvuTEkoV9aXRNQxjuQafWBSkRuylVAqdOi+13 8MmoVvEXqYx5LJpcvpZtvpUDuqewE510UOfa73ZS4r2mNhBZU3KAitpgiSgMHyQWDFuQvkmtgOl moncpK/1K/0yaUGm2o84wPodH4AJlcEDdEh7LIy9fctGfOY2ObC8WibZ9OBnp78o8S X-Received: by 2002:a05:7022:69a7:b0:127:366f:8bb7 with SMTP id a92af1059eb24-12a96eceb78mr711116c88.25.1774402594510; Tue, 24 Mar 2026 18:36:34 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a686:fd7f:70d3:9156]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b17b90dsm21300866eec.10.2026.03.24.18.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 18:36:33 -0700 (PDT) Date: Tue, 24 Mar 2026 18:36:29 -0700 From: Dmitry Torokhov To: Pengpeng Hou Cc: andriy.shevchenko@linux.intel.com, kees@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Input: penmount: bound packet buffer indices in IRQ path Message-ID: References: <20260323121715.74954-1-pengpeng@iscas.ac.cn> <20260324131442.27632-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260324131442.27632-1-pengpeng@iscas.ac.cn> Hi Pengpeng, On Tue, Mar 24, 2026 at 09:14:42PM +0800, Pengpeng Hou wrote: > pm_interrupt() stores each incoming byte into pm->data[] before the > packet parser gets a chance to reset pm->idx. If the incoming serial > stream never matches one of the expected packet headers, pm->idx can > advance past the fixed receive buffer and the next IRQ will write beyond > PM_MAX_LENGTH. How will it advance? The handlers do: if (byte_0_check() && pm->packetsize == ++pm->idx) ... If we never match any of the protocols then pm->idx will never advance past 0 (and we will keep overwriting the first byte of the packet array). Does your analyzer miss the "short-circuiting" nature of && operator? Thanks. -- Dmitry