From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A67663A759B for ; Tue, 24 Mar 2026 22:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774392570; cv=none; b=i9kAuLTHjKBuDFBIDxGiH8xbMQdmPEg5AFIijXjcn5d9/dA/wWB/0Tz5f+3KOrBTWWFcNQkF1/mji0Cl0P1IkwNCHUcDKfxr6kEuWWBFzzm+Ie13OMx2SKDk7JW7vEWDM21T054BbJi84w/+gUbLMNPhSfnmd3Q5joMNnoQVk9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774392570; c=relaxed/simple; bh=x66sLBkPM9N4hLXn1DtA+Tsks0CxriXlzYTWpFI/SYE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RhKYIUR4zN0/RY7uUDcJm5jrzgsXAiC5xTnWqlH2oEFoXHJ9C/aLgdzpSN5QYgiLUqmUWCAmo8CiTCMbFHI6XRb8EZAPUJ7PKnQ1fZjJxnEI0KDuJG26QTaMoshJ7xdoX4ydTuBw+5wDU8yHIDQR1fB/vFg0lHyXe89aZgpeXMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=goFNEleL; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="goFNEleL" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2c0ea57fea7so7372251eec.0 for ; Tue, 24 Mar 2026 15:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774392569; x=1774997369; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=gNx1VzVQBg2bGT4I9Bs+XmhXlek+bgkFq6Ick2G8sfw=; b=goFNEleL/6OQLHn+J+oosYrN144Gvq3n9PxHX01b3AOoBSzMntlYyfDBUev1IPmigZ PJNtk4Puil6DsOG08u2pCFDFISC0hZRWi1B9SPmvozkwDXnq7KMGHUMsTG48keNg0TzD 4ux7C9aM+cSk5nll4X0cKKMzWfJza7Ui2/qr02Y9axCLE+5UeHxyAg+zw5hr5ZMGy+s2 Wr13RXhhNNJkgmTqx7vNdoQdlkz6i4BFXe5JyxWiA7mIuFsP21vN0NKAed52WPvzDxz3 ClVP44k1pNh21rMwxWJ+CfYqfExhhx0OcvYywKMsYisw5flN0b4YHgQc14etyGiDFJ7r 1NCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774392569; x=1774997369; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gNx1VzVQBg2bGT4I9Bs+XmhXlek+bgkFq6Ick2G8sfw=; b=Z1yIGsSoiXh03rC5xJ2EjfAprlAxW66FRJM4LzDNyNoRexopHqf0xdRzOcQIsa9h/x jCCy4qgttOLOtIahVdD2D6uMcrXwknDYmRZosR5V2IWp5u8AotuwUEmKvAsN7xwX+ehR S5uXWZoWxbowipbucZqlFzgk2haxxiYAs3u+TFRM13KQIhYogZ1mb4TZoNNgd7AQLtq7 Lar/E7AOKvMM+fU9Xsbz5mQBY6lU55Ow/1XZ4RZcpl6SiMQ/7kAGIIDRtUKPKB9QgUol K7ojVqeDI0RX8a8CTG7RiKMTL08IS9C29qD6uwQW9dx+1LVsF5nWOzjyM6nb0exq2iKs BsJw== X-Forwarded-Encrypted: i=1; AJvYcCWQtxEBEHvmlKucnPACI87nY8qH9Jz44HKkd6CJ8KklbAj4Nw+L7jm+50ZZP7jAb7al6JHxeEZmpNE63v0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywbf9YMmVwuEAVr8xOPjyJwhvvXW0E/p2+yU0PtYrFFTl5z4ION lvYGL26henmVWOuSfD0IomZtyJKGT4Ke8NI8Youg7Utv4Ud5Li6kgkM= X-Gm-Gg: ATEYQzwqb9m9Jek/ColOpCaRMdvRt80JQ/enxm5AaWCv1aOo44U6VUI+/5ebQfuPKxc o6sK2r+HbSs+/9L7lh9IkdGqjdET/lI4rIQCU5+qjebTK2IlXjBBnUI7M8XRZByHpIIo6hgDvKF FaDg8XG+DLM5vz0ba+lQJhggmGwPIk+lui5/BlzNG2g+USL/YgRdd9x2GGy3c/NGvq43R0CorMB HNSA+xLDk03zE6h79OiImSBPJOn2OKMxxXQhprgiLPsdP2kABrbTxnvBnmvmJaENMtdpES2DcaO S7MTabsVwRZAp2j91Lt2opxJkzGB+TdwIrnapWxTEJ+CYkxCpuAFjOpKmbIVuc0xknyx92j8kWE Nxp0USnHQRs1sIGjJ2j5N2bSAud+z/GQGoTamgHXiuTyIoLBmzTHBS6z+M4ui91y0cHBAXUojgc fT7dvHDbAAXTkSf3BzJRvR/90ZbZEz6tAckT8rt9DXAVZPwR/QAxgmLE+/YfBnN4VAicOUb9n57 ZMfaWT/k+a6EsrhRXwmuGHHccFx X-Received: by 2002:a05:7301:6582:b0:2c1:2999:498e with SMTP id 5a478bee46e88-2c15d3a1176mr717588eec.18.1774392568523; Tue, 24 Mar 2026 15:49:28 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b1961a2sm16796758eec.12.2026.03.24.15.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 15:49:28 -0700 (PDT) Date: Tue, 24 Mar 2026 15:49:27 -0700 From: Stanislav Fomichev To: Jakub Kicinski Cc: Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, aleksandr.loktionov@intel.com, kees@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: Re: [PATCH net-next v3 03/13] net: introduce ndo_set_rx_mode_async and dev_rx_mode_work Message-ID: Mail-Followup-To: Stanislav Fomichev , Jakub Kicinski , Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, aleksandr.loktionov@intel.com, kees@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org References: <20260320012501.2033548-1-sdf@fomichev.me> <20260320012501.2033548-4-sdf@fomichev.me> <20260323162003.0d155055@kernel.org> <20260324142114.216fcb01@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260324142114.216fcb01@kernel.org> On 03/24, Jakub Kicinski wrote: > On Tue, 24 Mar 2026 11:13:04 -0700 Stanislav Fomichev wrote: > > > > + netif_addr_lock_bh(dev); > > > > + > > > > + err = __hw_addr_list_snapshot(&uc_snap, &dev->uc, > > > > + dev->addr_len); > > > > + if (!err) > > > > + err = __hw_addr_list_snapshot(&uc_ref, &dev->uc, > > > > + dev->addr_len); > > > > + if (!err) > > > > + err = __hw_addr_list_snapshot(&mc_snap, &dev->mc, > > > > + dev->addr_len); > > > > + if (!err) > > > > + err = __hw_addr_list_snapshot(&mc_ref, &dev->mc, > > > > + dev->addr_len); > > > > > > This doesn't get slow with a few thousands of addresses? > > > > I can add kunit benchmark and attach the output? Although not sure where > > to go from that. The alternative to this is allocating an array of entries. > > I started with that initially but __hw_addr_sync_dev wants to kfree the > > individual entries and I decided not to have a separate helpers to > > manage the snapshots. > > Let's see what the benchmark says. Hopefully it's fast enough and > we don't have to worry. Is keeping these lists around between the > invocations of the work tricky? Yeah, that sounds doable, don't think it's too tricky, just extra list_head on net_device + change the alloc/free to use it. And then we keep this cache around until unregister? I will try to add it as a separate patch to cache these entries to keep it simple for review.. > > > Can we give the work a reference on the netdev (at init time) and > > > cancel + release it here instead of flushing / waiting? > > > > Not sure why cancel+release, maybe you're thinking about the unregister > > path? This is rtnl_unlock -> netdev_run_todo -> __rtnl_unlock + some > > extras. > > > > And the flush is here to plumb the addresses to the real devices > > before we return to the callers. Mostly because of the following > > things we have in the tests: > > > > # TEST: team cleanup mode lacp [FAIL] > > # macvlan unicast address not found on a slave > > > > Can you explain a bit more on the suggestion? > > Oh, I thought it's here for unregister! Feels like it'd be cleaner to > add the flush in dev_*c_add() and friends? How hard would it be to > identify the callers in atomic context? Not sure we can do it in dev_xc_add because it runs under rtnl :-( I currently do flush in netdev_run_todo because that's the place that doesn't hold rtnl. Otherwise flush will get stuck because the work handler grabs it...