From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613031DED40 for ; Wed, 25 Mar 2026 03:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774408050; cv=none; b=kLBbxu0Wv0k3E7onzfWngIslH98IT6LCZKWMiZpTSSD77IhzpuE9Mf4013ExGsuiDUsMHAmhxEV1xhexEPQXoKvz4XIOXs5oPTWXtDYqV4thVUWzL+RLRJIYbcd1rbUyMxcQYUnaZLyi7bPX9kHUZFPkTaAWrIlZ3aF9kSXWgmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774408050; c=relaxed/simple; bh=aUNlhbFyq1O+rHaQHtemCc59Hx+rwmDigNquGYw9NQk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m8FgVdHcZhY39+Ee6zE5LJuOSjMNAfMpvGLP7QylZ2nlOyT4kMdK48t40NJG/U6cqDcvIWSd1tjkkMBOwtaT8wywVFZlwhSRmH5GxsYuXIuEBHYq32tQJGHWsKTfljJ1MGhp7yPExf9ZiMpPdW1o2KeoEQnCKJCu1SdEtxPbnio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JKdBMd78; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JKdBMd78" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2b6b0500e06so7313778eec.1 for ; Tue, 24 Mar 2026 20:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774408047; x=1775012847; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WA9CYNO4U2XeTWJ1VvL9JiIeO6k0ZE2Sw4Df5C/By2g=; b=JKdBMd78SnhCvg+matKFZy5eQ92JCdEuodMAhQGeelXzNU3hQdU4gkcT3kXJDwmyU4 ZqmFl+90VndwDHUJz88w3qpfHp7sQiJqA9cMuErVTpJApNgVEaiv4TlSacAVkXSb+4rQ 8FleVBKuDSzDarxTNKCwN7tK2hSofMmFSb4sdUMZHKfjdZbAh4fezt3q1wJFZJV/ecoM DixtI3vsnqZXVRkklQ164UXYBYwTZEJsmFs3mGjYbrlvQPBV7RfeVMYWFSK8SgQ8dQRM 4eEXJTDP471HkA92kMShBFA2yl3rZeacq2xkK9FFLsN2bEmn2c2b0vuSfWmn/gcGpyxl cing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774408047; x=1775012847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WA9CYNO4U2XeTWJ1VvL9JiIeO6k0ZE2Sw4Df5C/By2g=; b=STRj4I0ZgCgRzttpsbzSWHkl+GS6e5lgXFcolvDiCCGs8rVvhi+HihrwpEhT0XhwmJ YWfsga6BG6OCljKeA21Wp35rnmIJc3LMiJZZLzJdavCZhGr2GjsgP68utS1ez3Akr+Eq xQ+pfrIZz23tISnv/oM/wbroCrosoXSpaXlbJd26dZzOXrOz2bZvlGdfAg+fA06p0vBk fPnRf6zA3dkCitkC886v+V9i1PJzxvs+Q7pnC8ifIuZbsdKAHhYSG4OyRmlmNOKpy8A6 1+e1/WBWU2y5eKntLDXakpEHisGlErVhwhdkXIClhuGrGR0f/B13yxbc1OBx3eabVZp7 7NpA== X-Forwarded-Encrypted: i=1; AJvYcCWsOFd2bSK2zg3yDXOQ4+Yc3GF6dIP11Ox74vJE30A9zfzUEvbaaauJta+uYoBWt2mI5c7LIgQAyLNsVX0=@vger.kernel.org X-Gm-Message-State: AOJu0YzsuJ5i1mnPgWRFokW5opVHa74uutmXgxvH0nkfo+ijXT+51FLu pnBZuJXjbWY2BxatQ5+8+UeGQLyoWUSa7u4sL8yo6ooJmpUSjuLdC7aV X-Gm-Gg: ATEYQzzounUTyZexhtc1KQSuFW8s4WrpN1fPjTAFT+ZqHSPuIXRByot2h8C29aQ/gnN mptasNnS+R6miRa+8GVJgd2ziJTw+R+35i+DkT0QombH+qVKdiMFecghG0bbMNPy+F17icx/7hj rgHgHsW2D5t1/S5BxKzwPO1gmcGyABkCSCJ0iV5cj0IMWeDM5THgJCWjoBDLArdE8eZ3brcrzwT dvEbpppCcZDdOsm+zlhSH86Hitx2Vgt0wF6dgjOGE5+YEalY1pzxKNa+U/FdKiOK/43XM0UrdkC 6O/HMUdpjvFX72BxgPqoP4qKQvXtvYxwBqaA2isp8WnPFNqMOTaRs17cjdlgDcb4U4+IbrMrLHh HPEisLOSIIX41PgIPa1/nnF7UFEfF6ddzrF2iIW4OgKoeJ528QQdzd/OvgvdwJ6epZA53Q88F83 RSHZ8XdeeitBPm1qYzEy2n4M2YOXcluFcz7bmVjy+kSr6jjQclCEA5QgXKYy8qLNt/ X-Received: by 2002:a05:7300:e8a1:b0:2b8:26b8:3446 with SMTP id 5a478bee46e88-2c15d294bd1mr733329eec.2.1774408047292; Tue, 24 Mar 2026 20:07:27 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a686:fd7f:70d3:9156]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c15517eaf6sm5158859eec.28.2026.03.24.20.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 20:07:26 -0700 (PDT) Date: Tue, 24 Mar 2026 20:07:24 -0700 From: Dmitry Torokhov To: Pengpeng Hou Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kees@kernel.org Subject: Re: [PATCH] Input: gf2k: clamp hat values to the lookup table Message-ID: References: <20260323074541.93413-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260323074541.93413-1-pengpeng@iscas.ac.cn> On Mon, Mar 23, 2026 at 03:45:41PM +0800, Pengpeng Hou wrote: > gf2k_read() decodes the hat position from a 4-bit field and uses it > directly to index gf2k_hat_to_axis[]. The lookup table only has nine > entries, so malformed packets can read past the end of the fixed table. > > Clamp invalid hat values to the neutral position before indexing the > lookup table. > > Signed-off-by: Pengpeng Hou > --- > drivers/input/joystick/gf2k.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/joystick/gf2k.c b/drivers/input/joystick/gf2k.c > index 5a1cdce0bc48..78fba36285dc 100644 > --- a/drivers/input/joystick/gf2k.c > +++ b/drivers/input/joystick/gf2k.c > @@ -164,6 +164,8 @@ static void gf2k_read(struct gf2k *gf2k, unsigned char *data) > input_report_abs(dev, gf2k_abs[i], GB(i*9+60,8,0) | GB(i+54,1,9)); > > t = GB(40,4,0); > + if (t >= ARRAY_SIZE(gf2k_hat_to_axis)) > + t = 0; I think if "t" is too bug we should skip the loop instead of reporting the first axis. > > for (i = 0; i < gf2k_hats[gf2k->id]; i++) > input_report_abs(dev, ABS_HAT0X + i, gf2k_hat_to_axis[t][i]); Thanks. -- Dmitry