public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Honglei Wang <jameshongleiwang@126.com>,
	acme@kernel.org, Thomas Richter <tmricht@linux.ibm.com>,
	mingo@redhat.com, peterz@infradead.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	adrian.hunter@intel.com, james.clark@linaro.org,
	ojeda@kernel.org, gary@garyguo.net,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf symbols: Add 'intel_idle_irq' to the list of idle symbols
Date: Wed, 25 Mar 2026 00:05:33 -0700	[thread overview]
Message-ID: <acOJPVxR7MRLE4NW@google.com> (raw)
In-Reply-To: <CAP-5=fVdxJxSAYyAoS_UVxQqOtS1GrhHphEag=Ksb2Oc+NuCGQ@mail.gmail.com>

On Mon, Mar 23, 2026 at 11:35:05AM -0700, Ian Rogers wrote:
> On Mon, Mar 23, 2026 at 1:53 AM Honglei Wang <jameshongleiwang@126.com> wrote:
> >
> > Commit 32d4fd5751ea ("cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE")
> > introduced intel_idle_irq as entry of those with
> > CPUIDLE_FLAG_IRQ_ENABLE, say, skx and icx so far. Let's add a new
> > one to the list of idle symbols to avoid noise.
> >
> > Signed-off-by: Honglei Wang <jameshongleiwang@126.com>
> > ---
> >  tools/perf/util/symbol.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> > index 8662001e1e25..7cff66e7ce06 100644
> > --- a/tools/perf/util/symbol.c
> > +++ b/tools/perf/util/symbol.c
> > @@ -730,6 +730,7 @@ static bool symbol__is_idle(const char *name)
> >                 "cpu_startup_entry",
> >                 "idle_cpu",
> >                 "intel_idle",
> > +               "intel_idle_irq",
> 
> It would be nice to make this an Intel specific idle symbol. I sent
> out a patch set to do this:
> https://lore.kernel.org/lkml/20260302234343.564937-1-irogers@google.com/
> but there are no reviews. Perhaps we can follow up that patch by
> adding this symbol. Arnaldo, Namhyung, wdyt? I believe Arnaldo was
> supportive in:
> https://lore.kernel.org/lkml/aahC-zp56irr5e2k@x1/

Yeah, I'm ok in general.  I've left a comment there.

Thanks,
Namhyung

  reply	other threads:[~2026-03-25  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  8:52 [PATCH] perf symbols: Add 'intel_idle_irq' to the list of idle symbols Honglei Wang
2026-03-23 18:35 ` Ian Rogers
2026-03-25  7:05   ` Namhyung Kim [this message]
2026-03-25 16:07     ` Ian Rogers
2026-03-26  3:43       ` Honglei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acOJPVxR7MRLE4NW@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=gary@garyguo.net \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jameshongleiwang@126.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox