From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 639A7364047; Wed, 25 Mar 2026 07:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774422901; cv=none; b=YWDtNm9WOgmUMO1tlgsn1Naxz4zty34QXr+00/fRMTad9fKrBYmktQ71uyfodrnu5r3aUomTbPEjeFxab3UXAL/BXNTcPn5FYF5Sz4v6GP+7PEqz63IfRLvqLTFklmoGeONWJGoUE/VHxfPXOMerlQx6v8s9xWr1hRAaMaHZNOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774422901; c=relaxed/simple; bh=d1MOvz/OLE69hKxRkmCSGoPjCUiu+GDaR8jlcJGuUk4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UuOzpyOJCPwmXkzzuYvkZEPQxM9KDrB+k8lecp7QjaVsFOMsIfanUYNzzcLLhw/G/AsqPuvH1jPZxjEUKJtBCDc+LCR+jyriqVAEe8Z8V+poBXIBklbHs9VcqKxGnUrmkLQVegs53I/yC8bYoRioJ9GghvjtCSD2bNglGvh63ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QY8M2dY9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QY8M2dY9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A4FCC4CEF7; Wed, 25 Mar 2026 07:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774422901; bh=d1MOvz/OLE69hKxRkmCSGoPjCUiu+GDaR8jlcJGuUk4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QY8M2dY9ccpjKxKPb9fNb6qLJ7f4btwZ+9CQTps+g4qoRY6Nd3nLbbVvKKLWTmCS5 LkQyzxD4C90GUSUwGRn/3H3QF6wwOyXePQJGtj3b0xadK1/5BUB6QWKR2H4ash/7HV t0szAMV2HvqmjL7PpXUw043RG/pMMro69mqnWCUIxPPesNIdTnPnBcHcC1yY55U/Yj QYRaDEkgZ9qZUh5e3j1tTUE3iZqsHeQD8c7VNUOMKfF/7xOG9U9kn8E8YPfTsxo28c +uc7OceT/uHS5qc/uOUavODtmsAroGej8+iAjCbqLSenBzujs5vjRNC62MTTE9NM3p N6fwzoaoDCpKQ== Date: Wed, 25 Mar 2026 00:14:57 -0700 From: Drew Fustini To: yunhui cui Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Radim =?utf-8?B?S3LEjW3DocWZ?= , Samuel Holland , Adrien Ricciardi , Nicolas Pitre , Kornel =?utf-8?Q?Dul=C4=99ba?= , Atish Patra , Atish Kumar Patra , Vasudevan Srinivasan , Ved Shanbhogue , Chen Pei , Liu Zhiwei , Weiwei Li , guo.wenjia23@zte.com.cn, liu.qingtao2@zte.com.cn, Reinette Chatre , Tony Luck , Babu Moger , Peter Newman , Fenghua Yu , James Morse , Ben Horgan , Dave Martin , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, Rob Herring , "Rafael J. Wysocki" , Len Brown , Robert Moore , Sunil V L , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [External] [PATCH RFC v2 14/17] include: acpi: actbl2: Add structs for RQSC table Message-ID: References: <20260128-ssqosid-cbqri-v2-0-dca586b091b9@kernel.org> <20260128-ssqosid-cbqri-v2-14-dca586b091b9@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Mar 25, 2026 at 09:48:37AM +0800, yunhui cui wrote: > Hi Drew, > > On Thu, Jan 29, 2026 at 4:28 AM Drew Fustini wrote: > > > > Add structs for the RQSC table which describes the properties of the > > RISC-V QoS controllers (CBQRI) in the system. The table also describes > > the topological arrangement of the QoS controllers and resources in the > > system. The topology is expressed in terms of the location of the > > resources within the system and the relation between the QoS Controller > > and the resource it manages. > > > > Link: https://github.com/riscv-non-isa/riscv-cbqri/releases/tag/v1.0 > > Link: https://github.com/riscv-non-isa/riscv-rqsc/blob/main/src/chapter2.adoc > > Signed-off-by: Drew Fustini > > --- > > include/acpi/actbl2.h | 92 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 92 insertions(+) > > > > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h > > index f726bce3eb84..7367990349ee 100644 > > --- a/include/acpi/actbl2.h > > +++ b/include/acpi/actbl2.h > > @@ -53,6 +53,7 @@ > > #define ACPI_SIG_RGRT "RGRT" /* Regulatory Graphics Resource Table */ > > #define ACPI_SIG_RHCT "RHCT" /* RISC-V Hart Capabilities Table */ > > #define ACPI_SIG_RIMT "RIMT" /* RISC-V IO Mapping Table */ > > +#define ACPI_SIG_RQSC "RQSC" /* RISC-V RISC-V Quality of Service Controller */ > > #define ACPI_SIG_SBST "SBST" /* Smart Battery Specification Table */ > > #define ACPI_SIG_SDEI "SDEI" /* Software Delegated Exception Interface Table */ > > #define ACPI_SIG_SDEV "SDEV" /* Secure Devices table */ > > @@ -3165,6 +3166,97 @@ enum acpi_rgrt_image_type { > > ACPI_RGRT_TYPE_RESERVED = 2 /* 2 and greater are reserved */ > > }; > > > > +/******************************************************************************* > > + * > > + * RQSC - RISC-V Quality of Service Controller > > + * Version 1 > > + * > > + ******************************************************************************/ > > + > > +struct acpi_table_rqsc_fields_res { > > + u8 type; // 1 > > + u8 resv; // 1 > > + u16 length; // 2 > > + u16 flags; // 2 > > + u8 resv2; // 1 > > + u8 id_type; // 1 > > + u64 id1; // 8 > > + u32 id2; // 4 > > +}; > > + > > +struct acpi_table_rqsc_fields { > > + u8 type; // 1 > > + u8 resv; // 1 > > + u16 length; // 2 > > + u32 reg[3]; // 12 > > + u32 rcid; // 4 > > + u32 mcid; // 4 > > The spec appears to specify a length of 2 bytes for this field? Yes, this was a bug. I have changed rcid and mcid to u16: https://github.com/tt-fustini/linux/blob/b4/ssqosid-cbqri/include/acpi/actbl2.h Thanks, Drew