From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACA923218B3 for ; Wed, 25 Mar 2026 07:36:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774424182; cv=none; b=sXpsNBmmUs0/sjlqQH5yQbq16KGyjZGlZEzgVuXgd0/wPg9mEl274ws9Y0B4AXqwdrls/ESDOiyvE8uoQbToQmt2W4mpY8un7iWBN/AHPAJJ4NMu4XfoYyGrlj0/iIX4xNUmMvmH8xFoM0PgZILCYDdIPROJGz+3XgZHCUq183s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774424182; c=relaxed/simple; bh=9Qx9fXrwvfFtOiQNsZPuCVh9uGVzjllSDkxpTYUJPqc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A9H9C2rKFSQLeU131L+MI8yMFGie9LIlGEoZCkfh5IKwR/T+cv2N6YvJAl22oKdk0uuEw3JSbMBmyvEtvwkYJsNPmaHBsNxgX+oW28AYZzTG3/pHRbLuptUTz7Zaa5qztqAe0qOW39KQHyseL972hB27af3L34P1g3/dzLx0VKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h5fx+r9V; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h5fx+r9V" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439bcec8613so3260842f8f.3 for ; Wed, 25 Mar 2026 00:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774424179; x=1775028979; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SX5kqQxDgfMliTGpdl9tH5D0+JbWrgoc3ihk1JizxOw=; b=h5fx+r9V1kxHN1vTJ0S0FHkBLwnl7Yj47gSV8FggRK2J74ilNR8s9C9kCkdSAdF9LJ 4F6smsPy/9gZr8rh6FQElfyT3YD+m1Yr0XUYzrLG6BoMlUfOyzXj9wHS7oSJ7seFd4kB dz9YavA9sm4hi0cywnK40EurSba6Qy0rrwbDf87juog9FwD9m1STeHHMtg5p3/7KhGv+ VzbkhFIXvRA/9ZNTYnHcBpouOTFxuj2XYI6AjvbuH41V94a7kdQcMAsGmHtVDjPldVuJ XWdTmCXuAW6uph+iJDPLCJgPP9ZKn18fposhHk3H+ZfAhzIvlRnHCJZh5nfiHA5nuqga l8IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774424179; x=1775028979; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SX5kqQxDgfMliTGpdl9tH5D0+JbWrgoc3ihk1JizxOw=; b=phEO04wPM94s/3sfHYzFB8yz/ZgWwVQkPnH6xmsSHQHkIA6dwzFBzJa/YHCTMtEW7Q NlzsZz3nPwzZvf5G1H8r+oDHSIRyfzBqZ18V45w+2lRjhko0K3YPHKu1My9M2lSRDtJG XgxmPn7oWfhKSMoyTfDqaywsDBYY2vkKpkHNwUZIQl2X4A7e2xYI1WgWhsnxhefiynWB tq+yeBgPSfCY+a0P1mGoxNBZJ+fdp22n7yLjalJHb73Lf8jgrXcJ9gm3uW5GkcEmY1/y 3DXwSgoyT3f7dX4Cl+L/MAJvov9SJ0bWKj4EH+NdDR8r93TcOAowVyjkPmye85Lxidq5 jIEA== X-Forwarded-Encrypted: i=1; AJvYcCVtrgl6Rs98qHvCMfcGW0PLGdJE6hs6BRiCEKrZIhJp3fXGYZpA2OFUUElXpLYNYjzNJOZdT287GlwYIFs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz68oAVWbzMasRiyVDk2YXvbf2QycSQEs1O2J6ejvh48RlsPjpm Y70m/9/m3XKmCphIQxmpj/MaoNxAXe4N6Gd/bF3Zn4Ve62pBPY2cq7AntTsjPrPdPMk= X-Gm-Gg: ATEYQzxCNACVNoToKVsa5OhL+S3th0TPreXHGu1i2UrUR8mIE0fbity8h6kA3IpCJMb Xw+8Z4Y5hK8t4uEeYevjavzW7QmTm4l/FdkFy1jAeySnSqgieqIl8sJqhK1Xh1+6KzH11wz1RcG tHWghA2eRXXEn8oKTzomLetqyJ1HFXSejudA83fMU4vCN9g5tu26AENghw+LsVzxmP3MQNLc+s2 8mnUeX5idlu8uPTRPxcljLmwOb/uUu259Y8Op5pGdp5RwBiwJx0Gzm/xHpyrRrhkjt4Xqczfj5x FtZnwYr6XOzVW87Gq0QbAv5aSy/KQdQE5GhTti6rUpoF+FyGhrG0N7ySZwqqWXYPMvifT8TEUSd Xed3dpvoBrnSvh6ZLEnUBjWQRFGilh85ji3xZVbt7Jkq4V9TWmi0wZMIIhfih81mpcD+78hvOyE 6zrLfhyPeIJf+21FkFJ8n8JWGxl1aq X-Received: by 2002:a05:6000:230f:b0:43b:410d:c4b2 with SMTP id ffacd0b85a97d-43b88a0506bmr3287885f8f.29.1774424179038; Wed, 25 Mar 2026 00:36:19 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b8a106339sm4558831f8f.36.2026.03.25.00.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 00:36:18 -0700 (PDT) Date: Wed, 25 Mar 2026 10:36:14 +0300 From: Dan Carpenter To: Omer El Idrissi Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: rtl8723bs: cleanup return in sdio_init() Message-ID: References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260324220453.47406-3-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260324220453.47406-3-omer.e.idrissi@gmail.com> On Tue, Mar 24, 2026 at 11:04:53PM +0100, Omer El Idrissi wrote: > Make sdio_init() return errno from sdio_enable_func or > sdio_set_block_size instead of _SUCCESS/_FAIL vendor-defined > macros. > > Signed-off-by: Omer El Idrissi > --- You're going to need to start labeling your patches as v2 etc. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index 358eac0837cf..01b5d8a70072 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -131,9 +131,7 @@ static u32 sdio_init(struct dvobj_priv *dvobj) > release: > sdio_release_host(func); > > - if (err) > - return _FAIL; > - return _SUCCESS; > + return err; This patch isn't wrong, per se, but I'd really like for you to update the callers as well like how you did in the earlier patch. Right now, they're still testing for _SUCCESS. Make sdio_dvobj_init() propagate the error code back instead of -1. Change rtw_resume_process_normal() to: ret = sdio_init(); if (ret) goto whatever_and_return_NULL; It will make the commit message a little bit more complicated. Make sdio_init() propagate standard kernel error codes instead of returning _SUCCESS/_FAIL. There are two callers for this function. sdio_dvobj_init() already returns negative values but the caller doesn't check for errors so changing this doesn't affect anything. rtw_resume_process_normal() returns NULL on error so leave that as-is. Sorry, for being a bit nit-picky on this but you might end up potentially sending a lot of these patches. regards, dan carpenter