Re: [PATCH v2] iio: adc: ti-ads7950: use iio_push_to_buffers_with_ts_unaligned()

Jonathan Cameron
2026-03-25T20:39:14Z

On Wed, 25 Mar 2026 07:56:31 -0700
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> On Sun, Mar 22, 2026 at 03:30:21PM -0700, Dmitry Torokhov wrote:
> > On Sat, Mar 21, 2026 at 09:05:39PM +0000, Jonathan Cameron wrote:
> > > On Sat, 14 Mar 2026 16:12:24 -0500
> > > David Lechner <dlechner@baylibre.com> wrote:
> > >
> > > > Use iio_push_to_buffers_with_ts_unaligned() to avoid unaligned access
> > > > when writing the timestamp in the rx_buf.
> > > >
> > > > The previous implementation would have been fine on architectures that
> > > > support 4-byte alignment of 64-bit integers but could cause issues on
> > > > architectures that require 8-byte alignment.
> > > >
> > > > Fixes: 902c4b2446d4 ("iio: adc: New driver for TI ADS7950 chips")
> > > > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > > > ---
> > > > Since we were looking at this driver, I was going to convert this to use
> > > > IIO_DECLARE_DMA_BUFFER_WITH_TS() but then I noticed that we actually
> > > > have an unaligned access problem with the timestamp since we are
> > > > ignoring the first two elements in the rx_buf when pushing the data to
> > > > the buffer.
> > > >
> > > > Unfortunately, this will cause a merge conflict with the series Dmitry
> > > > is working on. I don't think there is any rush to get this backported
> > > > since no one has reported a crash from unaligned access. Since fixes
> > > > should go before improvements, we could apply this to iio/togreg then
> > > > Dmitry can rebase his series on top of it.
> > > I've done that. Applied to the togreg branch of iio.git pushed out as
> > > testing etc. I've also marked it for stable so it gets picked up in the long
> > > run.
> >
> > Cool, I'll rebase and send out my patches as soon as this hits
> > linux-next.
>
> Hm, I only see it in "testing", not in "togreg"...
>
Should be there now. I was waiting for build bots to take a first look.
They were clean so now pushed out for picking up by linux-next.

J