From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4BA53BE140 for ; Wed, 25 Mar 2026 12:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774440154; cv=none; b=i69DBIy9x3fn/p2hkG3WIlsjjLfJE3g499R91osSv5E5e5znFwj/TEZGXDaJTRX2IrFAOy8hJy3/e1qhiipAbDkWBKDGC8CUlmWqwNj3cELS0eLdURdPzooqLF95X2PGWCmXwH64FmCJ56Yfr4bvtt7sV8ZLj40/ZbJtSk6lbVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774440154; c=relaxed/simple; bh=ytbeFN2cV6feTFSXdEoboo6K//S4MkrKhBp15wDDwXo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DprwiJNl6zadwRpLfA1QJWKV1E7uyqDH15/7rBLLn7I8VaCeuDo5bizK2k9ej+BLTGFPR18J8sH76cUYoSbJZBtH0XSz106epbhrnHKDmescgw/uNn618fAZU+2u4PuoYq3CyTFCOKvMn3NjT6YF/PEex/iwamFOMD9mN/qWuhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YW83oZdL; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YW83oZdL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774440154; x=1805976154; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ytbeFN2cV6feTFSXdEoboo6K//S4MkrKhBp15wDDwXo=; b=YW83oZdLGURbYxxAvLKjmchItnLzXjjw2BF4oG/QOdTVyeHOZj9ejfs3 ZH9NU9DyPxwQAzEg2l5IxD0Ym8gM7ib8CG/Hpx1sPqZiLGQQmwbRpwZqW lu0Kl9+gNOVFbf7LTjq7PNu8pGD53SvkH39qmXnOqY566DNxRlvi9Tt+p imlszBWvPASWYkjFOIBNldX1+K8Ff9PGeC0t5dHXMZtV6qFRzSQzNTWK1 rtlUm7L42iJdc2i8Yn/Ms8aGckIbqXerXvSD9ShLRPF/4qBh0+jwvS/uJ NGq3HShfLPJIdifEUcfonrNvrNYbK+bjWICXCIfa80NdKs/Btc8rCqTFv g==; X-CSE-ConnectionGUID: PmlduVjVTweg8vOoMml2Dg== X-CSE-MsgGUID: kv3MhXs7SpSNKc/76IG6Lg== X-IronPort-AV: E=McAfee;i="6800,10657,11739"; a="79329946" X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="79329946" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 05:02:29 -0700 X-CSE-ConnectionGUID: nyRqSeT8Qy+oFJUGAVHPaw== X-CSE-MsgGUID: BuiywjDBQ0O2GFNkpq9qog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="224923638" Received: from dalessan-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.32]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 05:02:26 -0700 Date: Wed, 25 Mar 2026 14:02:24 +0200 From: Andy Shevchenko To: Josh Law Cc: Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] lib/vsprintf: add missing (u8) cast in format_decode() lookup Message-ID: References: <20260324224940.50508-1-objecting@objecting.org> <20260324224940.50508-5-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260324224940.50508-5-objecting@objecting.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Mar 24, 2026 at 10:49:40PM +0000, Josh Law wrote: > The first lookup into the format_state table correctly casts to (u8) > at line 2778, but the second lookup after consuming a length qualifier > does not. On signed-char platforms, a byte >= 0x80 sign-extends to a > negative index, reading before the array. > > Add the same (u8) cast for consistency. Maybe yes, but get familiar on how the Linux kernel is built. There is no such possibility IRL with this project since a commit in the past. Feel free to find what I meant as your learning curve. -- With Best Regards, Andy Shevchenko