[PATCH] dt-bindings: reset: st: convert to dtschema

[PATCH] dt-bindings: reset: st: convert to dtschema

[Gopi Krishna Menon]

Convert the STiH4xx reset controller bindings to DT schema.

Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
Suggested-by: Dhruva Gole <d-gole@ti.com>
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 .../power/reset/st,stih407-restart.yaml       | 31 +++++++++++++++++++
 .../bindings/power/reset/st-reset.txt         | 11 -------
 2 files changed, 31 insertions(+), 11 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
 delete mode 100644 Documentation/devicetree/bindings/power/reset/st-reset.txt

diff --git a/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
new file mode 100644
index 000000000000..d7adbc00f5c3
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
@@ -0,0 +1,31 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/reset/st,stih407-restart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ST SW reset controller
+
+maintainers:
+  - Lee Jones <lee@kernel.org>
+
+properties:
+  compatible:
+    const: st,stih407-restart
+
+  st,syscfg:
+    description: phandle of the syscfg node
+    $ref: /schemas/types.yaml#/definitions/phandle
+
+required:
+  - compatible
+  - st,syscfg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    reset {
+      compatible = "st,stih407-restart";
+      st,syscfg = <&syscfg_sbc_reg>;
+    };
diff --git a/Documentation/devicetree/bindings/power/reset/st-reset.txt b/Documentation/devicetree/bindings/power/reset/st-reset.txt
deleted file mode 100644
index b63948737d80..000000000000
--- a/Documentation/devicetree/bindings/power/reset/st-reset.txt
+++ /dev/null
@@ -1,11 +0,0 @@
-*Device-Tree bindings for ST SW reset functionality
-
-Required properties:
-- compatible: should be "stih407-restart".
-- st,syscfg: should be a phandle of the syscfg node.
-
-Example node:
-	restart {
-		compatible = "st,stih407-restart";
-		st,syscfg = <&syscfg_sbc_reg>;
-	};
-- 
2.52.0

Re: [PATCH] dt-bindings: reset: st: convert to dtschema

[Krzysztof Kozlowski]

On Tue, Mar 24, 2026 at 09:29:30PM +0530, Gopi Krishna Menon wrote:
> Convert the STiH4xx reset controller bindings to DT schema.
> 
> Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
> Suggested-by: Dhruva Gole <d-gole@ti.com>

Both suggested you to write this patch?

> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> ---
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> 
>  .../power/reset/st,stih407-restart.yaml       | 31 +++++++++++++++++++
>  .../bindings/power/reset/st-reset.txt         | 11 -------
>  2 files changed, 31 insertions(+), 11 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
>  delete mode 100644 Documentation/devicetree/bindings/power/reset/st-reset.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> new file mode 100644
> index 000000000000..d7adbc00f5c3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> @@ -0,0 +1,31 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/st,stih407-restart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ST SW reset controller
> +
> +maintainers:
> +  - Lee Jones <lee@kernel.org>
> +
> +properties:
> +  compatible:
> +    const: st,stih407-restart
> +
> +  st,syscfg:
> +    description: phandle of the syscfg node
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> +  - compatible
> +  - st,syscfg
> +
> +unevaluatedProperties: false

additionalProperties instead


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: reset: st: convert to dtschema

[Gopi Krishna Menon]

On Wed, Mar 25, 2026 at 12:39:36PM +0100, Krzysztof Kozlowski wrote:

> On Tue, Mar 24, 2026 at 09:29:30PM +0530, Gopi Krishna Menon wrote:
> > Convert the STiH4xx reset controller bindings to DT schema.
> > 
> > Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
> > Suggested-by: Dhruva Gole <d-gole@ti.com>
> 
> Both suggested you to write this patch?
> 
Hi Krzysztof,

Thanks for the review, They helped me to improve the PATCH,

- Dhruva suggested me to change the subject from dt-bindings: power:
  reset: st: convert to dtschema to dt-bindings: reset: st: convert to
  dtschema as that was the general trend followed with similar files.
- Daniel suggested me to use the word 'reset' instead of 'restart' in
  the patch (whereever possible) as that is more accurate here.

That's why I added those Suggested-by tags.

> > Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> > ---
> > Note:
> > * This patch is part of the GSoC2026 application process for device tree bindings conversions
> > * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> > 
> >  .../power/reset/st,stih407-restart.yaml       | 31 +++++++++++++++++++
> >  .../bindings/power/reset/st-reset.txt         | 11 -------
> >  2 files changed, 31 insertions(+), 11 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/power/reset/st-reset.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> > new file mode 100644
> > index 000000000000..d7adbc00f5c3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> > @@ -0,0 +1,31 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/reset/st,stih407-restart.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ST SW reset controller
> > +
> > +maintainers:
> > +  - Lee Jones <lee@kernel.org>
> > +
> > +properties:
> > +  compatible:
> > +    const: st,stih407-restart
> > +
> > +  st,syscfg:
> > +    description: phandle of the syscfg node
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > +required:
> > +  - compatible
> > +  - st,syscfg
> > +
> > +unevaluatedProperties: false
> 
> additionalProperties instead
> 
Ok will send a V2 for this.
> 
> Best regards,
> Krzysztof
> 
Thanks,
Gopi Krishna Menon

Re: [PATCH] dt-bindings: reset: st: convert to dtschema

[Krzysztof Kozlowski]

On 25/03/2026 13:04, Gopi Krishna Menon wrote:
> On Wed, Mar 25, 2026 at 12:39:36PM +0100, Krzysztof Kozlowski wrote:
> 
>> On Tue, Mar 24, 2026 at 09:29:30PM +0530, Gopi Krishna Menon wrote:
>>> Convert the STiH4xx reset controller bindings to DT schema.
>>>
>>> Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
>>> Suggested-by: Dhruva Gole <d-gole@ti.com>
>>
>> Both suggested you to write this patch?
>>
> Hi Krzysztof,
> 
> Thanks for the review, They helped me to improve the PATCH,
> 
> - Dhruva suggested me to change the subject from dt-bindings: power:
>   reset: st: convert to dtschema to dt-bindings: reset: st: convert to
>   dtschema as that was the general trend followed with similar files.
> - Daniel suggested me to use the word 'reset' instead of 'restart' in
>   the patch (whereever possible) as that is more accurate here.
> 
> That's why I added those Suggested-by tags.

This is not the meaning of Suggested-by. Drop the tags.

I gave you now review, so you will add "Suggested-by: Krzysztof ..."?

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: reset: st: convert to dtschema

[Gopi Krishna Menon]

On Wed, Mar 25, 2026 at 01:36:15PM +0100, Krzysztof Kozlowski wrote:

> On 25/03/2026 13:04, Gopi Krishna Menon wrote:
> > On Wed, Mar 25, 2026 at 12:39:36PM +0100, Krzysztof Kozlowski wrote:
> > 
> >> On Tue, Mar 24, 2026 at 09:29:30PM +0530, Gopi Krishna Menon wrote:
> >>> Convert the STiH4xx reset controller bindings to DT schema.
> >>>
> >>> Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
> >>> Suggested-by: Dhruva Gole <d-gole@ti.com>
> >>
> >> Both suggested you to write this patch?
> >>
> > Hi Krzysztof,
> > 
> > Thanks for the review, They helped me to improve the PATCH,
> > 
> > - Dhruva suggested me to change the subject from dt-bindings: power:
> >   reset: st: convert to dtschema to dt-bindings: reset: st: convert to
> >   dtschema as that was the general trend followed with similar files.
> > - Daniel suggested me to use the word 'reset' instead of 'restart' in
> >   the patch (whereever possible) as that is more accurate here.
> > 
> > That's why I added those Suggested-by tags.
> 
> This is not the meaning of Suggested-by. Drop the tags.
> 
Understood. Will remove it and send the v2.
> I gave you now review, so you will add "Suggested-by: Krzysztof ..."?
> 
Earlier I would have. Didnt understand the use and meaning of this tag properly.
But will take care not to let this happen in future.
> Best regards,
> Krzysztof