From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73B43E868D for ; Wed, 25 Mar 2026 16:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774454842; cv=none; b=ejViyzOee8SDpExJzNpF4Rslc3uE8I+vJ0/m6K5uNj/DIyseYxKFLpApErjVYLC0RFGmpAY9B8xU2PSBpKI14vrTIgYj40AyloudMQx5H+aOigjlh0MKsnbOM2HkKFLbxlR4ad/VNn+U4UuwW0tvkG51Nqg5fFYRbFsRYSWg21k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774454842; c=relaxed/simple; bh=tRVrH/eGDZEhc94hquI9wdhTHVXSKZmcQeHkA08w/O0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T4VAuQr0YXf014kAahhKTcGleyXMClLsIUSTgpNwDPt+oS+1pzlukk8v6J2nF3MDlt1j1Hv0A5zLW2t2TCTkpX6aKi+FPnKmkR2iKXUdvGVlX4ZRcH5NJCEjCX4m63aIkvdJUubWZq39ehIVgLFT2RykYMoYH2D7Yuq50SCGPvc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RdXWeoRS; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RdXWeoRS" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-128e4d0cc48so6228757c88.1 for ; Wed, 25 Mar 2026 09:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774454838; x=1775059638; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gdshhwa9bhbiHCrsGjvqNNH3T3tMDqvKfcfLW4vvxN0=; b=RdXWeoRSj0I0QWvzPyHjUsSxxU73FQb65n8ZMVMWrlQ058HMJ1jXsPdgCz/wy546YV yexgXKVuBRxN+LnvjZBcCSdIZ8hYL4GBBUJsC7rNNMS/vwIWGYuS7MpICH0hVxc6BrU5 OHZSmFxy32gIg55WMh3o8AgmWN9+N5UK4C1hLdG1ZzVGD7b5XcsuLg1zChPO6fqwlUo+ NQrMVmnUUTMF2z6Y9CwV+M0K1qmte64CrhN6RP33x43OgwhRdpQTXzYpaOfGuqiD48Vo xlF9zy4/idu8IMkWxCVVKSK1WV15eQ0juAxQwS9/ZjCKJeH70gZWCe/bThxpuI3Z7WOl 2hFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774454838; x=1775059638; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gdshhwa9bhbiHCrsGjvqNNH3T3tMDqvKfcfLW4vvxN0=; b=lWLn1pKQ8u1YiokKdcn4V50uSEByovOOBE1nLtEyQxdNN3ZT4QN815Ef16M/y3zcjA gOyAdZipjZdmTPOR5iNC0X20ovHQbFEFN56tnkMnuraELyn4JykhargEMvtf53Vyjo12 gPbY+yFYMPGLWzYN2cN9blyE/z53XphLOZ67iBqewsX4OVeyiIJDZjcOGTwE/cD7PlwK xVP53uFdKsm4x2HbXPQqajzpEnjRWpc3t6bhMMbm0dq/EKOsdDzbLXmy1QfM6sRjbCdZ 8j6SEx6sQwgr0hrkA2cuNHBqKoRSiVJ0rQX4E9DocIQLitF0CupwHlxx8QBs1mFEuELg y2TQ== X-Forwarded-Encrypted: i=1; AJvYcCXAylWc4TS+EUyd718AZMd4P63wcGrtPUy2l1eIgtZ8hlVmzlLhKjy/g2FajUsxes5mHxM9nxoBRuda+z4=@vger.kernel.org X-Gm-Message-State: AOJu0YxsbL2WDsw6/4rwg1RzKkNgCSYHbikeAF4/IO+Ftrm54YGmkDJh 3fOtvD9GfWx2XWqUMOyHATsJAWm4hCPbOrKshxpmky6rIVUSU+4agKf2auYWOg== X-Gm-Gg: ATEYQzyVq8ZjpCtWZuXGm/Z5s5vPKQozz7UJmBo/Ji72ntgLI3IVMm8UDw3CgwVaLUe I1LYPC/Un/zil0m7yVUJIdaH9OWbyNSrubla705yeeo7Jw34SgTRWfMgJdhV1tUVroZeA9Wmtgr Ge2bLSoK8YRarX+Z4j0aIf7E/Ngl9LtZQ0UTH94uYfNIg+4oFajxlVmcga4MUUVc85db+h08Gq/ EHtQ+1rbgljrnRnYC4eTJwbZZW9OQSLF1JXHtnolAuZRH0Z0DjI49yYJC+WFSt3OdVo4IZpD2YO MsLMOhvxOoG/W9PZ396P1FeFZswxdOmMfVnIIE5pEsHETOkAwswCeE6d/mE4ibv1MwIc6GYyiDm ZrC4hJpbLDL6kutjH9EWwU6RgD1zOLUeYNITy19Z35/mjnJjUGy0JgsQtqbf1vyDaZtHYf05Xtg jQW8IrayUQiGw8tEyHl6EoudYdlYroJ8k6c73awb1Co2VZgnDhjzuxMRFzATQafTJ0MqQrw4nux aY= X-Received: by 2002:a05:7022:618f:b0:12a:6a64:81ef with SMTP id a92af1059eb24-12a96e48c61mr2414431c88.9.1774454838367; Wed, 25 Mar 2026 09:07:18 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:b7b4:352d:eb23:66e5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aa7827e02sm229615c88.12.2026.03.25.09.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 09:07:17 -0700 (PDT) Date: Wed, 25 Mar 2026 09:07:14 -0700 From: Dmitry Torokhov To: Lee Jones Cc: Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Fall back to using software node name as LED name Message-ID: References: <20260311-led-swnode-name-v1-0-798a49e041c6@gmail.com> <20260325133836.GB1141718@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260325133836.GB1141718@google.com> On Wed, Mar 25, 2026 at 01:38:36PM +0000, Lee Jones wrote: > On Wed, 11 Mar 2026, Dmitry Torokhov wrote: > > > This allows setting just name in software node representing an LED > > instance and forego "label" or other properties needed to form a name. > > This is helpful when converting old boards using bespoke platform data > > to software nodes/static device properties. > > > > Signed-off-by: Dmitry Torokhov > > --- > > Dmitry Torokhov (2): > > leds: core: implement fallback to software node name for LED names > > leds: core: fix formatting issues > > > > drivers/leds/led-core.c | 20 +++++++++++--------- > > 1 file changed, 11 insertions(+), 9 deletions(-) > > --- > > base-commit: 7109a2155340cc7b21f27e832ece6df03592f2e8 > > change-id: 20260311-led-swnode-name-6db2e5757071 > > I'm happy with the set, but it failed to apply to leds-next. > > diff a/drivers/leds/led-core.c b/drivers/leds/led-core.c (rejected hunks) > @@ -584,8 +582,9 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data, > } else if (is_software_node(fwnode)) { > n = snprintf(led_classdev_name, LED_MAX_NAME_SIZE, "%s", > fwnode_get_name(fwnode)); > - } else > + } else { > return -EINVAL; > + } > > if (n >= LED_MAX_NAME_SIZE) > return -E2BIG; > > Please rebase and [RESEND]. Do you have something that is not yet pushed out? I see "for-leds-next" updated 6 days ago and the rest of branches even older. I tried rebasing on top of next-20260324 (latest) and there were no changes... Thanks. -- Dmitry