From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83CED313545 for ; Wed, 25 Mar 2026 16:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774454909; cv=none; b=rf2gpN0QlqxEmRhCCgTlo/RNqWadjzc0QY/muqcI6lgZCKlAE8KN+4a9Jpf6eD8BkBGkA15cDpCl/VB2UFnRafKtjoe8/M9rijl5Q2FIxqL4Q1cR3A3+MymLsW4o/6ldD/Epzlj2mqsuyrN4X/K4gWnA3X64Rc56tVzEIEPQQC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774454909; c=relaxed/simple; bh=hNNwjsHedzC//Q9OJ1PxWjJ65mudSwkNnDyt7S2u1vM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KQIokDVfctjTRmXKfBtwHlaLajV6WYJRCQ4I01t+4bqW19BZB6+kzMeiDLAu7GSKXnvhMfrxmknuUb2fH4vkOGsdtjbuLBp5LiEbkKcYLbk/GVdcGe1TeuovNLNg85vfy4icFGOn68OLCkeLH8BfZVo2bl8VoKVFSCe6TpIKPf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=clJIUZkH; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="clJIUZkH" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-126ea4b77adso7253380c88.1 for ; Wed, 25 Mar 2026 09:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774454908; x=1775059708; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M17iBYC/F74Bg+gul2lB6f/cFM/aLJkZMkbSd6hygpg=; b=clJIUZkH41qGVMiDA2PYJ5BmcpUqHxDDxnCQ9AO3RS4db9KnC7MBoTDDaapUMlyw6n qE/em8tvVIZCxR5Jy3HUyqoCVKkyA0T//9nfYhQmQcq7E57A9TAS6OY4RjNK8tX8tYN5 aoCSkAEtVYqZE3PhH8V4MUJG6va7jLCWPbWdjoAl4dOZ4CBaw10QugLCa8C6W8UIVZKg fEgUX4bZnwVs+pE/wTnEawVSz6IGyS1JLbatQi/NozomPIaGLcly3oAe7tXF+VlJIfqp GEKbfkC1Aim+416DSlCWydXn/6wIUhmUpWISWUaRQYLMTkhN8pUGkmmJuT7CcSoFKKdY jO+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774454908; x=1775059708; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M17iBYC/F74Bg+gul2lB6f/cFM/aLJkZMkbSd6hygpg=; b=JpEn3qDR5syz/fi01me7K9/FPJ13lTreLmB71aWNEkl7qc5xdEjGOsTTU3okJ4kI5x oikA/gV3nlbbn/7xZV8USu7p5i9BSoenXOgtxB6QOMOD0UUA8EnMtySOfVuWGFuRMOe6 9Q7XHaEq+EtMQ3pgFYl73P3yXpUyPWLnhrTHx4X5xOLdMCK3GT9iua5oD5zbu8CBbXgn /zc3mMyVpRsDNfIeSFpjglHYG6+hz4zmXtmhJLMjI/ydZwPxhqTX2N1zfrmqBqYdnjt5 eE/1SboVSkt13t/MctT8FvN7DeckuHyATpdgiJ9HVd2MmbB8Blt2LQqkYzJcXn4h1yx+ WR5A== X-Forwarded-Encrypted: i=1; AJvYcCXLsF1I/ibNWCBmSvoUwsyiMqGM1Ybrz7ytJYtQuxgUAfZ3oMP42lfeC8S0RVWgDucfYn/9JT1lmLkU3yo=@vger.kernel.org X-Gm-Message-State: AOJu0YxVZ/FLalGdRBZo/+RZgvKfqdyXN0ZDOCeHbEteO+h9dqzMSRtF viz/RlDjV34O73JqmG6Rpv4NxI6i2Aqi15IP6IZeRu3gwPpo2gFgF88D X-Gm-Gg: ATEYQzxYBuX8XpbPfZqArt8kTSOTsxr8hLpcdKghIc04LSU+prYFdIuGkvku5+R98jH 5O5EFbkgSJOM3uFVROXjPtFSxSny3FcCL8yyNBydiEjUE6rHaDaUPxc3IGbiUQpqTGcAj1xAVh4 VjDB1LICRnPHmDmkfr9jPJPml+uQHKQvFJUiADOEuS0abE2xVQhJt/cJ+cvjz/B8TRa8LZ44MdD /VxQuu55Bx/ucnyx7NDuPAvEosCWFwhr0obkZ3eNr9TuOKqcrtsqUsUjgW9eIKxFg6lgaaeZ+7U sMypnLEI9WphPNxUAoDOZ3ifyZWP/4bktPxLs0lOA+TgGi962ECaW24WK3wd/zI/KW/+KKp0kPa Jy5wqrSfPgUAyXVTBIh2odmiPrjHTEcXsA0GnfGcgS5ctS1z4O9pO4PmkEPraPRntIr457AEDne zf4xkkKzyv2oN/fkID3mgWvhIsvemT9iVCyasF8mVVulULjzI/O+QO0zuLp23cpP6j X-Received: by 2002:a05:7022:ec86:b0:128:d3de:c9e4 with SMTP id a92af1059eb24-12a96ee7658mr1893590c88.30.1774454907665; Wed, 25 Mar 2026 09:08:27 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:b7b4:352d:eb23:66e5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aa6e5b9d9sm194018c88.3.2026.03.25.09.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 09:08:26 -0700 (PDT) Date: Wed, 25 Mar 2026 09:08:23 -0700 From: Dmitry Torokhov To: Val Packett Cc: Hans de Goede , Henrik Rydberg , Stanislav Zaikin , linux-input@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: goodix-berlin: report a resolution of 10 units/mm Message-ID: References: <20260321073242.556253-1-val@packett.cool> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260321073242.556253-1-val@packett.cool> On Sat, Mar 21, 2026 at 04:30:07AM -0300, Val Packett wrote: > Without a reported resolution, userspace was assuming 1 unit/mm which > is wildly wrong: a regular smartphone is clearly not 2.4 meters tall. > Most applications do not care much for this kind of raw mm value, > but Phosh's on-screen keyboard would accidentally trigger swipe-to-close > gestures due to misinterpreting small movements as huge ones. > > Do what the older goodix.c driver does and set the resolution to 10 > units/mm to make sure the numbers calculated by userspace are reasonable. > > Signed-off-by: Val Packett Applied, thank you. -- Dmitry