From: Alice Ryhl <aliceryhl@google.com>
To: Yury Norov <ynorov@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Viktor Malik <vmalik@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
David Laight <david.laight.linux@gmail.com>,
linux-kernel@vger.kernel.org,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH 2/2] uaccess: minimize INLINE_COPY_USER-related ifdefery
Date: Thu, 26 Mar 2026 08:00:44 +0000 [thread overview]
Message-ID: <acTnrMeMIfqNvObZ@google.com> (raw)
In-Reply-To: <20260325163313.749336-3-ynorov@nvidia.com>
On Wed, Mar 25, 2026 at 12:33:12PM -0400, Yury Norov wrote:
> Now that we've got the same knob selecting inline vs outline copy_to_user()
> and copy_from_user(), we can simplify the corresponding logic in the
> uaccess.h.
>
> Signed-off-by: Yury Norov <ynorov@nvidia.com>
Both patches are:
Tested-by: Alice Ryhl <aliceryhl@google.com>
But I can't help but think if it wouldn't be slightly better to split up
the first patch in a targeted Fixes: path that just fixes the FROM/TO
mixup, and a follow-up non-fix that actually deduplicates the two
ifdefs.
> @@ -217,11 +219,8 @@ copy_from_user(void *to, const void __user *from, unsigned long n)
> {
> if (!check_copy_size(to, n, false))
> return n;
> -#ifdef INLINE_COPY_USER
> - return _inline_copy_from_user(to, from, n);
> -#else
> +
> return _copy_from_user(to, from, n);
> -#endif
Spurious extra empty line here?
Alice
next prev parent reply other threads:[~2026-03-26 8:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:33 [PATCH 0/2] uaccess: unify inline vs outline copy_{from,to}_user() selection Yury Norov
2026-03-25 16:33 ` [PATCH 1/2] " Yury Norov
2026-03-26 13:44 ` Christophe Leroy (CS GROUP)
2026-03-26 17:29 ` Yury Norov
2026-03-26 17:49 ` Christophe Leroy (CS GROUP)
2026-03-25 16:33 ` [PATCH 2/2] uaccess: minimize INLINE_COPY_USER-related ifdefery Yury Norov
2026-03-26 8:00 ` Alice Ryhl [this message]
2026-03-26 14:15 ` Christophe Leroy (CS GROUP)
2026-03-25 23:31 ` [PATCH 0/2] uaccess: unify inline vs outline copy_{from,to}_user() selection Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acTnrMeMIfqNvObZ@google.com \
--to=aliceryhl@google.com \
--cc=akpm@linux-foundation.org \
--cc=chleroy@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=tglx@kernel.org \
--cc=vmalik@redhat.com \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox