From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF2FE34D93B for ; Thu, 26 Mar 2026 08:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774514370; cv=none; b=U3joBDDzNiAtIH1VNZ/P/m0IeL88jXu3nhEFwCgPAe1LvTU3fAZ5Om8OoU7gOxpiDijCb+5FKHVjEOq6wqrRnf/LkHJ36oPopLPLkaM4sv1lz8yXLQucM8tR97LDA/PjcEuLZVrzauSeJaS+OMZ+bgUY2B0gTp0aaKCG6vdIsBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774514370; c=relaxed/simple; bh=BdnnQQqHYCujt7wgN+UgU4N+94sN5A5HwIsOvnCdc14=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o2nWBnriWKmw9xCtT5y7D2hd4k9EgFfb6Nffg6uLgWZ8TX6ChhbiNjXN5XPPK1RvaH1DAkc/XBBo19doXevHHT1iqtApBtbuO8AjPJlaWx/n63P2ANs3ItFGfX3CO3kFJbtMlY5V7YYI2HsTuYQm1DKOBvcGxEjkGG2Lb0S6imA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V5gF0Oo2; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V5gF0Oo2" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-486fb112c09so6771755e9.1 for ; Thu, 26 Mar 2026 01:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774514367; x=1775119167; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nBHIKjGZDQYwqktWgoWqWbyzVzuD2Kcb8EQgt8K2gjs=; b=V5gF0Oo2D2mgoMvqth2ZgcHDR01KgPPYG08q+68ufA1JZIdDMcEvIVrN6poZ8/17qP wzbplDe953g0JRxEbwVretoW2IqZU1ctVBspDRI1/NWxfUgUCTAaoJjju90NsESKAXNk vcA1tI+oIIfPs7oDohC9/NhBKFyR/WR+11k7F9OK+5GZC/8DVS/NPmyLvm0Gbz86PygY EGTZnGU92EQshrwINIu4xk1nXJDOfVsek6nhFC2licdqVaMhOJQbGluKQrzLz7m3tOMM QspbL+PX2tHVjzdCBEFxoU3c0sWcqyUETMyjuoFvAGuEQwaigdPscoaGpj/RNMhTZMcv mKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774514367; x=1775119167; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nBHIKjGZDQYwqktWgoWqWbyzVzuD2Kcb8EQgt8K2gjs=; b=nKlcKDKVTnmg2Kl0+2Opk7zWC51cu+mYJGgLwNGqlXzd1CGNRRFCAk9hqXfECwCurh OEQlJNqBP3d9MT3Swv0piXgNsxltyAnI25jbZJuHE/djcJ68nHzObFfTAtqjCj0fYEet MiIsW1Vd4s8znz2gbmehHrdtxTBczAZRvY2DK3zriXsVb7PadXC6jV9LjxpMbSl4h+hw WMfjdw+CQKVpVC6bd/eErT+SZrlGed9nCrdKnSbcbqfJSEYTqs8PLJ59JiWmPgGAZEM5 bS7Q3mewByxNiuLkJIPk7z/x7KpMhAl5qRieBPpzeOmpKwkdnnemirQQmbGbI7SOTuu8 E+/A== X-Forwarded-Encrypted: i=1; AJvYcCWnu8eIRrtjpyVKDudroBfKHVF/RxBWhUk/qzYPY1E0KWfAmwz9SBUc9lJw/cWCQMCRXcG6ohvh78lC96E=@vger.kernel.org X-Gm-Message-State: AOJu0YztL3SZb4O8xQdQD2mNAY9ZDXOiUBxXBlSkaT9xSqk+zQu2Rh5o bJmEIQYdtex77OpgSwMktiYBtuaVgDK5aRoRdTqWxEIjc9pa2Xe1N68N1bUsqUZm1ps= X-Gm-Gg: ATEYQzzxc+vgoKF3FXFJDS6yv1f/PRGQhvwbj3eZp48eo5cTni1BeLyR6hBDAkF4fmw XAnHAFoBTYO/9QK3rJYQiIDRwC257sIHAwMaMhFRSRTr7oxWyv7+5GOogYxdz0V7gXD+meiitxu 94+oFKiePBXpJT1WeXoKkRo9MEtUvTTtaglNkJZe8aNV12LiLc6eNfTWtaj5uNoXMh3KNRajn+F HzHHFLvhvDMY69pAgcVb/3/UqoyevmPzCmf6GRTB5jvTAla34qjubz/vaIYnnwfln5xNulyENE+ ++lA1G53qD9FPFCnThWN9l12QaJ8ltXZpsJb+AMiZ/1t3COW7ybUQK9naThY4GeTa2bllFrArub bDjIXJVdGzXCMOfP7fYmEHUGU9TLkHd2p3Dwwmcxg+8vw++ufFDFas+AQ+FVWCNJ67g63AKXFTJ OTS0KOh7rP+syoAYEdsgJIO33awzb+ X-Received: by 2002:a05:600c:a409:b0:485:439b:683f with SMTP id 5b1f17b1804b1-48716042aaamr75459225e9.20.1774514366979; Thu, 26 Mar 2026 01:39:26 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4872090bbcbsm20170685e9.4.2026.03.26.01.39.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:39:26 -0700 (PDT) Date: Thu, 26 Mar 2026 11:39:22 +0300 From: Dan Carpenter To: Omer El Idrissi Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: Re: [PATCH v3 0/4] clean up error handling Message-ID: References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081627.5841-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326081627.5841-1-omer.e.idrissi@gmail.com> Sorry, I'm going to ask that you send these one last time. It should just be 2 patches. patch 1 stays the same, and patches 2, 3 and 4 get squashed into the same patch. The thing is that right now we're changing sdio_init() and then cleaning up the callers. We should change it and clean up the callers all in one go. One thing per patch means "One complete thing" not "half a thing per patch". It makes it easier to review when it's done in one go, because otherwise, when I'm reviewing patch 2, I have to check all the callers anyway. regards, dan carpenter