From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 615EC3AD532 for ; Thu, 26 Mar 2026 08:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774514571; cv=none; b=tAGMzb04v4bgTvqcLJ4xLG9juk23YtwCwELswsDheXHaiHkM7DgrHBOJDzKEMCi+Ns0TUy5rqBq2eqPrOpg+IY7vO7nJlYOyWAQEP+PrM1AB8v5OiRWe+i26d93JW34/QTFoD0yTFQ1h+/i+yc8ZkslpmIWcKjq3VDcZTarfyZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774514571; c=relaxed/simple; bh=CkZiuef7XlPAD4Dco5E1ISxh3u2KQ83CXO/blyXVsuA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lriVJ31GjsuoLy7QTq1OvwaAJ6zWt9acvgvO9hk/7a3dZcMG+NQbxfr0dxRl18tQTFghzfUX6u94dH+SBCE3zM0cZq3wdq3ddWCd357hRuPIv+KOYJ3H3NNl5Fo1kS7jSe12cLD/1ZfrEgxyHQ2ss5v7Q+NkKGiKv7iVtXkfNNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Z3RAWKXN; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z3RAWKXN" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43b88b7ca76so505188f8f.3 for ; Thu, 26 Mar 2026 01:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774514566; x=1775119366; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5KrwW45sM5ZLNWZHKd/Qx/J976PKoiXqfS4hEKQAF+k=; b=Z3RAWKXNTB/OTE9xgHfvtt3Rl6Zzm6HWpALsinUGAKTFUauMHP49uf8iKWDu/jTWD6 Lqf9ySDPA3Ik8HMvgjJZ73/BLyado4H/Ignb2dOgYRBy0tOn60lcDrivGJVHV6QO9Sla u3mwai2BSeCl5tffr25va2LGv1aS1wZNdZU+q3EaqMZ1o8e9L6vzhbLfLlP3BAi/e1Su UHGHMAH1Hq7PXsdaeAhsHy3TPAwg8jSFt7VnzND7jObhMaK44iRuVQXDhtjBzYVsYFYr jXgZk1PT550DVKCPk5BlwhB9fCCN+a/PF9BVjmp3VYqOjhUugQZ0ep79Rro+0WM8FZTJ /42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774514566; x=1775119366; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5KrwW45sM5ZLNWZHKd/Qx/J976PKoiXqfS4hEKQAF+k=; b=MDp8aTt7YaUWNBNe7m4OyVYQXMRR/p7yeKCm1RCwfGh7vK7NovuQCQacsSEeUuCtMj ZFIlgsI9ecJbmbJjfvkjagisT4TOuyZNYaOX0dMLQV1YOkxt67FihIRKuejKTCVkYJFl b2TuEMeHAioyKwQPHZQ/hIFRhZ85siPLLMAH6JCx32a8WDElqUG8qHE1psvBe+Wdk6nE WfbXd4+VsQ5c37O0zxfzbmdH6POavCDn6R4TRZknrO1ifhW3gv4KcS1/6sldx6C2Nkpq yqPWDoi1mZ5lg188ms4Wpifts5q5fzGuePo82scaatW1wb1hfpIFE7y73jsASFaO4oCE 3VNQ== X-Forwarded-Encrypted: i=1; AJvYcCWQQ1m0f+UnEShDKyErRGZWNSoMU/eEmPyEK+fsSkmYFnWXM05maOFTeWjG9QIvBW/YdqQTgbN++z8ff4s=@vger.kernel.org X-Gm-Message-State: AOJu0YzbiiH508+YHR4ANStvVZ3G9MyovTzfFFTRf1/m9DzQ7bmTegH2 JvP0JnfmA02ABUcruM3taqBPntpmqS08RzuCOAfztU/PAH4JRawuTTb/Spbm1Frtzb8= X-Gm-Gg: ATEYQzy8nUp+R7r6pT7vwhB7UNZgrB/Bp4gv0OjN3ySyTIuUPyZ75eI37l2uvod9um/ 2y65hbh3EJtaFou73ZKzEujChYQ4/oFEMojmlyyoq5UNHsB6PztAozkDX5urfOnxNilpp/cdDum RZb/EKoDEEu9hcXWJti/ArwJv+3MxAnz2fOGvfg1Tyr+AsrW33KU/pV6UnVu+MOQIxmUXj+L+Np Das3hMJ9bS297E2vpnrQyRYtUBmMYCK8E+KuM04ISyLnGLaQAt5Zbl3yGFCEsqC4d7V6qZP27JL g7dRjok1XASnBJ7vKtwjf4Eu1/DM72vgzfqCs54Ec6txmAL4CJIvDkg9Z7owqJeiTJ+SOzw0c2p HxC9YsPEGka3KSJ2qkLOeoJJjWdHlp06QrkqdV8cpWcRd2zn158vyqNN5nNxG/HquyBotgdzyoE 2c8oD5/N4TnPhBpjQlM8O9VmyZ8cas X-Received: by 2002:a05:6000:2385:b0:43b:4396:674f with SMTP id ffacd0b85a97d-43b88a0d0b0mr10208058f8f.55.1774514566156; Thu, 26 Mar 2026 01:42:46 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919e7372sm7729788f8f.34.2026.03.26.01.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:42:45 -0700 (PDT) Date: Thu, 26 Mar 2026 11:42:37 +0300 From: Dan Carpenter To: Michal Wilczynski Cc: drew@pdp7.com, guoren@kernel.org, wefu@redhat.com, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v1] firmware: thead: Fix buffer overflow and use standard endian macros Message-ID: References: <20250403131051.1097423-1-m.wilczynski@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250403131051.1097423-1-m.wilczynski@samsung.com> On Thu, Apr 03, 2025 at 03:10:51PM +0200, Michal Wilczynski wrote: > Addresses two issues in the TH1520 AON firmware protocol driver: > > 1. Fix a potential buffer overflow where the code used unsafe pointer > arithmetic to access the 'mode' field through the 'resource' pointer > with an offset. This was flagged by Smatch static checker as: > "buffer overflow 'data' 2 <= 3" > > 2. Replace custom RPC_SET_BE* and RPC_GET_BE* macros with standard > kernel endianness conversion macros (cpu_to_be16, etc.) for better > portability and maintainability. > > The functionality was re-tested with the GPU power-up sequence, > confirming the GPU powers up correctly and the driver probes > successfully. > > [ 12.702370] powervr ffef400000.gpu: [drm] loaded firmware > powervr/rogue_36.52.104.182_v1.fw > [ 12.711043] powervr ffef400000.gpu: [drm] FW version v1.0 (build > 6645434 OS) > [ 12.719787] [drm] Initialized powervr 1.0.0 for ffef400000.gpu on > minor 0 > > Fixes: e4b3cbd840e5 ("firmware: thead: Add AON firmware protocol driver") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/17a0ccce-060b-4b9d-a3c4-8d5d5823b1c9@stanley.mountain/ > Signed-off-by: Michal Wilczynski > --- This is nice. Reviewed-by: Dan Carpenter regards, dan carpenter