From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FCFA334C28 for ; Thu, 26 Mar 2026 09:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774519200; cv=none; b=hRTI2NVF5BvgtmHmGHJ1P3ElBTuWJLKEcJQaM9oK+nm0nIoEfzdGJEVX0nhRLp63oZjc3gCkeD1a4VCNtYMOuTBu967U9dP0LM6C8/MbBsE6uzXbJ9qykO+kKUHf6RUbfMFJ1GXjiXwYyoxuufZY6ga5aVWMGulCiYIDO88kFuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774519200; c=relaxed/simple; bh=Pj5h/oDu8ID7Dw6VRhEPZstzuIHIZyMvA7LInc4eovU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hm6aF0URNF5ZNzfj4IiVpvok5PdCCWdPncjbtxufxfw08NC8y2jk97D4Odh+OgvpnYwtHe6nlSiApLBC39CI+iJ9s5DC7Zws7OGGfYPmq7tIZJmdtymjxeJBX8YM2dgtVS1xxG6/tzN3RZBQoqMmFBx0MgQ1aqiFEzo7zv6/oZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LLvL6NmS; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LLvL6NmS" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so7273815e9.0 for ; Thu, 26 Mar 2026 02:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774519197; x=1775123997; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fXbM9LKwktfrVnpq6ZaZDntXsBEfIV9FPgOfN8uZ+I4=; b=LLvL6NmS8PEw6wcT6mWRoti3+FNW6zP33P0BsNAgHYAzrdt+uIRhdncmqj4IwOkRVN F7xicPYu8J/zuVbulaOJvT1v8nh/grS1/LUxWTb6rWnZI7G6XqxVL/ySe7cQLDW0AKwS ouUhqVMvMns0SAM36aCOy8iDVXyP+dt8h5/uCabLmY3Xn0krMZvWlszc/5HocPTY+43z T/Xtx85R71MrY8FKUlJTj+P5LO1oased/O/uZYKGTs88exp6B8mwBp/UuBhHi+/DrMPb uliAyRbymAQrCKFNRr8NUYkCG/biy26eFJN6K7rGVJQ526I5NToEvHHRWw2WqkR6k2Da DqfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774519197; x=1775123997; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fXbM9LKwktfrVnpq6ZaZDntXsBEfIV9FPgOfN8uZ+I4=; b=iy05MqkB2fPAMBtsVMo+rlieedk+zD4bdsMC2qHn4YgXmYYU5967vWJuQhYRpMPPuk 24H6vECB1Pp0z98vN+ru+Eqtz5R4B6iuhOI5eh62RirfzxMepc17wB8tSAlrIwIebJOK TE2w+QDBiOrHYvPyfUP30O/Nq+G5N2Veqz4SppCK1q5BCw6k2UexB8j8GqZkdJLVco8/ RepGCHLuT8531lcg4M8BIOtAZF6ut0j577ZQoIaNalaZDT/n82sTNjS/jDaE7sA3YdK0 mtZ4TaE9cClpPe2csCj+Lo1nRv1GAYE2ZhPVM4mDnvQQ4eJ7Ics7WpUsDxUglGRpE55Y q9eg== X-Forwarded-Encrypted: i=1; AJvYcCWX2HYII38CJ2EWcybBHvp6CQBj9Zo+oXlrMU3rXGsRoSZGtMdsNNqcofJYxQPXJTWV3M7N5D4t1aeSlgQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzWj+d6FzIouZL3JbaoTYslJGY7wTb+PD7ktIbSJ+cB/snDr0kD YDmW0mJrcQL3SZjAHaKIaQtLkF6zKm/YEqnUZqPBlrAoqamhwb16VPrwuDLS7Ta51u0= X-Gm-Gg: ATEYQzwUd/QFvWdVHuBXZEnk3fZzBBkhlnisICcghmqAyuSEN4BUGzR/PE3PhqlQfWT vUsmVpywkvp244D6IPJEB6DCvSTQn0d1opo87LCOK6t6KuQCDgf9CaDJWYsjIO3eBMUJ5GvESb/ gojK0xKuZewx8RLvCOZpy/bMyT39KmzeimdGOVP897jdZ0i3OI6lmXlgK27fpRyB5Ea1WADh13F IgvP0Ev9xDeiLuWCHbFEhwxfln2OhbvzOiBSDQhsBdop7rt8M6d00LEzkPJDJijLVS1+PieK44g 9sggArO+mBqyKlwSdxxUef2UQAfCw3N0Hly5Cczp3oYdccogcNsMUUlUYvMINqEu3Z0giXfmg7m mZ78QJqh7Ra2xzfl+b0F3JpcGVUp5RPsuN4FYz85YTAhXKdomKFqkJn/tBWfTWh+JEJY1XhsAZZ 2mWavLjfh5B61syzWuoPAp2+Qp/dR0 X-Received: by 2002:a05:600c:a112:b0:485:5c6e:8a38 with SMTP id 5b1f17b1804b1-487160429dbmr83472295e9.17.1774519197406; Thu, 26 Mar 2026 02:59:57 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c6b4d0sm21168265e9.3.2026.03.26.02.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 02:59:56 -0700 (PDT) Date: Thu, 26 Mar 2026 12:59:39 +0300 From: Dan Carpenter To: Omer El Idrissi Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/2] clean up error handling Message-ID: References: <20260326093607.13011-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326093607.13011-1-omer.e.idrissi@gmail.com> On Thu, Mar 26, 2026 at 10:36:05AM +0100, Omer El Idrissi wrote: > This series lets sdio_init() propagate standard kernel error codes > instead of returning _SUCCESS/_FAIL. There are two callers for this > function. rtw_resume_process_normal() already returns negative values > but the caller doesn't check for errors so changing this doesn't > affect anything. sdio_dvobj_init() returns NULL on > error so leave that as-is. > > Signed-off-by: Omer El Idrissi > --- Great! Thanks. Reviewed-by: Dan Carpenter regards, dan carpenter