public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlos Llamas <cmllamas@google.com>
To: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
Cc: linux-kernel@vger.kernel.org, aliceryhl@google.com,
	gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
	christian@brauner.io
Subject: Re: [PATCH] rust_binder: Downgrade startup warning to info
Date: Thu, 26 Mar 2026 22:52:08 +0000	[thread overview]
Message-ID: <acW4mAs2LYa05FIv@google.com> (raw)
In-Reply-To: <cd555041-46fc-42b8-84a8-18112fd2f540@gmail.com>

On Thu, Mar 26, 2026 at 07:06:47PM -0300, Pedro Montes Alcalde wrote:
> The "Loaded Rust Binder." message is logged during normal
> initialization and does not indicate an error/warning condition.
> 
> Logging it as a warning creates unnecessary noise and may
> mislead developers when inspecting logs. Log it as info instead

Yeap, I agree.

> 
> Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> ---
>  drivers/android/binder/rust_binder_main.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder/rust_binder_main.rs
> b/drivers/android/binder/rust_binder_main.rs
> index aa5f2a75adb4..3907291a33c9 100644
> --- a/drivers/android/binder/rust_binder_main.rs
> +++ b/drivers/android/binder/rust_binder_main.rs
> @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) ->
> Result<Self> {
>          // SAFETY: The module initializer never runs twice, so we only call
> this once.
>          unsafe { crate::context::CONTEXTS.init() };
> 
> -        pr_warn!("Loaded Rust Binder.");
> +        pr_info!("Loaded Rust Binder.");
> 
>          BINDER_SHRINKER.register(c"android-binder")?;
> 
> -- 
> 2.53.0
> 
> 

The change seems fine but there is somthing off with the formatting of
you patch. It has some odd NBSP chars and some lines are wrapped at 75
chars when they shouldn't have. Looks like maybe a copy-paste thing?

--
Carlos Llamas

  reply	other threads:[~2026-03-26 22:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 22:06 [PATCH] rust_binder: Downgrade startup warning to info Pedro Montes Alcalde
2026-03-26 22:52 ` Carlos Llamas [this message]
2026-03-26 23:07 ` [PATCH v2] " Carlos Llamas
2026-03-27  6:24   ` Greg KH
2026-03-27  9:34     ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acW4mAs2LYa05FIv@google.com \
    --to=cmllamas@google.com \
    --cc=aliceryhl@google.com \
    --cc=arve@android.com \
    --cc=christian@brauner.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pedro.montes.alcalde@gmail.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox