From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28D9031B837 for ; Thu, 26 Mar 2026 22:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774565536; cv=none; b=O+TrX7reJJw+sX+WN8/x25m9C35+0vgYmQduorHRUIn0Qd4mEFsZVcRsWQQuwVkum9GmKE5+Yq9PK3EDJycLRjHK0UdYXA+Civ2vWCQph2q010ehAXcFrlywy6/Wc9UFEbMGxxKH5yrxUXo/l9+EHLhj9qI4lFI9ZrjwDwMYx08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774565536; c=relaxed/simple; bh=8UN+jtXIy0fQhobIQf4uuZF2xefxlmg/Aqtz+/cFp2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IXqboUpXcaZUki3XsUkKV6JZcjV6FG6P3N8S+KZN58BrvtlFyq/WfbVh3MQmQiM+3GPCBrdjoI0S3Z9bnDmfndrQ8Gj+RBaiUtxyMca9fclfu4EhEtlGm3nq6PpMUTiapL//YAecc8pjN7aHAktfkaLgKJzjDteAhxnvyYMdNdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Uslc9bJW; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Uslc9bJW" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b0b260d309so14825ad.1 for ; Thu, 26 Mar 2026 15:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774565534; x=1775170334; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=T75NF4PXqgESMdB00yF6AZJCh9+7a3l4MHbvO55W2xA=; b=Uslc9bJWcYOZDm2pA2Tr3DLYyN6KpYB9myaXdqJCM9WkNKcRVxBYxunVMhoutTLgWw 3zKQHDndHy1GYEY6MeIGAALs8Ii2HcXCE7dEV3w65w9vY/t0PsQxJQCw+vmsYCqMp0Hv H9AfqK33l3glsDVdicuvCrQ6Irks+ov+9Nm1GidQcI1bfqFXFl6bpJx82ZZWEU85t40A /FmVjVN1wFfq9FCVwpi8fFpGQffdbLN04Dz92fe/nQyx+VHuQbSxka+9BhtITL8EHPj3 px2ejsQJmTkTqZOTcuRny4Jgho+Jc48Whg0cOLvyqAv+wlny39n1y/T98veCWHn0IWgF BGLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774565534; x=1775170334; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T75NF4PXqgESMdB00yF6AZJCh9+7a3l4MHbvO55W2xA=; b=oczMz2xNmC72EDsJtqYgZwI+9Cjpuz+mzYp+qUUVxQ3Z5zYejszS/sedDZ8d3rIT6W VOC8YizWeAkKIvRJI/rquPxrOK3o4uuKFhPvmgzpK9R2w6Qc94fxRNa0xCyKUFVXTdxs fq6YPTPwVxSSdSYk0Xk8UU+f7m8KlOa30a2VTMUa3XWibTA4SdR5t/VWEDYxTbYdRjvh gIEf4lf2x6+edZzxue7HLrhyxrOPV14bTYJTYzCQlFAyxIGaUn8XGlGH1TQqIu0JXUvV /II34SGSpHNtUxqajmhhjAKj7sfN9qNcD3Fz/wJuDk3qDibbGq0ZhVEoFWWp0vkFa99b 0zww== X-Gm-Message-State: AOJu0YxwBVPmkAVuTLNY3WfMy5paZyigopj7TkLOQVBvlumHMsY1Ji2Z XKDcCy1jtX0Fi+rndhATC9T8meKGkR33SePdADoVinUGuC7f3u4uxaXQqQuESfzxcg== X-Gm-Gg: ATEYQzz+7uykWvJsRQFSyPxOhpZVr+YM5AB9DSrJYnSIChAN1A+axR64bOQTIhq2Cta 3nHGUm95Sy9tgOgn2XbJ2dru3hG+yWBuI+sV7eOZiGo+A5nzHg3owSzWZYDQwolnyebvKQDXZaP gKoQyo9iQ7tsfMmJEG0tn7s0Qg8lNMxj15tdlsPbQvwgC8SKu4lZhaP0uBtdbLYfdEFbNi9Sghd hKw9r/SIaw1mwAhY+hpkF/LdlQli2J/4dfKnMAs8E+bQxWgq4OP/9u+IyuUKtZ2oYp1N6ZLJ6y+ DHqq6KLqc392W74QxZSd/DbYQgeP8F/fAmJeMnvHF1t0p9/+d0rxxyBdHy/U4coXQSaBoZclwfL PygPfZayFiPvyPip5DGxF2BJHxbeUcdgftAes1TWeFzu7BapnP2pVq8Q6XYHZJaRty+wtrI9fEP MEhLQ2csEHaHRtoUrpMtKBK6Ww0l8ZJhgTzAcz1BlgZMa73ZzYdq4kymh6N/IbKw== X-Received: by 2002:a17:902:e74e:b0:2ae:80a3:98a9 with SMTP id d9443c01a7336-2b0cd328c54mr639405ad.11.1774565533884; Thu, 26 Mar 2026 15:52:13 -0700 (PDT) Received: from google.com (154.52.125.34.bc.googleusercontent.com. [34.125.52.154]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c7d216a0esm3648157b3a.17.2026.03.26.15.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 15:52:12 -0700 (PDT) Date: Thu, 26 Mar 2026 22:52:08 +0000 From: Carlos Llamas To: Pedro Montes Alcalde Cc: linux-kernel@vger.kernel.org, aliceryhl@google.com, gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, christian@brauner.io Subject: Re: [PATCH] rust_binder: Downgrade startup warning to info Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 26, 2026 at 07:06:47PM -0300, Pedro Montes Alcalde wrote: > The "Loaded Rust Binder." message is logged during normal > initialization and does not indicate an error/warning condition. > > Logging it as a warning creates unnecessary noise and may > mislead developers when inspecting logs. Log it as info instead Yeap, I agree. > > Signed-off-by: Pedro Montes Alcalde > --- >  drivers/android/binder/rust_binder_main.rs | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/android/binder/rust_binder_main.rs > b/drivers/android/binder/rust_binder_main.rs > index aa5f2a75adb4..3907291a33c9 100644 > --- a/drivers/android/binder/rust_binder_main.rs > +++ b/drivers/android/binder/rust_binder_main.rs > @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> > Result { >          // SAFETY: The module initializer never runs twice, so we only call > this once. >          unsafe { crate::context::CONTEXTS.init() }; > > -        pr_warn!("Loaded Rust Binder."); > +        pr_info!("Loaded Rust Binder."); > >          BINDER_SHRINKER.register(c"android-binder")?; > > -- > 2.53.0 > > The change seems fine but there is somthing off with the formatting of you patch. It has some odd NBSP chars and some lines are wrapped at 75 chars when they shouldn't have. Looks like maybe a copy-paste thing? -- Carlos Llamas