From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 513742F28EA for ; Thu, 26 Mar 2026 22:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774562699; cv=none; b=nf6gNRyEj4FJHamma5Csp6ZAecmVDvWf/QgDPkDUIJ8UeGKW1AAD2oUAEDaaFLSFBrG1EacNlk1YDHeeFbkRJhD2xE1DOTLhx8FJu3Dz9xEU0zqWZd+dWWsvCaGfyQWDn7eqh4cppI4LWcY821S7WwEkHnRvp4TlQyA7ONUd0vY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774562699; c=relaxed/simple; bh=GBY4i+7n97Blol+zZDLhEwkVkvlwAP0FnHiMpSo+3uE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pCVRar8CxxiPRL6TJW6/Fr330WQnwc/vg8c2dBfLiQRIyrC/Ost3gsSGcPnwLu/LbrzIp27fok0tFdPUBxLjQb391n1Y11NyViPyObzJgfYyEw0MgC84cv3OzLi5VLkbOk/89OQdvhjikt4xySB5ms/EX7Gg8ej9vgGA5wC6J8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GDhSiVDp; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GDhSiVDp" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-50b2b2aa276so13222441cf.3 for ; Thu, 26 Mar 2026 15:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774562697; x=1775167497; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6RrKHhCFI1+fxT243Y633zvQyWdh9GMd1zgxuWpoC3M=; b=GDhSiVDpiYWK1JY6gSIOea8QanGOiHJaeDQhXmLuNTljg9Q5gO5xe8y+uHogeo8lD8 mEvdQ+0TIAaGW+gZVm8dokt+eMNaE7zPU2CRqTeA8+6tXypZkeemywyOgbizyB3U2Z6d m1NFUuFVmGgMNLtEtyi86K9eaebECvXL4cBLW8J8YlEtPflpEZ0BCDmQwr48OGxVU/Hy 77Nlc7zCF2cgy2jzWR+RBnf18ye1NRn3m2SG6XaAOKpXJgxuZQ8JGzRoZvXTNeEV1MSX ty3i6GDNhRK8TuKIUGX3+Ng+h2BclM/0yZKf1Rvj1UOZ3JNZpu+XMb+esgEVr5/NT1Ud QIRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774562697; x=1775167497; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6RrKHhCFI1+fxT243Y633zvQyWdh9GMd1zgxuWpoC3M=; b=F/C4G/om+oB+o/0dQpBnciH+aar9MdBpasadMyBYe1fBPRkY9yg/6PocawEfR4ZSxM I+upCaBvDM/woPaU1e+pAo/M/HiPTmLIRAUz0cOCMo3wWrStko7etr7+OLTCyrb20S/5 NLbBll44JEG3gIG88tAIyTpJR8hJMVFOa0POsrOaKwl1yZG4b6INU7p6zDwLGegBspFJ GU8DFnRYC3o6V4eNcm9L6H7xG8WnD62mqHhsfZNIXmtnoE734JAKe/M41XIsaV31aGyc mOrJ8STNWhORPOn4NoygdfSoniO5D5FbWUjjLlHowf7d5PKuaZkAgKBe3XZ5QSW+ybyD pnTA== X-Forwarded-Encrypted: i=1; AJvYcCX8PQawayM0njAJbB6lDicHH0tdJSB9zOD49pfwIvraeP2mny0hcCqThd0tIEpE49iM61WgQ4fU3//9WQQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzbSo54yCdUrMhJlh02qUJwGkCQyvHnVlV+tmYznb6svJsgk7LH RixkALVPQEt8j8YVBQIkSIzhuh6rzRtfDaXzr1Ommuyl+MRHh/jWnHHW X-Gm-Gg: ATEYQzzsIwPIDq0vI2kDIV3iisYPqreJtjhrijMEeBUdtXiDOIkYi4ocTysS2quexV8 UhAWpD5GUzUHQ2lKFJtq/IDBk3IfFSTiCIGRb2PqncCmBsnTaPJ35aDfv4gUxd5vzjzsujamP1n 7w8IHOdaSD8WrHKp1CljnQViqr5rTyzycQ27ZZteyYGdhjX82kLOzb3K9K+Hc57e9b0BF+3zDiX lZpHdsLiCN2/DB2ULc8KE0pBYSuGgKzHEgHwCWMzpJeo2MSTknnUB7MkHH8H7On0jpgCgzEDc9u SqEq+UDjxQnKCTBZTiuubqFbq4E5AAGDWEAKpwPED/5ouTs7//73RBfVo8XWwNWvUZblxqAWThi 2PVIq5JGgHntCe6Zbe/Am80p7+xF2YzgRX3CtiipcT2y4np0PbFFmscGk3w3/tUqOUNdNhrgEzo WD3h8EkI7VKYJqy15DqyQMwaBlQ52eQqgF9u2vciz12KNggCNWhutV92XhsiPBirH+SVcEmwFKa gyCR8EzMw3VniLkb7cmQZQVAMvc9o7V5Tv8nEByDEHLhQU1dxSz X-Received: by 2002:a05:622a:99b:b0:509:34df:4f03 with SMTP id d75a77b69052e-50ba380a874mr3457191cf.15.1774562697200; Thu, 26 Mar 2026 15:04:57 -0700 (PDT) Received: from TARS ([207.219.48.239]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89cd5aaf0cesm36120126d6.47.2026.03.26.15.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 15:04:56 -0700 (PDT) Date: Thu, 26 Mar 2026 18:04:53 -0400 From: Ammar Mustafa To: Jonathan Cameron Cc: Andy Shevchenko , Alisa-Dariana Roman , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Jonathan Corbet , Shuah Khan , linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Docs: iio: ad7191 Correct clock configuration Message-ID: References: <20260322121314.0143bda3@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260322121314.0143bda3@jic23-huawei> On Sun, Mar 22, 2026 at 12:13:14PM +0000, Jonathan Cameron wrote: > On Sat, 28 Feb 2026 12:50:46 +0200 > Andy Shevchenko wrote: > > > On Fri, Feb 27, 2026 at 02:08:33PM -0500, Ammar Mustafa wrote: > > > Correct the ad7191 documentation to match the datasheet: > > > - Fix inverted CLKSEL pin logic: device uses external clock when pin is > > > inactive, and internal CMOS/crystal when high. > > > > high --> active > > > > Thanks, this part looks good in the below documentation update. > > > > > - Correct CMOS-compatible clock pin from MCLK2 to MCLK1. > > > > I haven't checked driver yet, but is it only for a single component? > > Can you double check that _all_ supported by the driver have the same > > in their datasheet(s)? > > > > ... > > Hi Ammar, > > Just a quick note to say I'm going to mark this one in patchwork > as needing a new version given Andy's questions have been here a while. > > Thanks, > > Jonathan > > > > > > +- When CLKSEL pin is ACTIVE: Uses internal 4.92MHz clock (no clock property > > > needed) > > > -- When CLKSEL pin is tied HIGH: Requires external clock source > > > +- When CLKSEL pin is INACTIVE: Requires external clock source > > > - Can be a crystal between MCLK1 and MCLK2 pins > > > - - Or a CMOS-compatible clock driving MCLK2 pin > > > + - Or a CMOS-compatible clock driving MCLK1 pin and MCLK2 left unconnected > > > - Must specify the "clocks" property in device tree when using external clock > > > Hi Jonathon, I replied to Andy's questionm not sure if I can attach it in mutt for you, but we found that this driver only supports the AD7191 so no other documentation needs to be updated or check for this issue. Let me know if I need to do anything else to have this patch merged. Thank you, Ammar Mustafa