From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4A7B40DFCD for ; Fri, 27 Mar 2026 09:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774604080; cv=none; b=MGJOYZmTSfHQ7voMlv+5zyf34WOAoGoZ/Y7nbOZYeVbfncZiPC3y/ZFLeJ5jXWGJtQlugG1MFtpe0Aol2kLd+kfYV7a/cYt18BRyKXgi0ve19fwz4Wb86CzwnYZMNdYgP7HM+GZRTF3P6cOJFF5owS/o0AkETIwml/U+qPhxiyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774604080; c=relaxed/simple; bh=tK+uUVaYh9WKNA8PuOK17Bsp2rCTqPY0taiy2pbDZ5M=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=b/9xrs8srTQci3jlvvAp4/EJZv4X4ucu8Y3X5vdqiy8FrShuzegPx1muurC0VU5wFWmCskXSORauSev8Y3uSDYI26v8rrd4yaG7D1YhkcmxFIUfMqyWfmvLAuo6obQQVz1/+jNZC6uv4Ovg1Casj+0xqDRvWkH1LgUYPGWCHFyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VlQTFqL4; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VlQTFqL4" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-486fa35b005so22061065e9.2 for ; Fri, 27 Mar 2026 02:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774604077; x=1775208877; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=H+lNpIwGKBjDr2Mpwc1CL2wAxjLcu2oHp0cFsQpmO4Y=; b=VlQTFqL4Q7uN/MASu2klyZuJI6J/FARzIpddfh1yfR2K+UKYAXtM7JLYYk3dlfTzQb VUlgMydgCa/BYIZ4fHSIwXDYCvPgqC/XnzzjU1iAh68KJmBU9FN2fo1/uCk26DBSDIUt YckdCP/btMwi5SM9tcddjc74/8+s6I+IgFBcbNZWJgfYMqFw2bFKqJDwF4k6CdfTUEHU C3Rzc2L+aTPQU8xrGTQyCC2xSLNsBjhKSvBCh7009Uc5WBXP1jAjqPVYzMh1GQO0RPKi QjZJu9YUDvh8SWJha+j6fmPPQZov6AhDCAypnE7kzOsoBmHzZrDaNZ2Kp8y1mSiRechM AK3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774604077; x=1775208877; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H+lNpIwGKBjDr2Mpwc1CL2wAxjLcu2oHp0cFsQpmO4Y=; b=kgFyCS0X/UOpuwzMF85s1GiKmfcOXFdn29R+jbQe/FirDaz7mt3wHr9XHGP1YAAxPj I0BRRYpdZwImB9aKauY9+MXhGTG2P6nPc47PCGH/fFo/nur0K2m8UPSpxYkEivyj2AYR tOk6kGc8rs3yEpt3bKP6MWMd8VCWx5UnqvOUI5ddWyMb2jWeadgqzL3+Co3s+exuzmZM ydi7AAw9rKs5rbC59caJmMCDzwbzns+lvlmkwmJaEppWtitkISgZ3wsmK5LWBdM4c+N1 wBaoZchr8wX74Gp7kIoS6TwfO10q1zI8NuSV6+pIYd9oRdtywrTBd/OMUbcZGZcKYmuB 63+g== X-Forwarded-Encrypted: i=1; AJvYcCWRJgyUz4GLlDSdzMPhO/AYRt4r+3xC7++nIplsPRwTyvj3wlJwEmDgk6idRnR4lh5oNFPcIXzZ2Lu4xsg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7gNPl7G/dgSg8V2wI2RUdRhu7ERK6bX6WA1WXZena7KdyUPns y3UD30WO5U6I1FhvS69Qso5amVQyHNYz9AjbRPganXvxsJf5z9TVcXyns+BLYVNnpTYksK6jdzv FSr3XAN20CBYMVFtqmQ== X-Received: from wmbbd20.prod.google.com ([2002:a05:600c:1f14:b0:485:385e:a8c1]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4744:b0:485:4278:2558 with SMTP id 5b1f17b1804b1-48727d5a313mr27534065e9.6.1774604077005; Fri, 27 Mar 2026 02:34:37 -0700 (PDT) Date: Fri, 27 Mar 2026 09:34:36 +0000 In-Reply-To: <2026032712-dimple-myself-24a7@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260326230713.3633842-1-cmllamas@google.com> <2026032712-dimple-myself-24a7@gregkh> Message-ID: Subject: Re: [PATCH v2] rust_binder: Downgrade startup warning to info From: Alice Ryhl To: Greg KH Cc: Carlos Llamas , pedro.montes.alcalde@gmail.com, arve@android.com, christian@brauner.io, linux-kernel@vger.kernel.org, tkjos@android.com, kernel-team@android.com Content-Type: text/plain; charset="utf-8" On Fri, Mar 27, 2026 at 07:24:35AM +0100, Greg KH wrote: > On Thu, Mar 26, 2026 at 11:07:12PM +0000, Carlos Llamas wrote: > > From: Pedro Montes Alcalde > > > > The "Loaded Rust Binder." message is logged during normal > > initialization and does not indicate an error/warning condition. > > > > Logging it as a warning creates unnecessary noise and may > > mislead developers when inspecting logs. Log it as info instead > > > > Signed-off-by: Pedro Montes Alcalde > > Acked-by: Carlos Llamas > > Signed-off-by: Carlos Llamas > > --- > > v2: fixed patch formatting, added tags. > > > > drivers/android/binder/rust_binder_main.rs | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs > > index aa5f2a75adb4..3907291a33c9 100644 > > --- a/drivers/android/binder/rust_binder_main.rs > > +++ b/drivers/android/binder/rust_binder_main.rs > > @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result { > > // SAFETY: The module initializer never runs twice, so we only call this once. > > unsafe { crate::context::CONTEXTS.init() }; > > > > - pr_warn!("Loaded Rust Binder."); > > + pr_info!("Loaded Rust Binder."); > > When drivers work properly, they are quiet, so why print anything out at > all here? Yeah let's just delete this. It's not needed anymore. Alice