* [PATCH] rust_binder: Downgrade startup warning to info
@ 2026-03-26 22:06 Pedro Montes Alcalde
2026-03-26 22:52 ` Carlos Llamas
2026-03-26 23:07 ` [PATCH v2] " Carlos Llamas
0 siblings, 2 replies; 5+ messages in thread
From: Pedro Montes Alcalde @ 2026-03-26 22:06 UTC (permalink / raw)
To: linux-kernel; +Cc: aliceryhl, gregkh, arve, tkjos, christian, cmllamas
The "Loaded Rust Binder." message is logged during normal
initialization and does not indicate an error/warning condition.
Logging it as a warning creates unnecessary noise and may
mislead developers when inspecting logs. Log it as info instead
Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
---
drivers/android/binder/rust_binder_main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder/rust_binder_main.rs
b/drivers/android/binder/rust_binder_main.rs
index aa5f2a75adb4..3907291a33c9 100644
--- a/drivers/android/binder/rust_binder_main.rs
+++ b/drivers/android/binder/rust_binder_main.rs
@@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) ->
Result<Self> {
// SAFETY: The module initializer never runs twice, so we only
call this once.
unsafe { crate::context::CONTEXTS.init() };
- pr_warn!("Loaded Rust Binder.");
+ pr_info!("Loaded Rust Binder.");
BINDER_SHRINKER.register(c"android-binder")?;
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rust_binder: Downgrade startup warning to info
2026-03-26 22:06 [PATCH] rust_binder: Downgrade startup warning to info Pedro Montes Alcalde
@ 2026-03-26 22:52 ` Carlos Llamas
2026-03-26 23:07 ` [PATCH v2] " Carlos Llamas
1 sibling, 0 replies; 5+ messages in thread
From: Carlos Llamas @ 2026-03-26 22:52 UTC (permalink / raw)
To: Pedro Montes Alcalde
Cc: linux-kernel, aliceryhl, gregkh, arve, tkjos, christian
On Thu, Mar 26, 2026 at 07:06:47PM -0300, Pedro Montes Alcalde wrote:
> The "Loaded Rust Binder." message is logged during normal
> initialization and does not indicate an error/warning condition.
>
> Logging it as a warning creates unnecessary noise and may
> mislead developers when inspecting logs. Log it as info instead
Yeap, I agree.
>
> Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> ---
> drivers/android/binder/rust_binder_main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder/rust_binder_main.rs
> b/drivers/android/binder/rust_binder_main.rs
> index aa5f2a75adb4..3907291a33c9 100644
> --- a/drivers/android/binder/rust_binder_main.rs
> +++ b/drivers/android/binder/rust_binder_main.rs
> @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) ->
> Result<Self> {
> // SAFETY: The module initializer never runs twice, so we only call
> this once.
> unsafe { crate::context::CONTEXTS.init() };
>
> - pr_warn!("Loaded Rust Binder.");
> + pr_info!("Loaded Rust Binder.");
>
> BINDER_SHRINKER.register(c"android-binder")?;
>
> --
> 2.53.0
>
>
The change seems fine but there is somthing off with the formatting of
you patch. It has some odd NBSP chars and some lines are wrapped at 75
chars when they shouldn't have. Looks like maybe a copy-paste thing?
--
Carlos Llamas
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] rust_binder: Downgrade startup warning to info
2026-03-26 22:06 [PATCH] rust_binder: Downgrade startup warning to info Pedro Montes Alcalde
2026-03-26 22:52 ` Carlos Llamas
@ 2026-03-26 23:07 ` Carlos Llamas
2026-03-27 6:24 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Carlos Llamas @ 2026-03-26 23:07 UTC (permalink / raw)
To: gregkh
Cc: pedro.montes.alcalde, aliceryhl, arve, christian, cmllamas,
linux-kernel, tkjos, kernel-team
From: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
The "Loaded Rust Binder." message is logged during normal
initialization and does not indicate an error/warning condition.
Logging it as a warning creates unnecessary noise and may
mislead developers when inspecting logs. Log it as info instead
Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
Acked-by: Carlos Llamas <cmllamas@google.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
v2: fixed patch formatting, added tags.
drivers/android/binder/rust_binder_main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
index aa5f2a75adb4..3907291a33c9 100644
--- a/drivers/android/binder/rust_binder_main.rs
+++ b/drivers/android/binder/rust_binder_main.rs
@@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
// SAFETY: The module initializer never runs twice, so we only call this once.
unsafe { crate::context::CONTEXTS.init() };
- pr_warn!("Loaded Rust Binder.");
+ pr_info!("Loaded Rust Binder.");
BINDER_SHRINKER.register(c"android-binder")?;
--
2.53.0.1018.g2bb0e51243-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] rust_binder: Downgrade startup warning to info
2026-03-26 23:07 ` [PATCH v2] " Carlos Llamas
@ 2026-03-27 6:24 ` Greg KH
2026-03-27 9:34 ` Alice Ryhl
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2026-03-27 6:24 UTC (permalink / raw)
To: Carlos Llamas
Cc: pedro.montes.alcalde, aliceryhl, arve, christian, linux-kernel,
tkjos, kernel-team
On Thu, Mar 26, 2026 at 11:07:12PM +0000, Carlos Llamas wrote:
> From: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
>
> The "Loaded Rust Binder." message is logged during normal
> initialization and does not indicate an error/warning condition.
>
> Logging it as a warning creates unnecessary noise and may
> mislead developers when inspecting logs. Log it as info instead
>
> Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> Acked-by: Carlos Llamas <cmllamas@google.com>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
> v2: fixed patch formatting, added tags.
>
> drivers/android/binder/rust_binder_main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
> index aa5f2a75adb4..3907291a33c9 100644
> --- a/drivers/android/binder/rust_binder_main.rs
> +++ b/drivers/android/binder/rust_binder_main.rs
> @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
> // SAFETY: The module initializer never runs twice, so we only call this once.
> unsafe { crate::context::CONTEXTS.init() };
>
> - pr_warn!("Loaded Rust Binder.");
> + pr_info!("Loaded Rust Binder.");
When drivers work properly, they are quiet, so why print anything out at
all here?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] rust_binder: Downgrade startup warning to info
2026-03-27 6:24 ` Greg KH
@ 2026-03-27 9:34 ` Alice Ryhl
0 siblings, 0 replies; 5+ messages in thread
From: Alice Ryhl @ 2026-03-27 9:34 UTC (permalink / raw)
To: Greg KH
Cc: Carlos Llamas, pedro.montes.alcalde, arve, christian,
linux-kernel, tkjos, kernel-team
On Fri, Mar 27, 2026 at 07:24:35AM +0100, Greg KH wrote:
> On Thu, Mar 26, 2026 at 11:07:12PM +0000, Carlos Llamas wrote:
> > From: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> >
> > The "Loaded Rust Binder." message is logged during normal
> > initialization and does not indicate an error/warning condition.
> >
> > Logging it as a warning creates unnecessary noise and may
> > mislead developers when inspecting logs. Log it as info instead
> >
> > Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> > Acked-by: Carlos Llamas <cmllamas@google.com>
> > Signed-off-by: Carlos Llamas <cmllamas@google.com>
> > ---
> > v2: fixed patch formatting, added tags.
> >
> > drivers/android/binder/rust_binder_main.rs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
> > index aa5f2a75adb4..3907291a33c9 100644
> > --- a/drivers/android/binder/rust_binder_main.rs
> > +++ b/drivers/android/binder/rust_binder_main.rs
> > @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
> > // SAFETY: The module initializer never runs twice, so we only call this once.
> > unsafe { crate::context::CONTEXTS.init() };
> >
> > - pr_warn!("Loaded Rust Binder.");
> > + pr_info!("Loaded Rust Binder.");
>
> When drivers work properly, they are quiet, so why print anything out at
> all here?
Yeah let's just delete this. It's not needed anymore.
Alice
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-27 9:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-26 22:06 [PATCH] rust_binder: Downgrade startup warning to info Pedro Montes Alcalde
2026-03-26 22:52 ` Carlos Llamas
2026-03-26 23:07 ` [PATCH v2] " Carlos Llamas
2026-03-27 6:24 ` Greg KH
2026-03-27 9:34 ` Alice Ryhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox