From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9603DCDAA for ; Fri, 27 Mar 2026 10:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774607938; cv=none; b=Q8mo8psXdQi5c+94stLqNeUrO99+yJDsPOpnzSIDJsPE8MXQRAyzwsXl9dRKInUB/LMRQv+U3e57TevEjZEtJomztZVUB3+mdNQwpG18h4RmR4DsecXifjw2CIxZEsciIm/fmso9zF+ywou1IUpZGLslATwCtN4FggX1A4fJTfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774607938; c=relaxed/simple; bh=qnC3AqV7Aatx+D6wGKLxY5s/1o6g1HDgr4Vm42814SQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rnV2JPwmK+NEcr3BS9JcPCHfe3O40Z4g96WyJ1Lo4d12ElhVpUM3EVW1veg/BqCtgFSs48mEAOqEGAoguuwyd2VOTxg00n5Lg7YEd//9XWStWgpwgGRRt1Ghd5F84zyqrUaq15VkD8wtKRvzxTqO64d/krtFptfgmSoo97XkYLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DkJSIRhn; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DkJSIRhn" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4870206f73bso11311555e9.3 for ; Fri, 27 Mar 2026 03:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774607932; x=1775212732; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UzUpA3i0Hxniu8He6Bd8IsgNfGDc3yTw+WZh9EwyyDs=; b=DkJSIRhnXvkTnD1EPNh6kgdavXD0l1mESAvVU4NtPWGCuViBTPFESR7u7mpCKgKChx pyr6/vSaTAbYa0EHngmY1HNEF+qitggfSBRitBOdg6tjGz11adNjj3yNg167zbk09PmQ L4gN8CftEivPYUoN3zsY9ymsVhGjxQziB4iKFE8AbbuIq/jBEJvMd8y+oyUvMFQI0d77 10KNsBjX43BqVy+HN4GF8CBixum+JEMjP8svNnEmGQ0VSD76wYdd7dD3G+1Q1mf96SFB eFEdvTa0P7FgRc5xYPM8dRcTWjoXRvjlbEOsur1+qNwK6cnex14Nhop6rtGdPQwwS7QE yu2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774607932; x=1775212732; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UzUpA3i0Hxniu8He6Bd8IsgNfGDc3yTw+WZh9EwyyDs=; b=LDZWdBT2K5GHlOvjqLSlx9smJ6dfirtbOICZVyUKHXY39OZg4tOrzdBIPp2oCzKj8g tnfGo/6hB8cX4FCYgRCYW2inEggbgd7aDXPP3Dw2b4RHPOE9NFLcdYjaP1Uv8YhiQtnM 1aKULYIakxicJaRXZgJGMmTt+XDxfvghZyE1+/qJ9BRZjCjKlVmqCML/PUukhQSSUhNn KPo6hNA1pY97bPYOY05XAFK0jMKuCdttKtGSri3xOdKBmuNF7UwboPEWvdz5A7c4IQmN rqgVVy09IbJms/rdk4YZp7ZYiTYk+8kUqpDyNheOC4itoZsF1X8b7O2D/Tc9m2M8A1Ih rjow== X-Gm-Message-State: AOJu0Yy+m4awHK/4joAqTMveJk50olo/U3AUBcfnQKyCjH2i6h3ndyUz Nu0tiDHZNkBGJBx4lLMPupnJ3e5bjp98awi6yXvmgVnKexXbje53QIut X-Gm-Gg: ATEYQzyX4lQEk8pDdzoCyC3t0M7tiQq2KYMkaK5ABdJ8aEKr6ZT/w19R8ClbVvTJVZ9 HFkxN6YouQ2HgaSx0AzZtImoS8Fia5aPW8RZXxLWFwqbOf1pEGk7SVYF5vqYkTIZFmJcoF8u8tA UMtcVH7G9/mXo0SB8qAKMkdALMO7BIfRE3eP9F7QddWN7hS4eUGZ1gUIpv5EMq2+2ltl19jC9fr Dge66geY8riyzYURl7QKC5+H7JnJTcZhtTAkTsnK7768Jx0ncahci7JL32uFNa9S90ClvqwmFoO Z/bdXhE5Rvy24IUvju0cNo5R/8dcafOoBZ8S4SgJTTWbJHnulma+cOyOHwlRv/JlUfjFmH4X8/8 KRQwpCL2UR4w/Q223fzz3fXxfnGDenK7fg5KdsNaFk2pHqZlRlsj/sdKSCZxdpegHNHly3mo679 rE9NEva2kgTkjk5JBmJIg94KKaXteDwdfdsY0mydw= X-Received: by 2002:a05:600c:6814:b0:486:fbe1:2499 with SMTP id 5b1f17b1804b1-48727f7be29mr32119625e9.22.1774607931690; Fri, 27 Mar 2026 03:38:51 -0700 (PDT) Received: from egonzo (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48725fca5f2sm15382445e9.12.2026.03.27.03.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 03:38:51 -0700 (PDT) Date: Fri, 27 Mar 2026 11:38:49 +0100 From: Dave Penkler To: Joe Simmons-Talbott Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpib: agilent_82357a: don't check a NULL serial string Message-ID: References: <20260326131256.1758014-1-joest@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326131256.1758014-1-joest@redhat.com> On Thu, Mar 26, 2026 at 09:12:56AM -0400, Joe Simmons-Talbott wrote: > The agilent_82357a driver uses the USB device serial string for device > matching but does not verify that the string exists before passing it > to strcmp(). > > Verify that the device has a serial number before accessing it to avoid > triggering a NULL-pointer dereference with devices that don't provide > a serial number (iSerialNumber = 0). > > Similar to commit aa79f996eb41 ("i2c: cp2615: fix serial string > NULL-deref at probe"). > > Found by Claude:sonnet-4.5 > > Signed-off-by: Joe Simmons-Talbott > --- > drivers/gpib/agilent_82357a/agilent_82357a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpib/agilent_82357a/agilent_82357a.c b/drivers/gpib/agilent_82357a/agilent_82357a.c > index e1349afbf933..da046ea40f11 100644 > --- a/drivers/gpib/agilent_82357a/agilent_82357a.c > +++ b/drivers/gpib/agilent_82357a/agilent_82357a.c > @@ -1298,7 +1298,7 @@ static inline int agilent_82357a_device_match(struct usb_interface *interface, > if (gpib_match_device_path(&interface->dev, config->device_path) == 0) > return 0; > if (config->serial_number && > - strcmp(usbdev->serial, config->serial_number) != 0) > + (!usbdev->serial || strcmp(usbdev->serial, config->serial_number) != 0)) > return 0; > > return 1; > -- > 2.53.0 > Acked-by: Dave Penkler