From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4A4382285 for ; Fri, 27 Mar 2026 12:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774612899; cv=none; b=JhcuHwpcBNgawNw+HsxbitsxpyD/NPvCYeY2RieTp2PzuPEI8HWmhRnG94503JymqIL9q+Ro9h4zWT52nnz6DSSElPRo2eFgCvcZjdn4uiD9Dif8Wq6l8yo3IstEOGaazMZHs7NGNBAePzgE1JiW55Uff1kQl6MlYC34tn93IrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774612899; c=relaxed/simple; bh=Ok4j49gu2VTWuchFZy9QnRZzJkYTWamW2suiarPVT+g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hexyroJjhwkCfP0Q6zn2MQP2eV5AFZjSQqMy9bUgiEtccnNOzrJaPNBSSO5gk5u5FTYvxVDTiIvPTccRi6Q7WlwyUebN4+ZAQzrY/rPpX0d5Z7gGuiBHCBqMgpsmrz2xXISthV/OwJ1m07e/XNdnPmt2MJ7UdYDk+fi4+NmRShg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U2A79K0N; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U2A79K0N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774612896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g3WhH1msur3UHpUWCgk4GOP0E4m61K4RiHMSJwcOf3I=; b=U2A79K0NhCprdNFLtxS6kPW/I4wVAjDTaFKd1vJzX4QWvW5IWFhuxzMOQb4snNflq1mhJw jfNpwHWMeqrxd6pEW/CmAKLurHw3KeFlzI2Shlq22LaUohor5sFvbDFWfIk2g6gDHMQorm lmAdBBbXN6CPc8xoIS7l/CdKVsplCM4= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-uoBJyWXZPZG9q4J5a6bYEg-1; Fri, 27 Mar 2026 08:01:35 -0400 X-MC-Unique: uoBJyWXZPZG9q4J5a6bYEg-1 X-Mimecast-MFC-AGG-ID: uoBJyWXZPZG9q4J5a6bYEg_1774612893 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2FCB518005B9; Fri, 27 Mar 2026 12:01:31 +0000 (UTC) Received: from thinkpad (unknown [10.44.33.208]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 95F1630002DC; Fri, 27 Mar 2026 12:01:28 +0000 (UTC) Date: Fri, 27 Mar 2026 13:01:25 +0100 From: Felix Maurer To: luka.gejak@linux.dev Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, horms@kernel.org, liuhangbin@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 0/2] net: hsr: subsystem cleanups and modernization Message-ID: References: <20260326174600.136232-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326174600.136232-1-luka.gejak@linux.dev> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Thu, Mar 26, 2026 at 06:45:58PM +0100, luka.gejak@linux.dev wrote: > From: Luka Gejak > > Changes in v2: > - dropped trivial cleanup-only patches per netdev clean-up policy > - added AI attribution for cover-letter/commit-message wording only > - dropped fallthrough/BIT conversion patches per review Thank you for updating (and limiting) the series. > This series contains two focused HSR cleanups with practical benefit. > It constifies protocol operation tables and replaces a hardcoded > function name with __func__ to keep diagnostics correct across > refactoring. > Assisted-by: Copilot:gpt-5.3-codex (cover-letter/commit-message wording > only) > > Luka Gejak (2): > net: hsr: constify hsr_ops and prp_ops protocol operation structures > net: hsr: use __func__ instead of hardcoded function name The patches look good to me, so for the series: Reviewed-by: Felix Maurer Thanks, Felix