From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 900BF3BC67E for ; Fri, 3 Apr 2026 13:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775222972; cv=none; b=esiB5IBgaIQOfaUD45nqoT/XKMku82sW7oDjTZheCJIwaN/4gJlcQGrJojxnc4agkmWDUxG0ARUez+rJb8470EVz0bR/kMJjnD8upqNCBH2ufxIY7C3Es05XJgRzdbBw520GiJ4IhwDuUxkFBgSEPRGXP9FmjLcrt0FLInZOfGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775222972; c=relaxed/simple; bh=blHK4KzH5lgN9+DZFvRNfi2lm0KKMuYwwQPYPh1mRlY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gjUfXi67FLpomf/v+F290m+iZ9nEsFSC5mrq2XNpprVRjI7dpDorx/ssGKFHzeY4lekXGd7T90+WyqEWmo/GDptVYITwY1gULD/fr9wIJ7BRpccVGPwqarN085JvmgtjfsuxqwV8KRxyzyxJhnaOQoKXcE12PvjYr8NMsm6K1x4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IWM7nKIc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bn+Ef8vj; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IWM7nKIc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bn+Ef8vj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775222970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D3TgrwVgeoZcZASDHDP/iFsOkmG4q/7olBpiPeQBlYk=; b=IWM7nKIchRdQTtzs2/2MJmMLN5J7DFgRpEXcnuhImOXTVk/QNuk5tUtrXd1mfWlEvrJFG9 D+RGKIplfJXafe5fckIqbEhH8EfIlFHhGlrJkvz87xfZXVodg8LIjGAE6Zp9wtR9clW+o4 ISwIduyjiYhfJ17OLWn1FsVSD57IaNs= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-CD6ItU6lNJirptmftrVQgg-1; Fri, 03 Apr 2026 09:29:29 -0400 X-MC-Unique: CD6ItU6lNJirptmftrVQgg-1 X-Mimecast-MFC-AGG-ID: CD6ItU6lNJirptmftrVQgg_1775222969 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b6f869676so43605941cf.2 for ; Fri, 03 Apr 2026 06:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775222969; x=1775827769; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=D3TgrwVgeoZcZASDHDP/iFsOkmG4q/7olBpiPeQBlYk=; b=bn+Ef8vjKpz5S59IT2lXZVsrZ49jIr2mk241I+4jT8UK91zKlNzC3yP5YBzUqM2KGa 17ivp4A+p4SWp9/cnNQvz5luuZImelAxmGnjsf6ruVl3xy5DsIws6oil3GYuMgs+o9Xs k+Wb+as5EPin3U4nGLxKl3I24CxBGBmC0xnDTeHJEl2TTfTSJC59oOyZeTuwYTxI5KEu esuxzbUrd1GKn7uT3nUzhEC2SKzoaPL3YW5kXvyOy7FkO0ZJtPRE9+bZK6FGx6v+cElO j/jPppcUJVR513WFO/WfPOdGhnN5PXaNHejTyY7voVGP+C83JD4TmzsV0jOHdviTrvzA WRZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775222969; x=1775827769; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=D3TgrwVgeoZcZASDHDP/iFsOkmG4q/7olBpiPeQBlYk=; b=gZLkFDvswO2Pnpjru83Sf/2C++pzV9e8sX6+pItXvN78mdIeVju9J7EW/AWgGyhaUb sqPEFf79sxmphTus4DXihPNbIQl33TB3L3PWJWV3kjujXVRgchqodprf/GR7hrU3+BWX KT7LXDFyPlPEWgUp8lZPPazRMtefUBxAHPh7l+7PvrjHZL6QgnjYgilCVMi+5iTgzu+M p9NdYp7vwoaZU9US7ORIfWvlxiHYJPNvOtJfNd/m1LWecFfWjwigDCa2CH7/Qb75Auy1 0VpiRwsIarReIn6yKZBrfOzGta9ec+pybOTmCJX3iEL1qj85WHEB8l/3CpKhRYg+V3Rz GEpQ== X-Forwarded-Encrypted: i=1; AJvYcCVIuPbIdTY7g0rJQEPvEX/suRRPpenf3bsRmq2lI40xLyM5/Hfq3GPWx7ed6dOV8H4for3Kao465T+hAoQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzBKOAyEOio4hs2l4HkhXEQwZ6+WyuAcDFQ0gWh4xiU9VjcZXZg aYeKAKAScRysEvARoKU+baoLXTqKRHdCG1iFQIq9Kg1QPRBi0DSb4jOxRetfKLkS/Tc8Scf9J5w kQtxAZVJtr03dMC/HNm+sI5DmWlrNDxUBFay1yIdc/7Kiv1evn+GCiX/fy/UPMJ7p6g== X-Gm-Gg: ATEYQzwScM8eEJrOoagAj3v+8VM8gbB+3k/GEjushxCDQY4TuVgt5o6KjaUlb9ZeYkO FZXkEO4IQNHg5xE2GTXKsZFKUJv+P/rKCnZr7gf4SvGdL6B2tfO5oa5eOpf1kKeqckXnMmL6uCf pX0X+asBqt1Ir8MGtOzG/iXsXFeNasClaybvqABnOI6FGoCvOU/L5+1HNzzHCQM8bRkfHOuQXsn rjUab146XJhnYBjQVghwBsFYpzL+gR3/WB0W5DhINjL+JRjHm2A6Ip0vy/n5QBawPdHHCL5Xe9f Z5Mkqed6ljKZ7YQeGoCKXVNAIRXz9CUcLvQHu+kqMTyfw9rn36bzkhEh1rxxj/R4BA154oJd4F2 JKY58d2KnKrUCkeRmKbCedKdg47eoKUVqoofvrFZDXM42Rey8hUWkGL9e X-Received: by 2002:ac8:7f88:0:b0:50b:37ff:727e with SMTP id d75a77b69052e-50d62a95729mr48480061cf.44.1775222969000; Fri, 03 Apr 2026 06:29:29 -0700 (PDT) X-Received: by 2002:ac8:7f88:0:b0:50b:37ff:727e with SMTP id d75a77b69052e-50d62a95729mr48479561cf.44.1775222968488; Fri, 03 Apr 2026 06:29:28 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50d63962c30sm17886441cf.10.2026.04.03.06.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 06:29:27 -0700 (PDT) Date: Fri, 3 Apr 2026 09:29:26 -0400 From: Brian Masney To: Rosen Penev Cc: linux-clk@vger.kernel.org, Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Michael Turquette , Stephen Boyd , Kees Cook , "Gustavo A. R. Silva" , "moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,..." , open list , "open list:KERNEL HARDENING (not covered by other areas):Keyword:b__counted_by(_le|_be)?b" Subject: Re: [PATCH] clk: mvebu: use kzalloc_flex Message-ID: References: <20260402002011.89926-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260402002011.89926-1-rosenp@gmail.com> User-Agent: Mutt/2.3.0 (2026-01-25) Hi Rosen, On Wed, Apr 01, 2026 at 05:20:11PM -0700, Rosen Penev wrote: > Use a flexible array member to combine kzalloc and kcalloc in one > allocation so they can be freed together. > > Add __counted_by for extra runtime analysis. Move counting variable > assignment right after allocation as done by kzalloc_flex with GCC >= > 15. > > Signed-off-by: Rosen Penev > --- > drivers/clk/mvebu/common.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/drivers/clk/mvebu/common.c b/drivers/clk/mvebu/common.c > index 28f2e1b2a932..4129690fcae0 100644 > --- a/drivers/clk/mvebu/common.c > +++ b/drivers/clk/mvebu/common.c > @@ -189,10 +189,10 @@ DEFINE_SPINLOCK(ctrl_gating_lock); > > struct clk_gating_ctrl { > spinlock_t *lock; > - struct clk **gates; > int num_gates; > void __iomem *base; > u32 saved_reg; > + struct clk *gates[] __counted_by(num_gates); > }; > > static struct clk_gating_ctrl *ctrl; > @@ -257,24 +257,21 @@ void __init mvebu_clk_gating_setup(struct device_node *np, > clk_put(clk); > } > > - ctrl = kzalloc_obj(*ctrl); > + /* Count, allocate, and register clock gates */ > + for (n = 0; desc[n].name;) > + n++; > + > + ctrl = kzalloc_flex(*ctrl, gates, n); > if (WARN_ON(!ctrl)) > goto ctrl_out; > > + ctrl->num_gates = n; > + > /* lock must already be initialized */ > ctrl->lock = &ctrl_gating_lock; > > ctrl->base = base; > > - /* Count, allocate, and register clock gates */ > - for (n = 0; desc[n].name;) > - n++; > - > - ctrl->num_gates = n; > - ctrl->gates = kzalloc_objs(*ctrl->gates, ctrl->num_gates); > - if (WARN_ON(!ctrl->gates)) > - goto gates_out; The gates_out label and kfree() needs to be removed. Brian > - > for (n = 0; n < ctrl->num_gates; n++) { > const char *parent = > (desc[n].parent) ? desc[n].parent : default_parent; > -- > 2.53.0 >