From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EFF523A561 for ; Fri, 3 Apr 2026 14:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775226718; cv=none; b=QFTLuY326V/STtYzQ86m7jV96dAWQ+g28B0nljBsfgBaYQczbqHsICPdDvsiUuGmp5Fvi6LlLU+5rTVA7LLLbKkvLlYqJeT4Xc57eROp3dY6+Ua9pdZrI63oOLa5JTjTNAP9iCpn+wK4OPtOJWfA1qRn5tHhz1wb0NkD3k9VmjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775226718; c=relaxed/simple; bh=VguYvpAOuS+7YUI234AcqNuJjccYJj0ftLs4J3pM300=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KLP8aj9C78LQDDYT0jbhYULvK1wBE9XSrDt7IWSA7RfHwpTP1oFbV1E4Rf2gmxQ8H7B6+KPcfLd/3Ppl2PA4peJ3lBJJkRHDZzGSiCC/s6GHjMTi5cc3GdEBZDOf8zZGbDeM/WpAQbZHirZCUOuXzwsPrnFCPyRgEbX+UK06Sz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=Z35AlIog; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="Z35AlIog" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-4043b27ddeaso1255165fac.1 for ; Fri, 03 Apr 2026 07:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1775226715; x=1775831515; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=jcGkuJjxqLYxz5jslzQh2JyJsh0sOUQ/qFetPtnPzfw=; b=Z35AlIogERMgdvf0ZBoKOBuZjoJaLz8zmQM3dtjyrAf1VfrXe20SP+oVyyfD8hXEvx uPlIhy7hQadX5xDtSvp9YuqRVDFPGQWRj9ELs6jED7waiP36cjELO1XfvAUEp2ofSOeJ PinfrB4frZlfLNLshwEwBCy8b0uqt53RaIokmjcHVuIg+9JH2OPh88OLfKdgm3xTPuYW nHwP+RlOXUxOdwtsDAVegaJ36ZChqg//5XKRYBOzEiF5TJtDwbNsQqxf6nuE8XUsbkK0 /nEkQo+h4bq8tD4+IqNHFPCiqs25WSYzUazAbmdpO9vr2roNbottC4Fhy/RkZw8yBh31 TVlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775226715; x=1775831515; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jcGkuJjxqLYxz5jslzQh2JyJsh0sOUQ/qFetPtnPzfw=; b=GdU2Rs7bYD2Sk3YPF+fpviPUARuRoGOvIsLHaKok/ga7i12V0NEPmhierqCOfkktpq oFOdZbcVaCTOkJPsAdtmRiSvL/u596mx+3sKiF7BK/CbhXRHYrtSdV11FErigDQKNLjS SNuw3r3qDanCJBBX1rk3vQahocEly0arSpR+oJ5ZJ8n0U+sch7UInoy2dn9GDpbKt4do mj/hLcjwyL+242M65OqR3bsMKUrkHhKIxbpJdqAAYhRDfHGQDHeysCCxKhZJ7T3HnSSa AiCea7qlOhOvL62ss46JdNde+L0va3gx4pF8V2JXU8UDN6zUMSfgBgQmBarj7NRrb7VG pIEQ== X-Forwarded-Encrypted: i=1; AJvYcCX3GtIpC6UR1WXxDwARAKGd0WnSS4FltkTVsY/2PaWsA5/Qpd3DV50/AUGdTujKNP3re1HoIJ22rdfFRJs=@vger.kernel.org X-Gm-Message-State: AOJu0YwfyR2sX0Ue9NJga07RqjImNeEJjzwdISXz9vJZXiiFethtSLQ2 5HMpCRAJIpGYn9izIvCiUSGhcXlPfQg6nvTGuKv1EXCqnKo2DBIu64xp6X41g5kLxZOZyXfR5zU YSMY2 X-Gm-Gg: AeBDietgAWcGTdtOTYsGr2oJKL2a1tU25dj9806bRWpos1NBtq6QkzDkdEAbv//Bo6+ cfBNafW/tDf4ChV41PJmmji6PkOlBPV7DtaPHivLy428PikDWM9uPzBKBiYry16Ry2Zs4ZbvIKy U5hLEoIqoWOtvklvb7NC5laDKzlrGR7k1hTl2HYDcU9t5MPI5ZCAkz3fAFdKcH6cLzVsXYZ0X/L iurIxQCXuNQIEFe3FHcq2SdBqqERWGiXGJKjnwPEz4omkOb+4Fy91q+D9U5ZVrYaBusmc7hPecX U0AraOugnvBAiyFUY097rI7VdjU9fbKD4cky5iZzIIvYctcpgT3wGJ3//mYyDUHzm0BiYTrB0KC hFWyp0fFbHATslBE+ipLCbHBwUFSaSS4WbyaXkdiYm2Nygrl9S13hPckojocItU6IiWqR3FXxsB UMCDzFA0ZWyP7rniNUSR7CDE8noUJup1sSuBBw1cjV+J8/Ln31peB0HJH/T96TnkEQsSiKWHKvX 3z3sFpoVnbXQmY= X-Received: by 2002:a05:6870:158a:b0:41c:3fbf:431 with SMTP id 586e51a60fabf-4230fd9aeb7mr1647183fac.17.1775226714818; Fri, 03 Apr 2026 07:31:54 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:67f7:eb47:a398:6ff2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-422eb3ce790sm4727553fac.16.2026.04.03.07.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 07:31:54 -0700 (PDT) Date: Fri, 3 Apr 2026 09:31:49 -0500 From: Corey Minyard To: Jian Zhang Cc: Quan Nguyen , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] ipmi: ssif_bmc: add unit test for state machine Message-ID: Reply-To: corey@minyard.net References: <20260403090603.3988423-1-zhangjian.3032@bytedance.com> <20260403090603.3988423-5-zhangjian.3032@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Apr 03, 2026 at 10:12:45PM +0800, Jian Zhang wrote: > > 2026年4月3日 21:14，Corey Minyard 写道： > > > > On Fri, Apr 03, 2026 at 05:06:02PM +0800, Jian Zhang wrote: > >> Add some unit test for state machine when in SSIF_ABORTING state. > >> > >> Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver") > >> Signed-off-by: Jian Zhang > >> --- > >> v2: remove undefined symbol response_in_send > >> > >> drivers/char/ipmi/Kconfig | 10 + > >> drivers/char/ipmi/ssif_bmc.c | 401 +++++++++++++++++++++++++++++++++++ > >> 2 files changed, 411 insertions(+) > >> > >> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig > >> index 92bed266d07c..709820f80266 100644 > >> --- a/drivers/char/ipmi/Kconfig > >> +++ b/drivers/char/ipmi/Kconfig > >> @@ -187,6 +187,16 @@ config SSIF_IPMI_BMC > >> The driver implements the BMC side of the SMBus system > >> interface (SSIF). > >> > >> +config SSIF_IPMI_BMC_KUNIT_TEST > >> + bool "KUnit tests for SSIF IPMI BMC driver" if !KUNIT_ALL_TESTS > >> + depends on KUNIT=y > >> + depends on SSIF_IPMI_BMC=y > > > > Any reason for the "=y" in the above two? > > > > It's best to remove them if they are not needed so it can work in a > > module. I can make that change, there's no need for a new series for > > that. > > Nothing special and agree, Thanks. > There’s one more thing that needs adjustment as well. > Sorry about that—I picked it from dev-6.1 without testing (at the time there was a build error, so I didn’t run the unit tests). > The test “ssif_bmc_test_restart_after_invalid_length” also needs to be removed. I do have a local patch regarding the length limitation, > but it still needs thorough testing. Sorry again, I’m not very familiar with it yet, I’ll pay more attention in the future! In that case, can you re-send just patch 5? Thanks, -corey > > - Jian > > > > Oh, and I forgot to say in the reply on the first change, thanks Quan > > for reviewing these. > > > > -corey > > > >> + default KUNIT_ALL_TESTS > >> + help > >> + This option builds unit tests that exercise the SSIF BMC state > >> + machine, including request handling, response transmission, > >> + and error paths such as aborted or truncated transfers. > >> + > >> config IPMB_DEVICE_INTERFACE > >> tristate 'IPMB Interface handler' > >> depends on I2C > >> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c > >> index 646a1e9ffbb7..726626126cea 100644 > >> --- a/drivers/char/ipmi/ssif_bmc.c > >> +++ b/drivers/char/ipmi/ssif_bmc.c > >> @@ -18,6 +18,9 @@ > >> #include > >> #include > >> #include > >> +#if IS_ENABLED(CONFIG_SSIF_IPMI_BMC_KUNIT_TEST) > >> +#include > >> +#endif > >> > >> #define DEVICE_NAME "ipmi-ssif-host" > >> > >> @@ -886,6 +889,404 @@ static struct i2c_driver ssif_bmc_driver = { > >> .id_table = ssif_bmc_id, > >> }; > >> > >> +#if IS_ENABLED(CONFIG_SSIF_IPMI_BMC_KUNIT_TEST) > >> +struct ssif_bmc_test_ctx { > >> + struct ssif_bmc_ctx ssif_bmc; > >> + struct i2c_client client; > >> + struct i2c_adapter adapter; > >> + struct i2c_algorithm algo; > >> +}; > >> + > >> +static int ssif_bmc_test_init(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx; > >> + > >> + test_ctx = kunit_kzalloc(test, sizeof(*test_ctx), GFP_KERNEL); > >> + if (!test_ctx) > >> + return -ENOMEM; > >> + > >> + test_ctx->adapter.algo = &test_ctx->algo; > >> + test_ctx->client.addr = 0x20; > >> + test_ctx->client.adapter = &test_ctx->adapter; > >> + > >> + spin_lock_init(&test_ctx->ssif_bmc.lock); > >> + init_waitqueue_head(&test_ctx->ssif_bmc.wait_queue); > >> + test_ctx->ssif_bmc.client = &test_ctx->client; > >> + i2c_set_clientdata(&test_ctx->client, &test_ctx->ssif_bmc); > >> + > >> + test->priv = test_ctx; > >> + > >> + return 0; > >> +} > >> + > >> +static void ssif_bmc_test_exit(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + > >> + if (test_ctx->ssif_bmc.response_timer_inited) > >> + timer_delete_sync(&test_ctx->ssif_bmc.response_timer); > >> +} > >> + > >> +static int ssif_bmc_test_run_event_val(struct ssif_bmc_test_ctx *test_ctx, > >> + enum i2c_slave_event event, > >> + u8 *value) > >> +{ > >> + return ssif_bmc_cb(&test_ctx->client, event, value); > >> +} > >> + > >> +static int ssif_bmc_test_run_event(struct ssif_bmc_test_ctx *test_ctx, > >> + enum i2c_slave_event event, u8 value) > >> +{ > >> + return ssif_bmc_test_run_event_val(test_ctx, event, &value); > >> +} > >> + > >> +static void ssif_bmc_test_singlepart_req(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)); > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + SSIF_IPMI_SINGLEPART_WRITE); > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 2); > >> + > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xaa); > >> + > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0x55); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); > >> + > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->request_available); > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->busy); > >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->aborting); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 2); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[0], 0xaa); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[1], 0x55); > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->response_timer_inited); > >> +} > >> + > >> +static void ssif_bmc_test_restart_write_without_stop(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + SSIF_IPMI_SINGLEPART_WRITE), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 2), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xde), 0); > >> + > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_REQ_RECVING); > >> + > >> + /* Write transaction, without stop, and new request coming */ > >> + ssif_bmc_test_singlepart_req(test); > >> +} > >> + > >> + > >> +static void ssif_bmc_test_restart_after_invalid_command(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xff), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); > >> + > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_ABORTING); > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->aborting); > >> + > >> + /* After An Invalid Command, expect could handle new request */ > >> + ssif_bmc_test_singlepart_req(test); > >> +} > >> + > >> +static void ssif_bmc_test_restart_after_invalid_length(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + int i; > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + SSIF_IPMI_SINGLEPART_WRITE), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + MAX_PAYLOAD_PER_TRANSACTION + 1), 0); > >> + > >> + for (i = 0; i < MAX_PAYLOAD_PER_TRANSACTION + 1; i++) > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, > >> + I2C_SLAVE_WRITE_RECEIVED, i), 0); > >> + > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->aborting); > >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->request_available); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_REQ_RECVING); > >> + > >> + ssif_bmc_test_singlepart_req(test); > >> +} > >> + > >> +static void ssif_bmc_test_singlepart_read_response_completion(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + u8 value; > >> + > >> + ssif_bmc->state = SSIF_SMBUS_CMD; > >> + ssif_bmc->part_buf.smbus_cmd = SSIF_IPMI_SINGLEPART_READ; > >> + ssif_bmc->response.len = 2; > >> + ssif_bmc->response.payload[0] = 0x11; > >> + ssif_bmc->response.payload[1] = 0x22; > >> + ssif_bmc->response_in_progress = true; > >> + ssif_bmc->is_singlepart_read = true; > >> + ssif_bmc->pec_support = true; > >> + > >> + value = 0; > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, > >> + &value), 0); > >> + KUNIT_EXPECT_EQ(test, value, 2); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_RES_SENDING); > >> + > >> + value = 0; > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, > >> + &value), 0); > >> + KUNIT_EXPECT_EQ(test, value, 0x11); > >> + > >> + value = 0; > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, > >> + &value), 0); > >> + KUNIT_EXPECT_EQ(test, value, 0x22); > >> + > >> + value = 0; > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, > >> + &value), 0); > >> + KUNIT_EXPECT_EQ(test, value, ssif_bmc->part_buf.pec); > >> + > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); > >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->response_in_progress); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->response.len, 0); > >> +} > >> + > >> +static void ssif_bmc_test_stop_during_start_discards_partial_request(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_START); > >> + > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); > >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->request_available); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->msg_idx, 0); > >> + > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + SSIF_IPMI_SINGLEPART_WRITE), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0x77), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); > >> + > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->request_available); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 1); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[0], 0x77); > >> +} > >> + > >> +static void ssif_bmc_test_read_interrupts_partial_write(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + u8 value = 0xff; > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + SSIF_IPMI_SINGLEPART_WRITE), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 2), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xab), 0); > >> + > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_REQ_RECVING); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, > >> + &value), 0); > >> + KUNIT_EXPECT_EQ(test, value, 0); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_ABORTING); > >> + > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); > >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->request_available); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 0); > >> + > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + SSIF_IPMI_SINGLEPART_WRITE), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0xcd), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); > >> + > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->request_available); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 1); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[0], 0xcd); > >> +} > >> + > >> +static void ssif_bmc_test_write_interrupts_response_send(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + u8 value = 0; > >> + > >> + ssif_bmc->state = SSIF_SMBUS_CMD; > >> + ssif_bmc->part_buf.smbus_cmd = SSIF_IPMI_SINGLEPART_READ; > >> + ssif_bmc->response.len = 1; > >> + ssif_bmc->response.payload[0] = 0x66; > >> + ssif_bmc->response_in_progress = true; > >> + ssif_bmc->is_singlepart_read = true; > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, > >> + &value), 0); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_RES_SENDING); > >> + > >> + /* READ_REQUESTED transaction */ > >> + ssif_bmc_test_singlepart_req(test); > >> +} > >> + > >> +static void ssif_bmc_test_write_interrupts_response_sending(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + u8 value = 0; > >> + > >> + ssif_bmc->state = SSIF_SMBUS_CMD; > >> + ssif_bmc->part_buf.smbus_cmd = SSIF_IPMI_SINGLEPART_READ; > >> + ssif_bmc->response.len = 1; > >> + ssif_bmc->response.payload[0] = 0x66; > >> + ssif_bmc->response_in_progress = true; > >> + ssif_bmc->is_singlepart_read = true; > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, > >> + &value), 0); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_RES_SENDING); > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, > >> + &value), 0); > >> + KUNIT_EXPECT_EQ(test, value, 0x66); > >> + > >> + /* READ_REQUESTED transaction */ > >> + ssif_bmc_test_singlepart_req(test); > >> +} > >> + > >> +static void ssif_bmc_test_timeout_interrupt_allows_retry(struct kunit *test) > >> +{ > >> + struct ssif_bmc_test_ctx *test_ctx = test->priv; > >> + struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; > >> + > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + SSIF_IPMI_SINGLEPART_WRITE), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0x21), 0); > >> + KUNIT_ASSERT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); > >> + > >> + KUNIT_ASSERT_TRUE(test, timer_pending(&ssif_bmc->response_timer)); > >> + timer_delete_sync(&ssif_bmc->response_timer); > >> + response_timeout(&ssif_bmc->response_timer); > >> + > >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->busy); > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->aborting); > >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->response_timer_inited); > >> + > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_REQUESTED, > >> + GET_8BIT_ADDR(test_ctx->client.addr)), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, > >> + SSIF_IPMI_SINGLEPART_WRITE), 0); > >> + KUNIT_EXPECT_FALSE(test, ssif_bmc->aborting); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 1), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_WRITE_RECEIVED, 0x22), 0); > >> + KUNIT_EXPECT_EQ(test, > >> + ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), -EBUSY); > >> + > >> + KUNIT_EXPECT_TRUE(test, ssif_bmc->request_available); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.len, 1); > >> + KUNIT_EXPECT_EQ(test, ssif_bmc->request.payload[0], 0x22); > >> +} > >> + > >> +static struct kunit_case ssif_bmc_test_cases[] = { > >> + KUNIT_CASE(ssif_bmc_test_singlepart_req), > >> + KUNIT_CASE(ssif_bmc_test_restart_write_without_stop), > >> + KUNIT_CASE(ssif_bmc_test_restart_after_invalid_command), > >> + KUNIT_CASE(ssif_bmc_test_restart_after_invalid_length), > >> + KUNIT_CASE(ssif_bmc_test_singlepart_read_response_completion), > >> + KUNIT_CASE(ssif_bmc_test_stop_during_start_discards_partial_request), > >> + KUNIT_CASE(ssif_bmc_test_read_interrupts_partial_write), > >> + KUNIT_CASE(ssif_bmc_test_write_interrupts_response_send), > >> + KUNIT_CASE(ssif_bmc_test_write_interrupts_response_sending), > >> + KUNIT_CASE(ssif_bmc_test_timeout_interrupt_allows_retry), > >> + {} > >> +}; > >> + > >> +static struct kunit_suite ssif_bmc_test_suite = { > >> + .name = "ssif_bmc_test", > >> + .init = ssif_bmc_test_init, > >> + .exit = ssif_bmc_test_exit, > >> + .test_cases = ssif_bmc_test_cases, > >> +}; > >> + > >> +kunit_test_suite(ssif_bmc_test_suite); > >> +#endif > >> + > >> module_i2c_driver(ssif_bmc_driver); > >> > >> MODULE_AUTHOR("Quan Nguyen "); > >> -- > >> 2.20.1