From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7BA223D7DF for ; Fri, 3 Apr 2026 15:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775229749; cv=none; b=tPCrtFJz/DD7Cc9WPk4UpYklKi0Hc5V4Dcdt09SnlOZ8u5rP/LzWgtS/aiYq2lMo81etmNfGPUMNmrSQunodf79DHH3OBTV9bJV5zTKRRtJqSlIDDnd9ED6T+11t7fY1WraUn+zftIGHaiedmL2lM8UMRXJkuLetK6E9dnHxSe0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775229749; c=relaxed/simple; bh=DFBq3w/+92JvVnCUbNwiX8XBReWt3DAvnjGNuqvEFVI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=Gow4LFmLvOUuJmjsSTAeN5ZzB6ZzGe7v7QTWEjCOSz+0k3p6XdQ8wAZywUQwscGyXftZtZbDxi12h2cEO55gyJM7UYwO2icbMFux1HSie1yjEBmeJ9nbWKCWAwDKXE0J/xS8U52iq+Bp/Py2gPECai/hpYSH8uERufJPylDw2xw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=V7U/ywbl; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="V7U/ywbl" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c76b6ccf298so1261769a12.0 for ; Fri, 03 Apr 2026 08:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775229746; x=1775834546; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=rpqHqNyfK10lqPQLcRaczDLbjeG2pjSQT2XmZnmBEwU=; b=V7U/ywblejifqP78l8dW7Ik8EudEIfcb6fj0hFD+oC+P4ugICyRU1+YSIwquX/jgKC De7KoKpTZLTZPHciHBnXHt6AWJrQ5no2Ui9X02aRRXO/1YEfekH1f9nZuWiJ7VhiSsgr ue1cNWL6tkY16knhsKbMBSu1vGqBW0sk95hvT5NaKq7+pdjnp4wjpOJRjSNL9gQoKAtH RfHzQ6sYCulGV1FHs75ltgdjnrwlQjiKmZkpjfXZtQbI/lysgl7DbUlDm7IDSJkhrCSk I1MkN7E6RqcrOT2Bb25ZeNz7YmFxHs/vzVTeF1Oq5eoW5XKy/4d3RpK10xL8AWhrv42j d8Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775229746; x=1775834546; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rpqHqNyfK10lqPQLcRaczDLbjeG2pjSQT2XmZnmBEwU=; b=rVhC/srVY6l0FONvEPkisy5N/yUxC5dK6rYENs4UTjUwjyQHSD2/eUgqcbzS4Luqu0 WZt4IKQXhj831xBbOR+GST+me49vX2sdEua9T7N+gWuI4QSgBeua9U3SzczPfTv5NmFZ LS9FReWDsjTI5STBytWVJh89/jWXkie62nCiS+09J4CKslIWfcOwx3cpmz8rxjUA012F 8M9iVBHXgHc8Pl0KYA1rEnSkesUZuGDAEyWV1+RHv7/thThu61ER9ZU7DGiGczxqo9AI OGIY7uE6eg+6n5Zpqe3Y/LeenrphmoM2C+wMRJtk/zV6KbsrlAIdYodQeV1RBeWWI+Kk LONg== X-Forwarded-Encrypted: i=1; AJvYcCWbNz0LBr47S14kP4roHp0A8n8zLtQ2au4QA4VMHqu47LjC+xufy1KL6yJZNhPB8sDSNNF1wtgqdpu98VA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywd5AXEH+R173K3T4LzgnzCUmrb5X2hp7qv8oOA8ztMhqpk7Z/s V6fjntGmXToWIz/k60KAMBCElcQG4wKK5dSBuVku3QyCjaTRXS5KDdsYDx8+j9h6g5tqaHn+z6o 1I1Q23A== X-Received: from pfbfc19.prod.google.com ([2002:a05:6a00:2e13:b0:824:aec2:e5eb]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1705:b0:828:d9a1:c5f9 with SMTP id d2e1a72fcca58-82d0db53ec9mr3313449b3a.33.1775229745970; Fri, 03 Apr 2026 08:22:25 -0700 (PDT) Date: Fri, 3 Apr 2026 08:22:24 -0700 In-Reply-To: <20260120203937.1447592-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260120203937.1447592-1-seanjc@google.com> Message-ID: Subject: Re: [PATCH] x86/tdx: Use pg_level in TDX APIs, not the TDX-Module's 0-based level From: Sean Christopherson To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, Kai Huang , Rick Edgecombe , Yan Zhao , Vishal Annapurve , Ackerley Tng Content-Type: text/plain; charset="us-ascii" On Tue, Jan 20, 2026, Sean Christopherson wrote: > Rework the TDX APIs to take the kernel's 1-based pg_level enum, not the > TDX-Module's 0-based level. The APIs are _kernel_ APIs, not TDX-Module > APIs, and the kernel (and KVM) uses "enum pg_level" literally everywhere. > > Using "enum pg_level" eliminates ambiguity when looking at the APIs (it's > NOT clear that "int level" refers to the TDX-Module's level), and will > allow for using existing helpers like page_level_size() when support for > hugepages is added to the S-EPT APIs. > > No functional change intended. > > Cc: Kai Huang > Cc: Dave Hansen > Cc: Rick Edgecombe > Cc: Yan Zhao > Cc: Vishal Annapurve > Cc: Ackerley Tng > Signed-off-by: Sean Christopherson > --- This still applies cleanly, any chance this can be picked up for 7.1 to avoid prototype conflicts in ongoing work?