From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2531A33C19E for ; Fri, 3 Apr 2026 15:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775231358; cv=none; b=dndSvXjHUPWSGDCCkAP9K/kWjlYCfIKIYxG4B407A/vQsG8FSiBlfWlGZbpgSHX2YQQvj/q+RjWqCOzdYPOMARNXfMQ6yqpaX7zztm2C9dRVRW+nhahjQ5kzCdx4zJRcFREsguszqqSEsvHXYsgatxvy+730ZwMfSzvY+5GjMQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775231358; c=relaxed/simple; bh=WSmU5k+D1+SIDkr8CFPVTNLJTKczyzNuuEkTgb8kjy8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KfVJBNfAPtQivDArZ4N6hkw84V0OhZYQ8K2w2uEvCeE2iHJPPo/L6e4zg+1gmhpznHVxE2E+gblFAdwgbZsC7wIyUKv0+XaP5d5wBQAj8EY2ZdLE3vFdCTY3OBpRa/ABaxltwE0w7UYEtdrzEihlzfZRbgBrTEJJ07rX9WnZum8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n0BHlH2+; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n0BHlH2+" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82a893d289bso934456b3a.0 for ; Fri, 03 Apr 2026 08:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775231355; x=1775836155; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nTVo+WtLtvfnHFf8kiYUUIc1WISVBJnPlDQpeATgcHs=; b=n0BHlH2+5d0IxZQ1cDj49Qfj8oQzXcktxhSKpMki2iTRr3hpAhMCzt50lTZlr7wi52 sFAUaAEwrlbLXdv8wqTSCJs7mz5iOA7KMVscbzxIsoglZ5RQ4C0TTVCTfW3wavwj1pWg oSlDuuI3rG5/IQEkelQSuA+ZpISJWvS9ANt6Ut/RMgUzs9UItpAz3UOjqj6b2ssMSCTx jW46+4bfN9cFc5JFxSKxNKpYiVxZYyfoZJRmvT5PPCiVJzJWRWBwV6wRaTsjGIyab3mb nFYgQLyjxavdkxhfdvzszSnAknPgNlOvRAa19mkj798NV46B6klfifxCtZOuVn6YzaRh /XZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775231355; x=1775836155; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nTVo+WtLtvfnHFf8kiYUUIc1WISVBJnPlDQpeATgcHs=; b=KuHLQr9UtUSSRikYCm5ejp/tYAdg2+y2ro0bpAy8meCo0p8LM+r/QrpEtKQPYbjVNt aqjcDRbLzf/E0x3MvpFkpQCxV29iDFGqIMaSk5UeqCakKbOABzi6N7FfZ702I9QT+7cW b+23vALN5QAaETQLIgFVdLNUDuSidA1uisXyiN2GUUwsdLfBQ/cpL71xoobMHd/W+rLc GlPQZip7aNEa31eiNcqXPFAD7stWkzG9PXyG9b43tAwWXxoLnifhtOEfRyso3ATKVxSt MQEq/HGIPJVFtwYOwxPR1FWPqRYzPMOARUxHJ/JqClHvwWDNsMh+vNpHxaXUnwZLv5DX Lg2A== X-Forwarded-Encrypted: i=1; AJvYcCXEP5+CqHPQQQdLvPSYfb79qT0h9u1XpKHI2StNSuXHDMd8ykR5+B1qg8pfyPBBGMXpuxubkpdkzWFqsqA=@vger.kernel.org X-Gm-Message-State: AOJu0YwswfPeulV35TY1rnc/IXjaNwHtGccOONSA7KSc9e3tHfdhWPef RHQiKx9TYYCSTPR/8cuaSPHFNIRNwBLQxAHXfvWYypqOkKSgIZlaDf2h X-Gm-Gg: ATEYQzzDLt6sghCwXBv3RqhTxyUqhGYngOT8wHf0Hy6SwqQn8nKgyVlfi4Jlp0UtRhr NNxW1jSI2skMO7YXI0XGZtvv8YZQlYili7kpv9bn0Iw9kZjzZK32q6UT3X6ELPevrjZacTC8AGm YekcJRzTcVcV/VFAT7KcqyowL9BssMmly+w1yUDLSte4WvcxB0+u91w39Wkh8RBKgA1iWY1a2aO 8aB836lnTIbr1k4i2MFw+JrAyprgxWRUakirZaJ4NS5FaTK4WtRgMhRVnrzF1t5LNqzIJDubXch zzeFHlRKz4s3ZRdEL/8LRoj5B8x87a/3MwsMSZIUbUF4J33hE71ga+GzSQBMxVesk0QOORmoXeF ZXqtmDy7SMpILSAvCXirsWkzr+31UAJu7CT552tJriTHGm9w/D6olrZ10CM6FL/uUZ41i9H36Pd H22WgRgAXOFcEp8/dv6aRaMmMYL29RzRywmd92XnTLoygCYaM= X-Received: by 2002:a05:6a20:7d9c:b0:398:8dbb:d1f with SMTP id adf61e73a8af0-39f2f2b78d5mr3389968637.55.1775231354793; Fri, 03 Apr 2026 08:49:14 -0700 (PDT) Received: from google.com ([2402:7500:477:c367:13c7:f0f4:4ae3:eaea]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c6563ce5sm5664860a12.21.2026.04.03.08.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 08:49:14 -0700 (PDT) Date: Fri, 3 Apr 2026 23:49:10 +0800 From: Kuan-Wei Chiu To: Josh Law Cc: David Gow , Kir Chou , Andrew Morton , linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH] lib/glob: add more KUnit tests for glob Message-ID: References: <20260403152853.61870-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260403152853.61870-1-objecting@objecting.org> Hi Josh, On Fri, Apr 03, 2026 at 03:28:53PM +0000, Josh Law wrote: > Since there isnt much tests for lib/glob.c, lets go ahead and add some more tests checkpatch.pl generates the following warnings: WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #60: Since there isnt much tests for lib/glob.c, lets go ahead and add some more tests WARNING: 'isnt' may be misspelled - perhaps 'isn't'? #60: Since there isnt much tests for lib/glob.c, lets go ahead and add some more tests ^^^^ total: 0 errors, 2 warnings, 31 lines checked I have mentioned this to you multiple times in the past: please always run checkpatch.pl to check your patches before sending them. Regards, Kuan-Wei > > Signed-off-by: Josh Law > --- > lib/tests/glob_kunit.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/lib/tests/glob_kunit.c b/lib/tests/glob_kunit.c > index 362b1eda8e5b..73d4f72fa824 100644 > --- a/lib/tests/glob_kunit.c > +++ b/lib/tests/glob_kunit.c > @@ -90,6 +90,31 @@ static const struct glob_test_case glob_test_cases[] = { > { .pat = "*abcd*abcdef*", .str = "abcabcdabcdeabcdefg", .expected = true }, > { .pat = "*abcd*", .str = "abcabcabcabcefg", .expected = false }, > { .pat = "*ab*cd*", .str = "abcabcabcabcefg", .expected = false }, > + /* backslash escaping */ > + { .pat = "\\a", .str = "a", .expected = true }, > + { .pat = "\\a", .str = "\\a", .expected = false }, > + { .pat = "\\*", .str = "*", .expected = true }, > + { .pat = "\\*", .str = "a", .expected = false }, > + { .pat = "\\?", .str = "?", .expected = true }, > + { .pat = "\\?", .str = "a", .expected = false }, > + { .pat = "\\[a]", .str = "[a]", .expected = true }, > + { .pat = "\\\\", .str = "\\", .expected = true }, > + { .pat = "a\\*b", .str = "a*b", .expected = true }, > + { .pat = "a\\*b", .str = "aXb", .expected = false }, > + /* trailing backslash */ > + { .pat = "a\\", .str = "a", .expected = true }, > + { .pat = "\\", .str = "", .expected = true }, > + /* backwards ranges */ > + { .pat = "[z-a]", .str = "m", .expected = false }, > + { .pat = "[!z-a]", .str = "m", .expected = true }, > + /* high-bit characters */ > + { .pat = "\xc0", .str = "\xc0", .expected = true }, > + { .pat = "\xc0", .str = "\x80", .expected = false }, > + { .pat = "[\x80-\xff]", .str = "\xc0", .expected = true }, > + { .pat = "[\x80-\xff]", .str = "\x7f", .expected = false }, > + /* unclosed bracket as literal */ > + { .pat = "[abc", .str = "[abc", .expected = true }, > + { .pat = "[abc", .str = "a", .expected = false }, > }; > > static void glob_case_to_desc(const struct glob_test_case *t, char *desc) > -- > 2.34.1 >