From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 431DF3CAE65 for ; Fri, 3 Apr 2026 16:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775232661; cv=none; b=V6zE4KMhQ8mrYZMKzVAJipGjY/Kb3Y6Hk6wwe5wJsumlyDXprDIAAbk532/YYPSLP80Y6C5UCkstffFdKfB2uRIAw4w0sbJ2tY3ocDWs78DoG3zQYHqcbSMVuIuywbckLDjEm0W/vgC9aTm4MHrnkvU6QQ28Vu0BpGU4R4ZhQsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775232661; c=relaxed/simple; bh=jk7Ex5w+Q8iio+nG9NS5B7YTXpXCFBHwCbuY4d6j+vQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g7AgyI8rJEs2gbxTr85fUg4YsID2tl+7dN34X/EtbD3waRq70iHbJEvwIrdA5BSVBp2KPeELEfNju5vJtCPOGWBZFGsNaK6lFEYNtuoORUdbCOXQxhraFxpid6ocF/nviwWhCDoMujJfTPPnwjzO2Zq8ivurHU7X6KezDhKPhPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lg/uvPgJ; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lg/uvPgJ" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c736261ee8dso702572a12.1 for ; Fri, 03 Apr 2026 09:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775232659; x=1775837459; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=BBgZda7dL+HQerXbdb2ueaytDQmBFa29DJ7dQt1pg5E=; b=Lg/uvPgJRaJcj8Q8UY9yep33r9mXNuo+XkbYzLgYOpNZgoaFgtyH8z8yKUFaemSfM1 61UE+JXHTNYDb2xgWu1iYW7udjSPvDazOPkd+4Zl2MwXzwy7dW9mmt3kTx5P3HDWbvuH NkSg7FGCw54X55AIl6mf7YkxXKsMmoZSKxD3wJQl9p1sKec4nvi2z2oE2LCbYoVdL2ud sdoB0BZTvd0KIKJ+yMV3ZoGg4dKmMv4gE9a4l7DXfdmYDsTwEtC+WZimrz9pGa4Iaw7w /FvGmdpnFV7RZgNecAOyoLfScMZDy2UXjdhPYChi8NR5oklmLoxGU2G2tzgp7N8a7eoJ duQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775232659; x=1775837459; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BBgZda7dL+HQerXbdb2ueaytDQmBFa29DJ7dQt1pg5E=; b=e8/PJcUJTYRgOPokDYJIZJI/0e8QCvglSdvvLNT0d/GZIjFp1BdBj+ojgErbwAENhw vdvVI7xbkq8GkhZWX2NXNc+TsjB8hSap1nJnZhG/sVlFyH4lKEcgX2NljL/2EIRinQBQ 7AEWjghcG9HY9hZpZwfSeOYnQDq5y18orfgjxKirfovIKF7pnRUoHwlgPYCtOK8xpHuY bM0zv9VJvT2iHJcI/2lPw/6SU3GAI38UBPrsqFT13xbBgZPN8RqGqiF6p1j8bL8L7DDJ 1J0bH+mEs+r6UVGXtK/RjQ0TeIdyIz8/ZA7PLSGmVbYL23ambfwNluVa5p0BH2gpOAr5 ls1w== X-Forwarded-Encrypted: i=1; AJvYcCUaCd26x4OnWUvX7RjL7hJ3I2r+kBdbbwY7KKO/WFjCHQwjPETh54v5EEROwNK97jCco0SG4dHHrBVvjJc=@vger.kernel.org X-Gm-Message-State: AOJu0YwOyfLLKlyNpb7TSmkEreTIlD+elFZSZ9c7BngEO8lm0wUwnP78 dIVSFlErSgckOECvhEltSVBLBOQqJjf6+IO8rIFyShKdaxm4VSMO6k/X X-Gm-Gg: AeBDiesSi0t7gwBHTn0sKKmTJtH8/l863NqY1O5laGMUyB31qNAzvN8DzQgnJNk6plc FbniPYhM6Ybrql8R/wp7aPDppPfNB5YRd+eDpJDngnX+6KR7y/SLY7zcNRdJZV1bFS6H/nvVImz 78yr1lkNPRBVOvyJ4h1IhjbdMiylrxNaB/Xf4T+d7xod911Y/wn4wP0Sk4byb3CnIN+y7zvLaHf WLj6Imuuq8d33c9rrgB+hYh1fSpKG2mBqjk4kGHUON1Uu83tW7EK6MuOkdDVhQe7bz/5ZoZRYTF zVaSGOZ6Zf5FQZK5qomMuOWpXLR1XFyVbU8HT7kigzuvjLZyWuMLATtIQYmTXpd4apIY8d/6Pn3 uzrwvyo98cszjIyb0GZQ1qHjmtk0O71WlbhQuVVjR6QHWHU1/5QMdGHx7AMpvoDefLLjmNdHG7M SLK2383XA9D3ChLy+ECHW+7Qt1eO5iOJ/s8Nml X-Received: by 2002:a17:903:1209:b0:2b2:4cd2:e16c with SMTP id d9443c01a7336-2b281846846mr35372085ad.20.1775232658965; Fri, 03 Apr 2026 09:10:58 -0700 (PDT) Received: from google.com ([2402:7500:477:c367:13c7:f0f4:4ae3:eaea]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27473583dsm60276935ad.9.2026.04.03.09.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 09:10:58 -0700 (PDT) Date: Sat, 4 Apr 2026 00:10:55 +0800 From: Kuan-Wei Chiu To: Josh Law Cc: david@davidgow.net, note351@hotmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org Subject: Re: [PATCH] lib/glob: add more KUnit tests for glob Message-ID: References: <20260403152853.61870-1-objecting@objecting.org> <19d540a3afb.4e80747a170670.7200857965755638934@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <19d540a3afb.4e80747a170670.7200857965755638934@objecting.org> On Fri, Apr 03, 2026 at 04:50:49PM +0100, Josh Law wrote: > ---- On Fri, 03 Apr 2026 16:49:10 +0100 visitorckw@gmail.com wrote ---- > > > > Hi Josh, > > > > On Fri, Apr 03, 2026 at 03:28:53PM +0000, Josh Law wrote: > > > Since there isnt much tests for lib/glob.c, lets go ahead and add some more > > tests > > > > checkpatch.pl generates the following warnings: > > > > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit > > description?) > > #60: > > Since there isnt much tests for lib/glob.c, lets go ahead and add some more > > tests > > > > WARNING: 'isnt' may be misspelled - perhaps 'isn't'? > > #60: > > Since there isnt much tests for lib/glob.c, lets go ahead and add some more > > tests > > ^^^^ > > > > total: 0 errors, 2 warnings, 31 lines checked > > > > I have mentioned this to you multiple times in the past: please always > > run checkpatch.pl to check your patches before sending them. > > > > Regards, > > Kuan-Wei > Hi Kuan, it was genuinely my mistake. I forgot to run check patch before sending it over. And this happened. I'll give it a bit before sending over a V2 fixing these issues :) Additionally, I believe many different people have already pointed out the word-wrapping issues in your replies. Some developers are even getting frustrated because of the repeated reminders. You have promised to fix this, yet every time you send a new email, the exact same problem persists. I would suggest that you figure out how to completely resolve this issue before attempting to submit new patches. Furthermore, you recently mentioned that you were going to take a break for a while, but less than a few days later, I am already receiving another patch from you. Regards, Kuan-Wei > > > > > > > > Signed-off-by: Josh Law > > > > > --- > > > lib/tests/glob_kunit.c | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/lib/tests/glob_kunit.c b/lib/tests/glob_kunit.c > > > index 362b1eda8e5b..73d4f72fa824 100644 > > > --- a/lib/tests/glob_kunit.c > > > +++ b/lib/tests/glob_kunit.c > > > @@ -90,6 +90,31 @@ static const struct glob_test_case glob_test_cases[] = { > > >     { .pat = "*abcd*abcdef*", .str = "abcabcdabcdeabcdefg", .expected = true > > }, > > >     { .pat = "*abcd*", .str = "abcabcabcabcefg", .expected = false }, > > >     { .pat = "*ab*cd*", .str = "abcabcabcabcefg", .expected = false }, > > > +    /* backslash escaping */ > > > +    { .pat = "\\a", .str = "a", .expected = true }, > > > +    { .pat = "\\a", .str = "\\a", .expected = false }, > > > +    { .pat = "\\*", .str = "*", .expected = true }, > > > +    { .pat = "\\*", .str = "a", .expected = false }, > > > +    { .pat = "\\?", .str = "?", .expected = true }, > > > +    { .pat = "\\?", .str = "a", .expected = false }, > > > +    { .pat = "\\[a]", .str = "[a]", .expected = true }, > > > +    { .pat = "\\\\", .str = "\\", .expected = true }, > > > +    { .pat = "a\\*b", .str = "a*b", .expected = true }, > > > +    { .pat = "a\\*b", .str = "aXb", .expected = false }, > > > +    /* trailing backslash */ > > > +    { .pat = "a\\", .str = "a", .expected = true }, > > > +    { .pat = "\\", .str = "", .expected = true }, > > > +    /* backwards ranges */ > > > +    { .pat = "[z-a]", .str = "m", .expected = false }, > > > +    { .pat = "[!z-a]", .str = "m", .expected = true }, > > > +    /* high-bit characters */ > > > +    { .pat = "\xc0", .str = "\xc0", .expected = true }, > > > +    { .pat = "\xc0", .str = "\x80", .expected = false }, > > > +    { .pat = "[\x80-\xff]", .str = "\xc0", .expected = true }, > > > +    { .pat = "[\x80-\xff]", .str = "\x7f", .expected = false }, > > > +    /* unclosed bracket as literal */ > > > +    { .pat = "[abc", .str = "[abc", .expected = true }, > > > +    { .pat = "[abc", .str = "a", .expected = false }, > > > }; > > > > > > static void glob_case_to_desc(const struct glob_test_case *t, char *desc) > > > -- > > > 2.34.1 > > > >