From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752956AbcFKQif (ORCPT ); Sat, 11 Jun 2016 12:38:35 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:52340 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbcFKQie (ORCPT ); Sat, 11 Jun 2016 12:38:34 -0400 Subject: Re: [PATCH] iio: generic_buffer: Fix --trigger-num option To: Crestez Dan Leonard , linux-iio@vger.kernel.org References: Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Daniel Baluta From: Jonathan Cameron Message-ID: Date: Sat, 11 Jun 2016 17:38:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/16 19:56, Crestez Dan Leonard wrote: > Initialize trig_num to -1 and handle trig_num=0 as a valid id. Good spot. Applied to the togreg branch of iio.git. Thanks, Jonathan > > Fixes: 7c7e9dad (iio: iio_generic_buffer: Add --trigger-num option) > Signed-off-by: Crestez Dan Leonard > --- > tools/iio/iio_generic_buffer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c > index e8c3052..0e8a1f7 100644 > --- a/tools/iio/iio_generic_buffer.c > +++ b/tools/iio/iio_generic_buffer.c > @@ -341,7 +341,7 @@ int main(int argc, char **argv) > > char *data = NULL; > ssize_t read_size; > - int dev_num = -1, trig_num; > + int dev_num = -1, trig_num = -1; > char *buffer_access = NULL; > int scan_size; > int noevents = 0; > @@ -456,7 +456,7 @@ int main(int argc, char **argv) > > if (notrigger) { > printf("trigger-less mode selected\n"); > - } if (trig_num > 0) { > + } if (trig_num >= 0) { > char *trig_dev_name; > ret = asprintf(&trig_dev_name, "%strigger%d", iio_dir, trig_num); > if (ret < 0) { >