Re: [PATCH v2 04/14] dt-bindings: mfd: bd96802: Add ROHM BD96806

[Matti Vaittinen <mazziesaccount@gmail.com>]

On 25/03/2025 19:14, Conor Dooley wrote:
> On Mon, Mar 24, 2025 at 10:55:21AM +0200, Matti Vaittinen wrote:
>> The ROHM BD96806 is very similar to the BD96802. The differences visible
>> to the drivers is different tune voltage ranges.
>>
>> Add compatible for the ROHM BD96805 PMIC.
>>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>>
>> ---
>> Revision history:
>>   v1 => :
>>    - No changes
>> ---
>>   .../bindings/mfd/rohm,bd96802-pmic.yaml       | 19 ++++++++++---------
>>   1 file changed, 10 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd96802-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd96802-pmic.yaml
>> index d5d9e69dc0c2..c6e6be4015b2 100644
>> --- a/Documentation/devicetree/bindings/mfd/rohm,bd96802-pmic.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd96802-pmic.yaml
>> @@ -4,23 +4,23 @@
>>   $id: http://devicetree.org/schemas/mfd/rohm,bd96802-pmic.yaml#
>>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>>   
>> -title: ROHM BD96802 Scalable Power Management Integrated Circuit
>> +title: ROHM BD96802 / BD96806Scalable Power Management Integrated Circuit
>                                  ^ Missing space here :)
> 
>>   
>>   maintainers:
>>     - Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
>>   
>>   description: |
>> -  BD96802Qxx-C is an automotive grade configurable Power Management
>> -  Integrated Circuit supporting Functional Safety features for application
>> +  BD96802Qxx-C and BD96806 are automotive grade configurable Power Management
>> +  Integrated Circuits supporting Functional Safety features for application
>>     processors, SoCs and FPGAs
>>   
>>   properties:
>>     compatible:
>> -    const: rohm,bd96802
>> +    enum:
>> +      - rohm,bd96802
>> +      - rohm,bd96806
>>   
>>     reg:
>> -    description:
>> -      I2C slave address.
> 
> I'd just drop this from the original.

Ah, thanks! I should've noticed this.

>>       maxItems: 1
>>   
>>     interrupts:
>> @@ -29,7 +29,8 @@ properties:
>>         for fatal IRQs which will cause the PMIC to shut down power outputs.
>>         In many systems this will shut down the SoC contolling the PMIC and
>>         connecting/handling the errb can be omitted. However, there are cases
>> -      where the SoC is not powered by the PMIC. In that case it may be
>> +      where the SoC is not powered by the PMIC or has a short time backup
>> +      energy to handle shutdown of critical hardware. In that case it may be
>>         useful to connect the errb and handle errb events.
>>       minItems: 1
>>       maxItems: 2
>> @@ -69,7 +70,7 @@ examples:
>>               interrupt-names = "intb", "errb";
>>   
>>               regulators {
>> -                buck1: BUCK1 {
>> +                buck1 {
> 
> Here too?

Yes! I had the node names with caps in downstream (due to a historical 
reasons :]) - and I did a last minute clean-up where I changed it to 
lowercase. Thanks for pointing these out!

Yours,
	-- Matti