From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69F8833260E for ; Fri, 27 Mar 2026 16:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774627811; cv=none; b=MDpLeCkbUDRrRw8RjOAeXiGVoHgan+aoEfxoDNGInFT/rNtf0HiOSNAitpY6czNhJ0GGeAGa2g3aqV/dOT7z5Pd1Sqkd+I12EQi+unsoheE7p26uYy7v5KGpFhh9jLafEVDf2NsZIoEyeeSaWoS/sSnaAP+Tqaf0Rd0uU1SfP4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774627811; c=relaxed/simple; bh=j+iHMqZZZPvul2H2ynByaqOgJfdyuOPXNi0sju8ZOmE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NFTxcOfd+VZo572I/nkdAg7+LLXd4sDr1VlRDnKAlxlxsKDHxxV9BEhcPO3gewq1AGqQ7PVPqqjENtz6bAiY42b7MTc31yzWA0KPmFHNsZ3glTzktv3m1MIwT1Cl0h0J9d3XHl2KGbqXz6T8WrwnJfajTx8KDTPY5BsWrb9DVVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I8Q3I6Wc; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I8Q3I6Wc" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2bd9a485bd6so4313597eec.1 for ; Fri, 27 Mar 2026 09:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774627809; x=1775232609; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hVMcFJUvJpd+4pXEPRFZ0blA27q/n9xr9R2vqHRpd7I=; b=I8Q3I6WcZDBHzN3ogRgl5CBSJTF/o//NKWx9iSYusR5Y16E2urNp8OeAQXohhlj6DG Bo/31Pb47omYYU+rPdO5im8V9Fg8SUb9DI7Ngqe0hgFpxfw7mDxms2hTjNIpuBs191iu rZKQqp4GMVpAkPCIdiLW/oEsOqTPTlVI5U2fngXbKf6f5WCyZbGzh3vBjgnXDv/tpafy vwkyVi1DOoJXGEUbPPi9XRXBjcKNU7OYeuzZCjmOrNfJIZyACzsLXk+wDmyz3qHR6ilG OOcf/Q0/O97o9bHvH9YP0/ksI+dUfAtEfWhkfLZp91k6SyrPYXVTi1+wndPi4AC95Ldp Avmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774627809; x=1775232609; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hVMcFJUvJpd+4pXEPRFZ0blA27q/n9xr9R2vqHRpd7I=; b=X6nwtVIjKPouYU04s4O9ujKxMHsTPhoIVLLZWbgaWjy8FUAADhTMW6mOUf07jWcRwD aDa6yXP9k0ftYn7GeHw9LvONOZNyQkWngtzFAgPweS8VMGArbAFYNTzLk5aeIw5KdRwv PjRUaZjzZ/4nlSPv2POHmxAFucO9tak8EF0I854v0Dua+K3WdLd6Oh0KSojIORpt7Qyi EWnml0Oc3JHgdClbAO9eIe9uwZSyWFKrzSg5QpmMCUwMqUBNgg+RZJMVA8q9IcPrzl4O fulcNcbyp2Me5TiMZl3LO+k2+DBHbJtfHHj3qcmAie35txKlQba4YyDKhF4jjfkL+o4/ 41wQ== X-Forwarded-Encrypted: i=1; AJvYcCV4cAsdXyiTf1j/Cg0BeaYAevIRF0+RSwOKGkex7cQXpbICXzuST/gkcfSiD4yPGN3jS4TYSpItIhUk7NI=@vger.kernel.org X-Gm-Message-State: AOJu0YyiwA7EV550EYOcIjd5wg8NTx+f92L4mjTfjW//vmlTXLeSzpy+ 8O5viw9L9zFX+4JAkT6MvQMoo3Wl6WCHKshbZcUbT7G+yVcb/Sm1UK53 X-Gm-Gg: ATEYQzxTk2mjKdiwcmYHffbEfdNJhx4ivNeUBgfqeu35G+AV3yoN25P1UCTtAqR4uQQ zW7fCsi5DNIJw6y53G9M4BFMNVND9JzxDgFygmEliPxg7scXNoXsRAYlut5Q/GqheVDQQBq67e9 MBGOKEb0yMfOKRk09Ozp2NMaYXJ4xqcQ0uVA2SlFtiHYCs0qDGhPlcQMNSUty2JS5KFiPg1QDBV cWNuVer+T+rUlVW5vIgDGIsN7IMvClJw2tUKcFgY9ijRXjvLkI0SaLPMSQl/3hztW+PcYoWRhtG tgw0Zfbkdyxcx+uVsFjKV26jeU54RvTrDkg4vTWgx3w8u/mxedH/Zfo5TpuS8tJ/wWvXIkVlTDq /yygU3298q0ckbFdnxgGGkoG+ysWAwNJvwdMTEnJI++GAGU/8V+DPS1a9j4GRfTo6GicRTkOtwV Ysdrb9n9Zl6lQcVxXADD2/2QtEYuRU3cplbvA5Gs7ScUs9FIbQ/n0WG2MO6oOpQy1PsMpnbfn38 bw= X-Received: by 2002:a05:7300:4348:b0:2be:ca4:e118 with SMTP id 5a478bee46e88-2c185f80f25mr1632667eec.28.1774627809228; Fri, 27 Mar 2026 09:10:09 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:85b0:37ea:7fa8:4717]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c16ee2a41fsm5360443eec.28.2026.03.27.09.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 09:10:08 -0700 (PDT) Date: Fri, 27 Mar 2026 09:10:05 -0700 From: Dmitry Torokhov To: Matti Vaittinen Cc: Lee Jones , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] mfd: rohm-bd718x7: Use software nodes for gpio-keys Message-ID: References: <20260324-rohm-software-nodes-v3-0-edde5a0324d5@gmail.com> <20260324-rohm-software-nodes-v3-2-edde5a0324d5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 27, 2026 at 12:55:55PM +0200, Matti Vaittinen wrote: > On 25/03/2026 02:54, Dmitry Torokhov wrote: > > + > > + node_group = (const struct software_node *[]){ > > + &nodes[0], > > + &nodes[1], > > + NULL > > + }; > > Hmm. I suppose I was not explaining myself well. When I asked for a > temporary variable, I was hoping to get rid of this syntax. Something like: > const struct software_node *node_group[3]; > > node_group[0] = &nodes[0]; > node_group[1] = &nodes[1]; > node_group[2] = NULL; > > would look more familiar to me. Well, I suppose I can live with this if it > is Ok to Lee though. Let's see if he has an opinion. This is simply a compound literal, part of the C standard since C99. It allows skip explicitly declaring the dimensions of the node_group[] array (which is "far" away from where we initialize it and it potentially may get out of sync). We have quite a few in the kernel, DEFINE_RES_IRQ() and others for example are compound literals under the hood. Thanks. -- Dmitry