From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3803446A6 for ; Fri, 27 Mar 2026 16:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774627736; cv=none; b=KlfXgnsl+PCEyCyWlOCuIzXmdxOgwfgOp7NeQzsm22hvtZ5IlD4l6qW6E8Jzb0ynQSDaFHwzHl7oc7u12+Msp9FmS3ANvzjOUjQuLNB4cjs0noUnIbPBv1B0936WIwxBseiW6nzLdV6mz37HxGxjvL8hd8R64oAlH2He7fhbkG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774627736; c=relaxed/simple; bh=r/ECzjLQFj1oNEk6VwFfK6oRCizfzd77iuutU4bWNbA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fCMnXq9nm9lWM+6apRdmZzfAs4gBbCFG2pWw/PbIpvhw7RkxubaVMHIfr4PCPHI7sSY8zItbwfu1vaHf95nBDLxpBL5MjzOG/gVvSurW/3AHpQzyke1j/rRBNqXLBiQ8vH1wOgT7oSKreLyoCmegTTtJARhddhfgJzppdfkhHNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=AAMIcA/q; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="AAMIcA/q" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-439c6fc2910so1602107f8f.0 for ; Fri, 27 Mar 2026 09:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774627730; x=1775232530; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CHX0A3l+EGA3RL7wgoJYZ/pJ9qLrCmQ2bWRzcXIszA0=; b=AAMIcA/qHvgFMeuhu2M1NnePkGMngg5INqf0xJEOdaj+oUrO9d0o7TIhskBfAQORR6 6JZNiY5LT8bJikwsiM8WqAFP4TvxgF+slgWv4gjRS4uo1vI+4tAB0s2idvPa296wsrtM qJiRifCOf2RkPBIUvt1oot7LZpT49h+JDZT61Y4TJT4Cqivh64aGXPdh/0jKxOD8PAdF yHdGl+yQDbtTBwj0Oqd6jeAiMVlvZL9Em6SLktjXZNPDrrE3H9u9xrxJTrFFGe4HlOxS 9tOPnBF1UepCuKsbhObqhGcwK6lBCZnZ9cClXbbnn7VQ9hTiCqzCkFN3n9mulG1ZDQCK R4vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774627730; x=1775232530; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CHX0A3l+EGA3RL7wgoJYZ/pJ9qLrCmQ2bWRzcXIszA0=; b=WRiW2S7OXbTupCTkv2EyX+yhIA7I9Y7Mvws8pRx9cuwFU10hbgi/YzTuOzFeDNXk/n 2vKxLMSS4Axf+XeifLYvUw/8hGB0IKiPOk7CRgqmJ507UTEnlPESjK2X86HFn0TQZtS/ GQtQthX1jgsl5Evwrq4TpkS7ZO4huy3Ntk1TWkB9/lTinmCMdkWWuRb11zwozfP7eUbs MZJ2AwGJld66aBX4lAodrlJA7fwWsHXbMv6siKx8Ri3uA7kmR+FQE2F3K7hOXJ3jsVJd /joSybVKjFDwXiHUjthLNsQY6/IhnPbTXoZgkdf1v0rX8RlDb3KpSbLIJHXyawBPfQWj MmCw== X-Forwarded-Encrypted: i=1; AJvYcCX31JtkxXBDfzHtfKgjxz4Mj/WqXKpGCl+F019ug6c++666p16zx4rifrY2ll+t3pUEB/d0OBWW5Fymaqk=@vger.kernel.org X-Gm-Message-State: AOJu0YxxPvEk7wdaJpfpCjyNO7wioYsqtCsZ4gmo+o/1FZwluUscyEcB TvJ4TsbIjZMtVGEiXG+m0vcV7NaRafkGRJI3D3qF9bQMOY1IzsNYgT2i9wBZbRGLKLs= X-Gm-Gg: ATEYQzx+f7KWPS5NuDZLz9cQ3UNBn0Ivv4WL5aIC+IMbgYh9uDEm5Esi2nnxj5EqGD+ 50vkbfTgsjN+YEplaRx6y1oUOFeT9Ui1OOReHNbbQhFxHsIvb5urS9/N5H8TAPXFfcbpJUvPeyP VGIYiRdnaJBPenWkA3dOlB9r598XIGsQYsQxlJwClEE0C/K9DYOLkGrmty90SPZpOOEoanBSNeN 6+PbxDPDM0s904JtgS3i5whSB/xrh2+ZpptjiAmnpCPN5kAsP/gyfoPZMUR05qG5UU6wUFTV2hX KdHDonzXRhIsytm6LNRPOGQMeSIEwykpRybPDLYuL0wf9jIQnK1ZL1GYhCI+sv4les/GjpOfalT OUN4JGqjDz8Wpuaybr3xwWLoWF6P4B6sMcMI11if4VQIfcLVCcYwT2JfLMFzPkjt5C4q9NAMc2V JII5QnNNc/DJLrTnM5z/KwHQzaeA== X-Received: by 2002:a05:6000:604:b0:43b:4592:f91b with SMTP id ffacd0b85a97d-43b9e98162bmr5043495f8f.5.1774627729917; Fri, 27 Mar 2026 09:08:49 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919cf2bdsm16733001f8f.21.2026.03.27.09.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 09:08:49 -0700 (PDT) Date: Fri, 27 Mar 2026 17:08:47 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v2 2/2] printk_ringbuffer: Add sanity check for 0-size data Message-ID: References: <20260326133809.8045-1-john.ogness@linutronix.de> <20260326133809.8045-2-john.ogness@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326133809.8045-2-john.ogness@linutronix.de> On Thu 2026-03-26 14:44:02, John Ogness wrote: > get_data() has a sanity check for regular data blocks to ensure at > least space for the ID exists. But a regular block should also have > at least 1 byte of data (otherwise it would be data-less instead of > regular). > > Expand the get_data() block size sanity check to additionally expect > at least 1 byte of data. > > Signed-off-by: John Ogness Looks good to me. It complements the 1st patch. Reviewed-by: Petr Mladek Tested-by: Petr Mladek Best Regards, Petr