From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8094B280336 for ; Fri, 27 Mar 2026 18:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774636786; cv=none; b=p/MDh+nzM3bXsZgu0pd+QCeEKZW5A3qC2psJ2hQNzBoj4hXqT+wijhCHEKeCYj8/WSHv5iDcxCkUHTzlo/+Qq2GLfcVofXOLcGTzlzfsobpYS4b97y/yOhpvHStKuOezniEZ1FzsRdiceUrJMkZpewb4ZPKrePfK1V+iaSCsIGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774636786; c=relaxed/simple; bh=22Xz3+eZMS7/J6rdfE1EEuhHi9H26t+XeUeP6Ef2daI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vezuoo2xGRO+QH3xHPAxumkwIK8f1kXGmuMq0Eo+2MgvBcJJ3K9lWwuwSTzrzU2AOfrPD5Q78BpTVm8MrvVjedE5VvPk0K6fLKylpIypc6knJEXnS43BczKbC5sA7TG1QncpiZ9V2Qia1o1w/3hqtEfJ43gQBCD9yKJTApkpjzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=D8dhepfl; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D8dhepfl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774636784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IYQ+qhUAXb2Z9JfIpc10XqqDG6/nzFbrgxdQauX3Mys=; b=D8dhepfl/FLSZJqmNIG4GEw+kW4JEvFWuoAPU3jNaJ7HiXoKU9R0gDm+fmSDjBQqtPphqY aWunPCSqDtLlt11LJWgbZaXrLG0H+LbMC0NdpklUDNV4m0Z2tVlibwKl8tcDQMNq/T+vzT fe+bPuhBchEfF0vEes3K69tjlxfsZNM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-z0Gue9LOOhq3GuO7EECm2w-1; Fri, 27 Mar 2026 14:39:39 -0400 X-MC-Unique: z0Gue9LOOhq3GuO7EECm2w-1 X-Mimecast-MFC-AGG-ID: z0Gue9LOOhq3GuO7EECm2w_1774636777 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7C4FD1956062; Fri, 27 Mar 2026 18:39:37 +0000 (UTC) Received: from thinkpad (unknown [10.44.33.208]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C987F1800351; Fri, 27 Mar 2026 18:39:34 +0000 (UTC) Date: Fri, 27 Mar 2026 19:39:31 +0100 From: Felix Maurer To: Luka Gejak Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, horms@kernel.org, liuhangbin@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 2/4] net: hsr: fix VLAN add unwind on slave errors Message-ID: References: <20260326154715.38405-1-luka.gejak@linux.dev> <20260326154715.38405-3-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On Fri, Mar 27, 2026 at 05:03:18PM +0100, Luka Gejak wrote: > On March 27, 2026 12:52:02 PM GMT+01:00, Felix Maurer wrote: [...] > >nit: superflous empty line (it's inconsistent with the other case > >blocks) > Good catch. I'll drop the extra newline in v3. > >I think this would look cleaner with the good and the bad paths in > >the same switch-case, but that may be a matter of (my) taste. What do > > you think? > Very well. I will take your preference into consideration and will > make mentioned changes in v3. However I am not currently home and will > send v3 once I come home in 1-2 days. Alright, thank you! No hurry, take your time. Just fyi, I'll be out of office next week, but I'll definitely review v3 as soon as I'm back (if nobody else did it in the meantime). Thanks, Felix