Re: [PATCH] mmc: dw_mmc-rockchip: add dependency to ROCKCHIP_PM_DOMAINS

["Arnd Bergmann" <arnd@arndb.de>]

On Thu, Sep 11, 2025, at 18:05, Heiko Stübner wrote:
>
> Am Donnerstag, 11. September 2025, 17:03:14 Mitteleuropäische 
> Sommerzeit schrieb Ulf Hansson:
>> On Thu, 11 Sept 2025 at 16:43, Mikko Rapeli <mikko.rapeli@linaro.org> wrote:
>> > @@ -866,7 +866,7 @@ config MMC_DW_PCI
>> >
>> >  config MMC_DW_ROCKCHIP
>> >         tristate "Rockchip specific extensions for Synopsys DW Memory Card Interface"
>> > -       depends on MMC_DW && ARCH_ROCKCHIP
>> > +       depends on MMC_DW && ARCH_ROCKCHIP && ROCKCHIP_PM_DOMAINS

The hard dependencies are usually only for compile-time requirements.

Ideally this should go the other way and use

      depends on (ARCH_ROCKCHIP || COMPILE_TEST)

after you check that this actually builds on x86 with COMPILE_TEST
enabled, as there may be other compile-time dependencies.
 
>> Rather than "depends on", I think a "select" is better to be added
>> from the platform's Kconfig. Probably drivers/soc/rockchip/Kconfig is
>> where to put this.
>> 
>> Assuming that ROCKCHIP_PM_DOMAINS is a critical piece for most
>> Rockchip platforms to work.
>
> I'd think
> - arch/arm64/Kconfig.platforms
> - arch/arm/mach-rockchip/Kconfig
> would be the correct positions.
>
> And as Ulf suggested, this should be a "select"

I think in this case a 'default ARCH_ROCKCHIP' in the
ROCKCHIP_PM_DOMAINS definition is sufficient to have it
normally enabled, and still allows someone to try turning
it into a loadable module later, which would be a requirement
e.g. for Android GKI.

    Arnd